fix(NA): MaxListenersExceededWarning on getLoggerStream#57133
Merged
mistic merged 5 commits intoelastic:masterfrom Feb 10, 2020
Merged
fix(NA): MaxListenersExceededWarning on getLoggerStream#57133mistic merged 5 commits intoelastic:masterfrom
mistic merged 5 commits intoelastic:masterfrom
Conversation
…h for getLoggerStream
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
Author
|
@elasticmachine merge upstream |
nickofthyme
approved these changes
Feb 7, 2020
Contributor
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM! Ran locally and memory error is gone. 🎉
joshdover
approved these changes
Feb 7, 2020
jbudz
reviewed
Feb 7, 2020
…bana into fix-log-reporter-max-listeners
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Feb 10, 2020
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Feb 10, 2020
* fix(NA): possible EventEmitter memory leak detected with a passthrough for getLoggerStream * chore(na): remove passthrough Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Feb 10, 2020
* fix(NA): possible EventEmitter memory leak detected with a passthrough for getLoggerStream * chore(na): remove passthrough Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2020
* master: (34 commits) [Index management] Server-side NP ready (elastic#56829) Webhook action - make user and password secrets optional (elastic#56823) [DOCS] Removes reference to IRC (elastic#57245) [Monitoring] NP migration: Local angular module (elastic#51823) [SIEM] Adds ECS link to help menu (elastic#57104) Ensure http interceptors are shares across lifecycle methods (elastic#57150) [Remote clusters] Migrate server code out of legacy (elastic#56781) fixes render bug in alert list (elastic#57152) siem 7.6 updates (elastic#57169) Make the update alert API key API work when AAD is out of sync (elastic#56640) fix(NA): MaxListenersExceededWarning on getLoggerStream (elastic#57133) [Metrics UI] Setup commonly used time ranges in timepicker (elastic#56701) [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) Create plugin mock for event log plugin (elastic#57048) fix ts error on master (elastic#57236) Don't create API key for disabled alerts when calling create API (elastic#57041) Fix enable and disable API to still work when AAD is out of sync (elastic#56634) [DOCS] Canvas embed objects (elastic#57156) Delete autocomplete namespace (elastic#57187) Security - Inject logout url (elastic#57201) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That solves a recent warning we have been experiencing, since #55937 was merged, every time we start the server.
We just hit the default max listeners value for
process.stdoutdue to the way thelegacy loggerworks. That sets a new hard limit.MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added. Use emitter.setMaxListeners() to increase limit at _addListener (events.js:256:17) at WriteStream.prependListener (events.js:279:14) at prependListener (_stream_readable.js:56:20) at KbnLoggerStringFormat.pipe (_stream_readable.js:738:3) at getLoggerStream (/Users/nicholaspartridge/Documents/repos/kibana/src/legacy/server/logging/log_reporter.js:49:6) at loggingConfiguration (/Users/nicholaspartridge/Documents/repos/kibana/src/legacy/server/logging/configuration.js:50:24) at setupLogging (/Users/nicholaspartridge/Documents/repos/kibana/src/legacy/server/logging/index.js:28:14) at new LegacyLoggingServer (/Users/nicholaspartridge/Documents/repos/kibana/src/core/server/legacy/logging/legacy_logging_server.ts:103:5) at new LegacyAppender (/Users/nicholaspartridge/Documents/repos/kibana/src/core/server/legacy/logging/appenders/legacy_appender.ts:45:26) at Function.create (/Users/nicholaspartridge/Documents/repos/kibana/src/core/server/logging/appenders/appenders.ts:75:16) at LoggingService.upgrade (/Users/nicholaspartridge/Documents/repos/kibana/src/core/server/logging/logging_service.ts:71:49) at MapSubscriber.configService.getConfig$.pipe.config [as project] (/Users/nicholaspartridge/Documents/repos/kibana/src/core/server/root/index.ts:102:41) at MapSubscriber._next (/Users/nicholaspartridge/Documents/repos/kibana/node_modules/rxjs/src/internal/operators/map.ts:84:29) at MapSubscriber.Subscriber.next (/Users/nicholaspartridge/Documents/repos/kibana/node_modules/rxjs/src/internal/Subscriber.ts:99:12) at SwitchMapSubscriber.notifyNext (/Users/nicholaspartridge/Documents/repos/kibana/node_modules/rxjs/src/internal/operators/switchMap.ts:166:24) at InnerSubscriber._next (/Users/nicholaspartridge/Documents/repos/kibana/node_modules/rxjs/src/internal/InnerSubscriber.ts:17:17)Thanks @spalger for the discussion and the ideas around it!