Create plugin mock for event log plugin#57048
Merged
mikecote merged 3 commits intoelastic:masterfrom Feb 10, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pmuellr
approved these changes
Feb 7, 2020
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
LGTM; per the previous mocks PR I reviewed, I'm guessing we'll want to provide an easy-to-get eventLog logger instance as well as the setup/start mocks, but we can wait till we need it ...
Contributor
Author
I saw there's an event logger mock already so I modified it to be consistent and made it return from the event log service 👍 |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Feb 10, 2020
* Create plugin mock for event log plugin * Share event logger mock with event log service Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote
added a commit
that referenced
this pull request
Feb 10, 2020
* Create plugin mock for event log plugin * Share event logger mock with event log service Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2020
* master: (34 commits) [Index management] Server-side NP ready (elastic#56829) Webhook action - make user and password secrets optional (elastic#56823) [DOCS] Removes reference to IRC (elastic#57245) [Monitoring] NP migration: Local angular module (elastic#51823) [SIEM] Adds ECS link to help menu (elastic#57104) Ensure http interceptors are shares across lifecycle methods (elastic#57150) [Remote clusters] Migrate server code out of legacy (elastic#56781) fixes render bug in alert list (elastic#57152) siem 7.6 updates (elastic#57169) Make the update alert API key API work when AAD is out of sync (elastic#56640) fix(NA): MaxListenersExceededWarning on getLoggerStream (elastic#57133) [Metrics UI] Setup commonly used time ranges in timepicker (elastic#56701) [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) Create plugin mock for event log plugin (elastic#57048) fix ts error on master (elastic#57236) Don't create API key for disabled alerts when calling create API (elastic#57041) Fix enable and disable API to still work when AAD is out of sync (elastic#56634) [DOCS] Canvas embed objects (elastic#57156) Delete autocomplete namespace (elastic#57187) Security - Inject logout url (elastic#57201) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #57046.
In this PR, I'm creating a
server/mocks.tsfile within the event log plugin to allow other plugins to mock event log plugin in their tests.