Webhook action - make user and password secrets optional#56823
Merged
peterschretlen merged 14 commits intoelastic:masterfrom Feb 10, 2020
Merged
Webhook action - make user and password secrets optional#56823peterschretlen merged 14 commits intoelastic:masterfrom
peterschretlen merged 14 commits intoelastic:masterfrom
Conversation
added 4 commits
February 4, 2020 23:05
…ing/webhook-basic-auth-optional
added 2 commits
February 5, 2020 09:23
peterschretlen
commented
Feb 5, 2020
|
|
||
| after(() => esArchiver.unload('empty_kibana')); | ||
|
|
||
| it('webhook can be executed without username and password', async () => { |
Contributor
Author
There was a problem hiding this comment.
This test is in the spaces_only functional test config because it does not use security, so the webhook simulator can be used without auth.
peterschretlen
commented
Feb 5, 2020
| expect(result.status).to.eql('error'); | ||
| expect(result.message).to.match(/error calling webhook, invalid response/); | ||
| expect(result.serviceMessage).to.eql('[400] Bad Request'); | ||
| expect(result.message).to.match(/error calling webhook, retry later/); |
Contributor
Author
There was a problem hiding this comment.
The expected result here was incorrect due to a typo in the webhook simulator when the body is failure
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
requested changes
Feb 5, 2020
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, but I think we need to change the config.schema definition to use schema.nullable(), made a few other comments.
Contributor
Author
|
@elasticmachine merge upstream |
….com/peterschretlen/kibana into alerting/webhook-basic-auth-optional
…ing/webhook-basic-auth-optional
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
peterschretlen
pushed a commit
to peterschretlen/kibana
that referenced
this pull request
Feb 10, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2020
* master: (34 commits) [Index management] Server-side NP ready (elastic#56829) Webhook action - make user and password secrets optional (elastic#56823) [DOCS] Removes reference to IRC (elastic#57245) [Monitoring] NP migration: Local angular module (elastic#51823) [SIEM] Adds ECS link to help menu (elastic#57104) Ensure http interceptors are shares across lifecycle methods (elastic#57150) [Remote clusters] Migrate server code out of legacy (elastic#56781) fixes render bug in alert list (elastic#57152) siem 7.6 updates (elastic#57169) Make the update alert API key API work when AAD is out of sync (elastic#56640) fix(NA): MaxListenersExceededWarning on getLoggerStream (elastic#57133) [Metrics UI] Setup commonly used time ranges in timepicker (elastic#56701) [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) Create plugin mock for event log plugin (elastic#57048) fix ts error on master (elastic#57236) Don't create API key for disabled alerts when calling create API (elastic#57041) Fix enable and disable API to still work when AAD is out of sync (elastic#56634) [DOCS] Canvas embed objects (elastic#57156) Delete autocomplete namespace (elastic#57187) Security - Inject logout url (elastic#57201) ...
peterschretlen
pushed a commit
that referenced
this pull request
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the
userandpasswordsecrets in the webhook action optional.Resolves #55359
Checklist
Delete any items that are not applicable to this PR.
For maintainers