Fix setting filters without $store value by Dosant · Pull Request #56304 · elastic/kibana

Dosant · 2020-01-29T15:37:48Z

Summary

Follow up on: #56213

AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

I am not sure, if there is a way to reproduce the bug from the UI, except already fixed #56213. So the bug's impact is unknown.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2020-01-29T17:31:56Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

Dosant · 2020-01-29T17:32:56Z

@elasticmachine merge upstream

Dosant · 2020-01-30T10:00:01Z

@elasticmachine merge upstream

src/plugins/data/public/query/filter_manager/filter_manager.ts

Setting the store is not longer temporary

src/plugins/data/public/query/filter_manager/filter_manager.test.ts

lizozom

Tested and makes sense.
Merging this means that #56213 can be reverted! @FrankHassanabad

Dosant · 2020-01-30T15:58:18Z

@elasticmachine merge upstream

kibanamachine · 2020-01-30T17:16:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d98d2d7

History

💔 Build #23486 failed 7bf3c88
💛 Build #23471 was flaky bcb012e
💛 Build #23353 was flaky 068a0fe
💚 Build #23318 succeeded c0b6cbe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant · 2020-01-31T09:04:11Z

src/plugins/data/public/query/filter_manager/filter_manager.ts

+      ? esFilters.FilterStateStore.GLOBAL_STATE
+      : esFilters.FilterStateStore.APP_STATE;
+
+    FilterManager.setFiltersStore(newFilters, store);


note: FilterManager.setFiltersStore() sets new store only if filter is missing it

Maybe rename method?

Agree that we should rename it. But I think we better do it in separate pr to keep this one scoped to filter_manager and just the bugfix which we backport to 7.6

Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

* master: (53 commits) Fix setting filters without $store value (elastic#56304) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935) [reporting] remove a legacy cross-plugin import (elastic#56354) [DOCS] Updates example in Timelion doc (elastic#56444) [APM] Service map center button (elastic#56434) [skip-ci] Add example for migrating pre-handlers (elastic#56080) [ML] Fix Data Visualizer responsive layout (elastic#56372) Add missing docker settings (elastic#56411) [Endpoint] Add Endpoint Details route (elastic#55746) chore(NA): delete data/optimize with kbn clean (elastic#55890) System index templates can't be edited (elastic#55229) Sync badge (elastic#55113) Only fire appState changes when there is a change (elastic#56183) Import appropriate files to setup plugin system at the correct time (elastic#55956) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) [ML] conditional rison encoding for query params (elastic#56380) Move tsvb server to new platform (elastic#55310) exclude tutorial resources from code ownership (elastic#55987) [Watcher] Follow up on flaky functional test (elastic#56384) ...

Follow up on: #56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

…56356 * '7.x' of github.com:elastic/kibana: (23 commits) Fix setting filters without $store value (elastic#56304) (elastic#56475) [ML] Fix Data Visualizer responsive layout (elastic#56372) (elastic#56472) [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471) [APM] Fit service map to container (elastic#56336) (elastic#56463) Add animation to service map layout (elastic#56042) (elastic#56460) chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422) [APM] Storybook support (elastic#54970) (elastic#56445) [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454) [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320) [DOCS] Adds breaking changes for 7.6 (elastic#56437) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421) [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436) [7.x] System index templates can't be edited (elastic#55229) (elastic#56417) Add missing docker settings (elastic#56411) [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386) fix edit rule for detections (elastic#56333) (elastic#56405) [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385) [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757) Move tsvb server to new platform (elastic#55310) (elastic#56394) ...

Follow up on: #56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

Dosant added 2 commits January 29, 2020 13:26

fix missing store when setFilters() is called

7017440

add tests

c0b6cbe

Dosant marked this pull request as ready for review January 29, 2020 17:31

Dosant requested a review from a team as a code owner January 29, 2020 17:31

Dosant added v8.0.0 v7.7.0 Team:AppArch labels Jan 29, 2020

Dosant added review release_note:skip Skip the PR/issue when compiling release notes labels Jan 29, 2020

Dosant requested a review from lizozom January 29, 2020 17:32

Merge branch 'master' into dev/filter-manager/missing-store-fix

068a0fe

Merge branch 'master' into dev/filter-manager/missing-store-fix

d2fba7a

lizozom reviewed Jan 30, 2020

View reviewed changes

src/plugins/data/public/query/filter_manager/filter_manager.ts Outdated Show resolved Hide resolved

remove comment

bcb012e

Setting the store is not longer temporary

streamich reviewed Jan 30, 2020

View reviewed changes

src/plugins/data/public/query/filter_manager/filter_manager.test.ts Show resolved Hide resolved

improve tests

7bf3c88

lizozom approved these changes Jan 30, 2020

View reviewed changes

Merge branch 'master' into dev/filter-manager/missing-store-fix

d98d2d7

Dosant commented Jan 31, 2020

View reviewed changes

Dosant added bug Fixes for quality problems that affect the customer experience v7.6.0 labels Jan 31, 2020

Dosant merged commit 6942f3e into elastic:master Jan 31, 2020

Dosant deleted the dev/filter-manager/missing-store-fix branch January 31, 2020 09:53

Dosant mentioned this pull request Jan 31, 2020

[7.x] Fix setting filters without $store value (#56304) #56475

Merged

Dosant added a commit to Dosant/kibana that referenced this pull request Jan 31, 2020

Fix setting filters without $store value (elastic#56304)

f9594fd

Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

Dosant mentioned this pull request Jan 31, 2020

[7.6] Fix setting filters without $store value (#56304) #56476

Merged

Dosant added a commit that referenced this pull request Jan 31, 2020

Fix setting filters without $store value (#56304) (#56475)

b916251

Follow up on: #56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

Dosant added a commit to Dosant/kibana that referenced this pull request Jan 31, 2020

Fix setting filters without $store value (elastic#56304)

1abe049

Follow up on: elastic#56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

Dosant added a commit that referenced this pull request Jan 31, 2020

Fix setting filters without $store value (#56304) (#56476)

7f9564e

Follow up on: #56213 AddFilters method had logic which ensured that $store exists in filter object, but setFilters was missing that.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix setting filters without $store value#56304

Fix setting filters without $store value#56304
Dosant merged 7 commits intoelastic:masterfrom
Dosant:dev/filter-manager/missing-store-fix

Dosant commented Jan 29, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jan 29, 2020

Uh oh!

Dosant commented Jan 29, 2020

Uh oh!

Dosant commented Jan 30, 2020

Uh oh!

Uh oh!

Uh oh!

lizozom left a comment

Uh oh!

Dosant commented Jan 30, 2020

Uh oh!

kibanamachine commented Jan 30, 2020

Uh oh!

Dosant Jan 31, 2020

Uh oh!

lizozom Jan 31, 2020

Uh oh!

Dosant Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Dosant commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 29, 2020

Uh oh!

Dosant commented Jan 29, 2020

Uh oh!

Dosant commented Jan 30, 2020

Uh oh!

Uh oh!

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

Dosant commented Jan 30, 2020

Uh oh!

kibanamachine commented Jan 30, 2020

💚 Build Succeeded

History

Uh oh!

Dosant Jan 31, 2020

Choose a reason for hiding this comment

Uh oh!

lizozom Jan 31, 2020

Choose a reason for hiding this comment

Uh oh!

Dosant Jan 31, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Dosant commented Jan 29, 2020 •

edited

Loading