Move tsvb server to new platform#55310
Merged
flash1293 merged 16 commits intoelastic:masterfrom Jan 30, 2020
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Member
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
kertal
approved these changes
Jan 27, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM 👍 , tested locally in Chrome.
alexwizp
requested changes
Jan 27, 2020
Contributor
alexwizp
left a comment
There was a problem hiding this comment.
Tested locally, search by normal index works fine, but search by Rollup Index is broken =(
afgomez
suggested changes
Jan 29, 2020
Contributor
afgomez
left a comment
There was a problem hiding this comment.
Tested locally. The host page in the metrics app is not working anymore :(
Contributor
Author
|
@afgomez Sorry, pushed too early, forgot to pass a parameter through. Could you check again? |
afgomez
approved these changes
Jan 29, 2020
Contributor
There was a problem hiding this comment.
@flash1293 pulled the changes. It seems to work again 🎉
Contributor
Author
|
@alexwizp Could you check again? Rollups should work as well again. |
Contributor
Author
|
@alisonelizabeth I had to modify the rollup server side code in a few places, could you take a look? |
alisonelizabeth
approved these changes
Jan 29, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
Rollup code changes LGTM.
46 tasks
Contributor
💛 Build succeeded, but was flaky
History
To update your PR or re-run it, just comment with: |
alexwizp
approved these changes
Jan 30, 2020
Contributor
alexwizp
left a comment
There was a problem hiding this comment.
LGTM! Tested locally, Rollup search works fine
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jan 30, 2020
flash1293
added a commit
that referenced
this pull request
Jan 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 31, 2020
* master: (53 commits) Fix setting filters without $store value (elastic#56304) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935) [reporting] remove a legacy cross-plugin import (elastic#56354) [DOCS] Updates example in Timelion doc (elastic#56444) [APM] Service map center button (elastic#56434) [skip-ci] Add example for migrating pre-handlers (elastic#56080) [ML] Fix Data Visualizer responsive layout (elastic#56372) Add missing docker settings (elastic#56411) [Endpoint] Add Endpoint Details route (elastic#55746) chore(NA): delete data/optimize with kbn clean (elastic#55890) System index templates can't be edited (elastic#55229) Sync badge (elastic#55113) Only fire appState changes when there is a change (elastic#56183) Import appropriate files to setup plugin system at the correct time (elastic#55956) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) [ML] conditional rison encoding for query params (elastic#56380) Move tsvb server to new platform (elastic#55310) exclude tutorial resources from code ownership (elastic#55987) [Watcher] Follow up on flaky functional test (elastic#56384) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 31, 2020
…56356 * '7.x' of github.com:elastic/kibana: (23 commits) Fix setting filters without $store value (elastic#56304) (elastic#56475) [ML] Fix Data Visualizer responsive layout (elastic#56372) (elastic#56472) [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471) [APM] Fit service map to container (elastic#56336) (elastic#56463) Add animation to service map layout (elastic#56042) (elastic#56460) chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422) [APM] Storybook support (elastic#54970) (elastic#56445) [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454) [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320) [DOCS] Adds breaking changes for 7.6 (elastic#56437) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421) [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436) [7.x] System index templates can't be edited (elastic#55229) (elastic#56417) Add missing docker settings (elastic#56411) [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386) fix edit rule for detections (elastic#56333) (elastic#56405) [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385) [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757) Move tsvb server to new platform (elastic#55310) (elastic#56394) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the TSVB server to the new platform. Not all files are changed for this migration, instead a facade was used to emulate the behavior of the legacy
requestobject. In a separate PR this will be addressed by converting all files to typescript and passing down well formed context objects.