[ILM] Index Lifecycle Policies show wrong unit in Kibana UI#55228
Merged
cjcenizal merged 4 commits intoelastic:masterfrom Jan 23, 2020
Merged
[ILM] Index Lifecycle Policies show wrong unit in Kibana UI#55228cjcenizal merged 4 commits intoelastic:masterfrom
cjcenizal merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
requested changes
Jan 21, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
@jkelastic there are a couple comments that I originally left on #55211 that still need to be addressed. Once those issues are fixed, I think this will be in good shape!
...ins/index_lifecycle_management/public/sections/edit_policy/components/hot_phase/hot_phase.js
Outdated
Show resolved
Hide resolved
...ins/index_lifecycle_management/public/sections/edit_policy/components/hot_phase/hot_phase.js
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine merge upstream |
alisonelizabeth
approved these changes
Jan 22, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
great job @jkelastic! LGTM. Tested locally.
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
@jkelastic Since this is a bug fix, let's backport this to the 7.6 branch too. I'm going to add the 7.6.0 label, but if we can't make the release we'll just change it to 7.6.1. |
Contributor
Author
I will need help on backporting this. If someone can show me that would be awesome. |
Contributor
|
@jkelastic No problem! I'm going to merge this now and we can go through the backporting process together. |
jkelastic
added a commit
to jkelastic/kibana
that referenced
this pull request
Jan 23, 2020
…55228) * Added timing and byte size units to hot, cold, warm, and delete phase
jkelastic
added a commit
to jkelastic/kibana
that referenced
this pull request
Jan 23, 2020
…55228) * Added timing and byte size units to hot, cold, warm, and delete phase
alisonelizabeth
pushed a commit
that referenced
this pull request
Jan 30, 2020
alisonelizabeth
pushed a commit
that referenced
this pull request
Jan 30, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 31, 2020
…56356 * '7.x' of github.com:elastic/kibana: (23 commits) Fix setting filters without $store value (elastic#56304) (elastic#56475) [ML] Fix Data Visualizer responsive layout (elastic#56372) (elastic#56472) [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471) [APM] Fit service map to container (elastic#56336) (elastic#56463) Add animation to service map layout (elastic#56042) (elastic#56460) chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422) [APM] Storybook support (elastic#54970) (elastic#56445) [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454) [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320) [DOCS] Adds breaking changes for 7.6 (elastic#56437) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421) [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436) [7.x] System index templates can't be edited (elastic#55229) (elastic#56417) Add missing docker settings (elastic#56411) [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386) fix edit rule for detections (elastic#56333) (elastic#56405) [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385) [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757) Move tsvb server to new platform (elastic#55310) (elastic#56394) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes # 36682 Added time and byte size units
Release note
The Index Lifecycle Policies UI now supports all Elasticsearch time units and byte size units.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers