[Telemetry] Show opt-in changes for OSS users#50831
Merged
joelgriffith merged 28 commits intomasterfrom Nov 18, 2019
Merged
Conversation
…m/elastic/kibana into chore/oss-telemetry-banner-notice
joelgriffith
commented
Nov 15, 2019
| * under the License. | ||
| */ | ||
|
|
||
| /* eslint @elastic/eui/href-or-on-click:0 */ |
Contributor
Author
There was a problem hiding this comment.
This is a bit left-handed, but we need to call internals that they've seen this notice when they're navigating via anchor tags.
Member
There was a problem hiding this comment.
It's not clear which line this comment setting refers to. Can this be done with an eslint-disable-line ?
…m/elastic/kibana into chore/oss-telemetry-banner-notice
tsullivan
reviewed
Nov 15, 2019
|
|
||
| telemetryNotifyUserAboutOptInDefault = npStart.core.injectedMetadata.getInjectedVar( | ||
| 'telemetryNotifyUserAboutOptInDefault' | ||
| ) as boolean; |
Member
There was a problem hiding this comment.
I'm not so sure on this naming, usually boolean variables need an is/should prefix for clarity.
Maybe telemetryNotifyUserAboutOptInDefault ?
I think we want to keep the telemetry prefix because of the way the injectedVars are not namespaced by plugin
…m/elastic/kibana into chore/oss-telemetry-banner-notice
tsullivan
reviewed
Nov 16, 2019
| } as GetParams); | ||
|
|
||
| expect(telemetry.userHasSeenNotice).to.be(true); | ||
| }); |
Member
There was a problem hiding this comment.
The only thing I think the test code is missing is a clean-up step to remove the telemetry:telemetry document after the test did its update
Member
There was a problem hiding this comment.
Also, I didn't see an easy way to test that this API works with a non-privileged user.
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
pgayvallet
approved these changes
Nov 16, 2019
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM for platform changes
| interface Props { | ||
| urlBasePath: string; | ||
| onSkip: () => void; | ||
| optInSeen: () => any; |
Contributor
There was a problem hiding this comment.
NIT: naming. This is an event handler. optInSeen -> onOptInSeen (like onSkip here). Same goes for propagaging from home.js
Bamieh
reviewed
Nov 18, 2019
added 3 commits
November 18, 2019 07:11
…m/elastic/kibana into chore/oss-telemetry-banner-notice
Contributor
💚 Build Succeeded |
This was referenced Nov 18, 2019
joelgriffith
pushed a commit
that referenced
this pull request
Nov 18, 2019
* WIP: Notice banner for OSS folks * Add telemetryNotifyUserAboutOptInDefault to injected vars * add userHasSeenNotice check * More WIP on banner notice component * Text changes on screens * make userHasSeenNotice flag work * Finalzed splash text + checking new flag * Consolidating banner calls and saving status of opt-in notice * Conditionally remove the banner and add some code docs * Fixing prior welcome tests * api integration test for user has seen opt in * change post method to put in ui * unit test for get_telemetry_notify_user_about_optin_default * Ignore TS woes * Adding new tests and snapshots for opt-in banner component * Notice banner test * Translation miss * More opt-in tests * increase types usage * roll back core server api change * update snapshot * Prop name change + snapshot updates
joelgriffith
pushed a commit
that referenced
this pull request
Nov 18, 2019
* WIP: Notice banner for OSS folks * Add telemetryNotifyUserAboutOptInDefault to injected vars * add userHasSeenNotice check * More WIP on banner notice component * Text changes on screens * make userHasSeenNotice flag work * Finalzed splash text + checking new flag * Consolidating banner calls and saving status of opt-in notice * Conditionally remove the banner and add some code docs * Fixing prior welcome tests * api integration test for user has seen opt in * change post method to put in ui * unit test for get_telemetry_notify_user_about_optin_default * Ignore TS woes * Adding new tests and snapshots for opt-in banner component * Notice banner test * Translation miss * More opt-in tests * increase types usage * roll back core server api change * update snapshot * Prop name change + snapshot updates
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…-fallback * 'master' of github.com:elastic/kibana: (116 commits) [Maps] move apply global filter settting from layer to source (elastic#50523) [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (elastic#50843) [Maps] Delay vector tile layer syncing until spritesheet is loaded (elastic#48955) [Maps] prevent users from overflowing URL when filtering by shape (elastic#50747) [DOCS] Mark Beats central management as discontinued (elastic#49423) [page_objects/common_page] convert to ts (elastic#50771) [NP Kibana Migrations ] kibana plugin home (elastic#50444) [DOCS] Shareables naming convention (elastic#50497) [ML] DF Analytics - auto-populate model_memory_limit (elastic#50714) Increase alerting test stability and reduce flakiness (elastic#50246) [ML] Remaning new_job_new folder (elastic#50917) [Telemetry] Show opt-in changes for OSS users (elastic#50831) [ML] Fix lat_long anomalies table links menu and value formatting (elastic#50916) [Dev] Fix serialising a really big string (elastic#50915) Better explanation about the Prettier recommendation (extension vs. NPM module) (elastic#50629) [Monitoring] Use a basic monitoring user for tests (elastic#47865) [Monitoring] Gracefully handle issue with filebeat indices (elastic#48929) [Monitoring] Improve permissions required around setup mode (elastic#50421) Additional validation for elasticsearch username (elastic#48247) Revert changes to use_kibana_ui_setting (elastic#50877) ... # Conflicts: # src/legacy/core_plugins/console/server/request.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #50773.
This ensure that we always show telemetry changes in 7.5, and saves the fact that we've served notice in our index.
Still pending are a tests and some final tweaks, but functionality is there.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.