[Monitoring] Use a basic monitoring user for tests#47865
[Monitoring] Use a basic monitoring user for tests#47865chrisronline merged 7 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
💔 Build Failed
|
|
I am going to kick off a new CI build once elastic/elasticsearch#47871 has made it's way into a snapshot - it should resolve the failures |
|
Waiting on this #47217 before we can resume the work in this PR |
💔 Build Failed
|
|
@elasticmachine merge upstream |
💔 Build Failed
|
💔 Build Failed
|
079621e to
2e6abe3
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
| async navigateTo() { | ||
| async navigateTo(useSuperUser = false) { | ||
| // always create this because our tear down tries to delete it | ||
| await security.user.create('basic_monitoring_user', { |
There was a problem hiding this comment.
Shouldn't this maybe be inside this: https://github.com/elastic/kibana/pull/47865/files#diff-b5773aa68cf0bba75970470c4b391bdeR21 if condition?
There was a problem hiding this comment.
I added the comment:
// always create this because our tear down tries to delete it
Because we are always trying to remove it here: https://github.com/elastic/kibana/pull/47865/files#diff-328ca8d955b871223f4463b5a7ce9721R39
I guess I could try/catch that call and do nothing if it fails? I'm not sure the best way here, but at least this way gets the tests to pass (which was a challenge honestly)
There was a problem hiding this comment.
Ah, I see now, this makes sense
igoristic
left a comment
There was a problem hiding this comment.
Great job! 🥇 This will be a great addition to our affirmation ✅
|
@elasticmachine merge upstream |
💚 Build Succeeded |
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
…-fallback * 'master' of github.com:elastic/kibana: (116 commits) [Maps] move apply global filter settting from layer to source (elastic#50523) [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (elastic#50843) [Maps] Delay vector tile layer syncing until spritesheet is loaded (elastic#48955) [Maps] prevent users from overflowing URL when filtering by shape (elastic#50747) [DOCS] Mark Beats central management as discontinued (elastic#49423) [page_objects/common_page] convert to ts (elastic#50771) [NP Kibana Migrations ] kibana plugin home (elastic#50444) [DOCS] Shareables naming convention (elastic#50497) [ML] DF Analytics - auto-populate model_memory_limit (elastic#50714) Increase alerting test stability and reduce flakiness (elastic#50246) [ML] Remaning new_job_new folder (elastic#50917) [Telemetry] Show opt-in changes for OSS users (elastic#50831) [ML] Fix lat_long anomalies table links menu and value formatting (elastic#50916) [Dev] Fix serialising a really big string (elastic#50915) Better explanation about the Prettier recommendation (extension vs. NPM module) (elastic#50629) [Monitoring] Use a basic monitoring user for tests (elastic#47865) [Monitoring] Gracefully handle issue with filebeat indices (elastic#48929) [Monitoring] Improve permissions required around setup mode (elastic#50421) Additional validation for elasticsearch username (elastic#48247) Revert changes to use_kibana_ui_setting (elastic#50877) ... # Conflicts: # src/legacy/core_plugins/console/server/request.test.ts
Relates to #29661