[Maps] Delay vector tile layer syncing until spritesheet is loaded#48955
Merged
thomasneirynck merged 5 commits intoelastic:masterfrom Nov 18, 2019
Merged
[Maps] Delay vector tile layer syncing until spritesheet is loaded#48955thomasneirynck merged 5 commits intoelastic:masterfrom
thomasneirynck merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
💚 Build Succeeded |
nickpeihl
approved these changes
Oct 23, 2019
Contributor
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm!
Water waves appear in both Chrome and Firefox with this PR. Prior to this, the waves would not appear in Chrome for me. Code changes look good.
| } | ||
| } | ||
|
|
||
| export async function addSpritesheetToMap(json, imgUrl, mbMap) { |
Contributor
There was a problem hiding this comment.
nit, maybe we should standardize the capitalization of SpriteSheet in our function names?
Suggested change
| export async function addSpritesheetToMap(json, imgUrl, mbMap) { | |
| export async function addSpriteSheetToMap(json, imgUrl, mbMap) { |
nreese
reviewed
Oct 23, 2019
Contributor
nreese
left a comment
There was a problem hiding this comment.
I like the improvement of moving the loading into syncData but I am not sure this fixes the problem. While running this branch, the waves still failed to load.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@nreese bummer that this doesn't seem to fix that race-condition in all cases. Would still like to go forward with this PR, as this is already an improvement and fixes a known issue. |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Nov 18, 2019
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Nov 18, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…-fallback * 'master' of github.com:elastic/kibana: (116 commits) [Maps] move apply global filter settting from layer to source (elastic#50523) [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (elastic#50843) [Maps] Delay vector tile layer syncing until spritesheet is loaded (elastic#48955) [Maps] prevent users from overflowing URL when filtering by shape (elastic#50747) [DOCS] Mark Beats central management as discontinued (elastic#49423) [page_objects/common_page] convert to ts (elastic#50771) [NP Kibana Migrations ] kibana plugin home (elastic#50444) [DOCS] Shareables naming convention (elastic#50497) [ML] DF Analytics - auto-populate model_memory_limit (elastic#50714) Increase alerting test stability and reduce flakiness (elastic#50246) [ML] Remaning new_job_new folder (elastic#50917) [Telemetry] Show opt-in changes for OSS users (elastic#50831) [ML] Fix lat_long anomalies table links menu and value formatting (elastic#50916) [Dev] Fix serialising a really big string (elastic#50915) Better explanation about the Prettier recommendation (extension vs. NPM module) (elastic#50629) [Monitoring] Use a basic monitoring user for tests (elastic#47865) [Monitoring] Gracefully handle issue with filebeat indices (elastic#48929) [Monitoring] Improve permissions required around setup mode (elastic#50421) Additional validation for elasticsearch username (elastic#48247) Revert changes to use_kibana_ui_setting (elastic#50877) ... # Conflicts: # src/legacy/core_plugins/console/server/request.test.ts
thomasneirynck
added a commit
that referenced
this pull request
Nov 18, 2019
thomasneirynck
added a commit
that referenced
this pull request
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delay bootstrapping of the layer until the spritesheet imagedata is loaded.
This should close a race condition, and likely (?) address #48933