[Infra UI] Use sum for aggregating AWS metrics.#43293
Merged
skh merged 5 commits intoelastic:masterfrom Aug 16, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/infra-logs-ui |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
simianhacker
requested changes
Aug 15, 2019
Member
simianhacker
left a comment
There was a problem hiding this comment.
Per our discussion here are the changes to the models: simianhacker@9108e44
I tried to push it to your branch but for some reason I don't have permissions to do so.
Contributor
💚 Build Succeeded |
Contributor
Author
|
@simianhacker ready for another look. |
simianhacker
requested changes
Aug 16, 2019
Member
There was a problem hiding this comment.
Looks like there is a typo in the network ID as noted below. I also forgot to put a positive_only after the derivative metric. Here is an example of what that looks like:
{
id: 'posonly-deriv-csum-sum-net-out',
field: 'deriv-csum-sum-net-out',
type: InfraMetricNodeMetricType.positive_only,
}
We need to put one of those after each derivative. I'm sorry I missed that but it occurred to me while I was debugging the missing data for the network in.
x-pack/legacy/plugins/infra/server/lib/adapters/metrics/models/aws/aws_network_bytes.ts
Outdated
Show resolved
Hide resolved
simianhacker
approved these changes
Aug 16, 2019
Member
simianhacker
left a comment
There was a problem hiding this comment.
Looks good!
__ ______ ______ __ __
/\ \ /\ ___\ /\__ _\ /\ "-./ \
\ \ \____ \ \ \__ \ \/_/\ \/ \ \ \-./\ \
\ \_____\ \ \_____\ \ \_\ \ \_\ \ \_\
\/_____/ \/_____/ \/_/ \/_/ \/_/
Contributor
💚 Build Succeeded |
skh
added a commit
to skh/kibana
that referenced
this pull request
Aug 16, 2019
* Use sum for aggregations. * Use cumulative sum/derivative instead of hard coded rate * Fix typo. * Add positive_only after derivatives.
skh
added a commit
that referenced
this pull request
Aug 16, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 19, 2019
…_update_json_spec * 'master' of github.com:elastic/kibana: (35 commits) fix: 🐛 pass whole action context to isCompatible() method (elastic#43457) Deleted old kbn-top-nav directive (elastic#43168) [ML] Fixing cloning of single metric distinct count job (elastic#43435) Update @elastic/charts version 8.1.6 > 9.1.1 (elastic#43516) [Inspector Views] [Request View] - Migrate inspector_views to new platform (elastic#43191) [ML] Adding loading indicators to all wizard charts (elastic#43382) disable flaky test (elastic#43492) feature(code/frontend): cancel file blob and directory commits request if outdated (elastic#43348) fix(code/frontend): button group url should have previous query string (elastic#43428) [SIEM] Fixes index substring incorrectly matching configured indices and failing to install ML job (elastic#43409) [SIEM] Adds performance enhancements such by removing wasted renderers and adding incremental DOM rendering (elastic#43157) disable flaky test (elastic#37859) Added sass lint to Canvas (elastic#43410) [Maps] add indicator when layer is filtered by search bar (elastic#43283) Properly validate current user password during password change. (elastic#43447) Spaces - allow for hex color codes that include uppercase characters (elastic#43470) [Reporting] Add a bit more logging and a few more logging level promotions (elastic#43415) Partially convert index pattern server to typescript (elastic#43291) [Infra UI] Use sum for aggregating AWS metrics. (elastic#43293) [SIEM] Format bytes columns in timeline (elastic#43147) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements changes to the processing of AWS metrics as discussed in #42687 (comment)
This can be tested against the Observability 8.x.x cluster, which has metrics for one AWS instance.