Partially convert index pattern server to typescript#43291
Merged
wylieconlon merged 3 commits intoelastic:masterfrom Aug 16, 2019
Merged
Partially convert index pattern server to typescript#43291wylieconlon merged 3 commits intoelastic:masterfrom
wylieconlon merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch |
wylieconlon
commented
Aug 14, 2019
| test('test', () => { | ||
| // errors module is tested in test/api_integration/apis/index_patterns/es_errors/errors.js | ||
| // so it can get real errors from elasticsearch and the es client to test with | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
I removed this test file because it was empty
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
Aug 16, 2019
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this. I'll look at some of the other pieces you had questions on from the draft PR and see if I can sort those out.
src/legacy/server/index_patterns/service/lib/field_capabilities/field_caps_response.ts
Outdated
Show resolved
Hide resolved
src/legacy/server/index_patterns/service/lib/field_capabilities/field_caps_response.ts
Show resolved
Hide resolved
…s/field_caps_response.ts Co-Authored-By: Luke Elmers <lukeelmers@gmail.com>
…pattern-typescript
Contributor
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 19, 2019
…_update_json_spec * 'master' of github.com:elastic/kibana: (35 commits) fix: 🐛 pass whole action context to isCompatible() method (elastic#43457) Deleted old kbn-top-nav directive (elastic#43168) [ML] Fixing cloning of single metric distinct count job (elastic#43435) Update @elastic/charts version 8.1.6 > 9.1.1 (elastic#43516) [Inspector Views] [Request View] - Migrate inspector_views to new platform (elastic#43191) [ML] Adding loading indicators to all wizard charts (elastic#43382) disable flaky test (elastic#43492) feature(code/frontend): cancel file blob and directory commits request if outdated (elastic#43348) fix(code/frontend): button group url should have previous query string (elastic#43428) [SIEM] Fixes index substring incorrectly matching configured indices and failing to install ML job (elastic#43409) [SIEM] Adds performance enhancements such by removing wasted renderers and adding incremental DOM rendering (elastic#43157) disable flaky test (elastic#37859) Added sass lint to Canvas (elastic#43410) [Maps] add indicator when layer is filtered by search bar (elastic#43283) Properly validate current user password during password change. (elastic#43447) Spaces - allow for hex color codes that include uppercase characters (elastic#43470) [Reporting] Add a bit more logging and a few more logging level promotions (elastic#43415) Partially convert index pattern server to typescript (elastic#43291) [Infra UI] Use sum for aggregating AWS metrics. (elastic#43293) [SIEM] Format bytes columns in timeline (elastic#43147) ...
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Sep 11, 2019
* Partially convert index pattern server to typescript * Update src/legacy/server/index_patterns/service/lib/field_capabilities/field_caps_response.ts Co-Authored-By: Luke Elmers <lukeelmers@gmail.com>
wylieconlon
pushed a commit
that referenced
this pull request
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I don't have the knowledge to fully migrate the index pattern server side to Typescript, which I began in another PR: #43155
The two biggest parts of the code that I was unable to migrate, but might be possible with more knowledge, are:
Instead, I've partially converted the server side to typescript enough to import the IndexPatternService into other typescript code.