[Inspector Views] [Request View] - Migrate inspector_views to new platform#43191
Merged
alexwizp merged 8 commits intoelastic:masterfrom Aug 19, 2019
Merged
[Inspector Views] [Request View] - Migrate inspector_views to new platform#43191alexwizp merged 8 commits intoelastic:masterfrom
alexwizp merged 8 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
Contributor
|
Pinging @elastic/kibana-app-arch |
Contributor
💚 Build Succeeded |
ryankeairns
approved these changes
Aug 14, 2019
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM from the design side. The CSS changes do not affect actual styles, just some file renaming and import changes.
cchaos
suggested changes
Aug 14, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
@alexwizp The only problem is that you renamed _requests.scss to index.scss. There's two problems with this.
- Imported (not directly compiled) file names should always lead with an underscore.
- We never put styles directly in
indexfiles. These should strictly be import manifests.
Solution
- Revert the rename of
_requests.scss. - Add back in an
_index.scssfile next to the requests that imports it@import './requests - Rename this index.scss file to
_index.scsssince it's being imported from the original location and is not a directly compiled file.
Contributor
Author
|
@cchaos thanks, fixed |
cchaos
approved these changes
Aug 14, 2019
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
lukeelmers
approved these changes
Aug 16, 2019
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Thanks @alexwizp! Code LGTM, added a few minor notes, but no major concerns on my end.
Before merging, I'd like to get an approval from either @streamich or @timroes as well, since they are more familiar with this code than I am.
src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx
Show resolved
Hide resolved
src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx
Show resolved
Hide resolved
src/plugins/inspector/public/views/requests/components/requests_view.tsx
Show resolved
Hide resolved
src/plugins/inspector/public/views/requests/components/details/req_details_request.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
streamich
approved these changes
Aug 19, 2019
Contributor
streamich
left a comment
There was a problem hiding this comment.
Code LGTM, but I only see Request view being moved there should be also Data view.
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Aug 19, 2019
…tform (elastic#43191) * [Inspector Views] [Request View] - Migrate inspector_views to new platform * fix i18n keys * rename scss files * fix PR comments
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 19, 2019
…_update_json_spec * 'master' of github.com:elastic/kibana: (35 commits) fix: 🐛 pass whole action context to isCompatible() method (elastic#43457) Deleted old kbn-top-nav directive (elastic#43168) [ML] Fixing cloning of single metric distinct count job (elastic#43435) Update @elastic/charts version 8.1.6 > 9.1.1 (elastic#43516) [Inspector Views] [Request View] - Migrate inspector_views to new platform (elastic#43191) [ML] Adding loading indicators to all wizard charts (elastic#43382) disable flaky test (elastic#43492) feature(code/frontend): cancel file blob and directory commits request if outdated (elastic#43348) fix(code/frontend): button group url should have previous query string (elastic#43428) [SIEM] Fixes index substring incorrectly matching configured indices and failing to install ML job (elastic#43409) [SIEM] Adds performance enhancements such by removing wasted renderers and adding incremental DOM rendering (elastic#43157) disable flaky test (elastic#37859) Added sass lint to Canvas (elastic#43410) [Maps] add indicator when layer is filtered by search bar (elastic#43283) Properly validate current user password during password change. (elastic#43447) Spaces - allow for hex color codes that include uppercase characters (elastic#43470) [Reporting] Add a bit more logging and a few more logging level promotions (elastic#43415) Partially convert index pattern server to typescript (elastic#43291) [Infra UI] Use sum for aggregating AWS metrics. (elastic#43293) [SIEM] Format bytes columns in timeline (elastic#43147) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fix: #42636
Description:
There is still an inspector_views plugin in src/legacy/core_plugins/inspector_views which should be colocated with the inspector plugin to complete the migration.
Done for Request View
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers