[dasboards as code] drop panels with server errors#260073
Merged
nreese merged 7 commits intoelastic:mainfrom Mar 31, 2026
Merged
[dasboards as code] drop panels with server errors#260073nreese merged 7 commits intoelastic:mainfrom
nreese merged 7 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
ThomThomson
approved these changes
Mar 30, 2026
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Changes LGTM! Looked through all the code and the changes make sense.
| } | ||
| }); | ||
| if (droppedPanelsCount) { | ||
| coreServices.notifications.toasts.addWarning( |
Contributor
There was a problem hiding this comment.
Nice. Much simpler to fire off a warning than it is to try to put a fake panel in its place.
| enhancements: {}, | ||
| title: 'title1', | ||
| expect(transformDashboardOut(input, references)).toMatchInlineSnapshot(` | ||
| Object { |
Contributor
There was a problem hiding this comment.
I know this is an inline snapshot, but the diff is pretty difficult to read here when theoretically the only thing that should change is the addition of the warnings array.
| `); | ||
| }); | ||
|
|
||
| it('should drop panel when panel transform throws', () => { |
| "warnings": Array [ | ||
| "Dropped panel 12345, panel schema not available for panel type: typeWithoutSchema. Panels without schemas are not supported by dashboard REST endpoints", | ||
| Object { | ||
| "message": "Panel schema not available for panel type: typeWithoutSchema. Panels without schemas are not supported by dashboard REST endpoints", |
Contributor
There was a problem hiding this comment.
This is much better as an object! Very nice
| panel_references: schema.maybe(schema.arrayOf(referenceSchema)), | ||
| }); | ||
|
|
||
| export const warningsSchema = schema.arrayOf(droppedPanelWarningSchema); |
Contributor
There was a problem hiding this comment.
Nice little extension point left in here
mbondyra
approved these changes
Mar 31, 2026
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 31, 2026
…hanges * commit 'd0e62a657916e84694a93983e513ce9e34e0b635': (27 commits) [Agent Builder] Agent overview page design updates (elastic#260468) [Inference UI] Add model detail flyout with endpoint management (elastic#260307) [Fleet] Update doc links in agent policy settings (elastic#260245) [Security Solution] show risk score in new flyout header (elastic#260187) Replace deprecated EUI icons in files owned by @elastic/kibana-security (elastic#255636) [Cases][Templates] Add DATE_PICKER field control type (elastic#260209) [SharedUX] Get spaces callout on each solution nav (elastic#259723) [SharedUX] Preserve feature visibility on solution change (elastic#259316) [CI] Increase investigations cypress disks to 110G (elastic#260423) [Agent Builder] Expose read-only conversations on plugin start contract (elastic#260435) [dasboards as code] drop panels with server errors (elastic#260073) [One Workflow] Add force-delete (hard delete) option for workflows (elastic#260391) [Agent Builder] Fix sidebar error handling error (elastic#260446) [Agent Builder] Add attachment origin to Converse API (elastic#259043) [Alerting v2] Fix rule results preview chart responsiveness (elastic#260444) [Streams] Processing error panel UI improvements (elastic#260028) fix flaky test: alert details error page timeout (elastic#260302) [Agent Builder] Add attachment origin to Converse API (elastic#259043) [One Workflow] Add more unit tests to workflows_extensions plugin (elastic#260384) [ResponseOps] Split alerting security_and_spaces group8 FTR config to fix CI timeout (elastic#260029) ...
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
Closes elastic#259793 PR removes panels from dashboard out state when panel transform throws. Dropped panels are returned in `warnings` key. Client displays toast when loading dashboard with dropped panels.
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
Closes elastic#259793 PR removes panels from dashboard out state when panel transform throws. Dropped panels are returned in `warnings` key. Client displays toast when loading dashboard with dropped panels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259793
PR removes panels from dashboard out state when panel transform throws. Dropped panels are returned in
warningskey. Client displays toast when loading dashboard with dropped panels.