Skip to content

[Streams] Processing error panel UI improvements#260028

Merged
damian-polewski merged 3 commits intoelastic:mainfrom
damian-polewski:streams/processing_error_panel_improvements
Mar 31, 2026
Merged

[Streams] Processing error panel UI improvements#260028
damian-polewski merged 3 commits intoelastic:mainfrom
damian-polewski:streams/processing_error_panel_improvements

Conversation

@damian-polewski
Copy link
Copy Markdown
Contributor

@damian-polewski damian-polewski commented Mar 27, 2026

Closes https://github.com/elastic/streams-program/issues/679

Summary

This PR:

  • Refactors the enrichment error UI into a single bordered accordion panel with a danger warning header + total issue count.
Before After
Screenshot 2026-03-27 at 15 54 22 Screenshot 2026-03-27 at 15 54 57
Screenshot 2026-03-27 at 15 55 19
Screenshot 2026-03-27 at 15 55 25

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@damian-polewski damian-polewski self-assigned this Mar 27, 2026
@damian-polewski damian-polewski requested a review from a team as a code owner March 27, 2026 15:09
@damian-polewski damian-polewski added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project labels Mar 27, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 27, 2026

Pinging @elastic/kibana-management (Team:Kibana Management)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a750afbf-7ed6-464a-aa6b-60c18af87ca3

📥 Commits

Reviewing files that changed from the base of the PR and between 00275d7 and 7e062e4.

📒 Files selected for processing (1)
  • x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_enrichment/steps/steps_editor.tsx
📝 Walkthrough

Walkthrough

The StepsEditor component was updated to use a new ErrorPanel component replacing the previous ErrorPanels API. The changes include removing the showBottomBar prop and hasChanges selector usage. The error panel UI was restructured from multiple nested panels to a single bordered panel with one accordion (id="error-panel-accordion"). Validation errors are now rendered as a vertical list of EuiCallOut items, while definition errors are converted to EuiCallOut components. Accordion headers were redesigned with EuiTitle and EuiTextColor styling, and typography sizes were adjusted throughout.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

Comment @coderabbitai help to get the list of available commands and usage tips.

flash1293
flash1293 reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, left one comment.

Also, I'm not sure about nested collapsibles here - @patpascal wdyt?

Image

flash1293
flash1293 approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test again

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 31, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / DistributionBar filters by failed findings when clicking on the failed findings button
  • [job] [logs] FTR Configs #193 / Alerting eventLog in space default should generate expected events for flapping alerts that settle on active where notifyWhen is NOT set to "on status change"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 1.9MB 1.9MB +277.0B

History

cc @damian-polewski

@damian-polewski damian-polewski merged commit 46a915b into elastic:main Mar 31, 2026
18 checks passed
@damian-polewski damian-polewski deleted the streams/processing_error_panel_improvements branch March 31, 2026 12:17
mbondyra added a commit to mbondyra/kibana that referenced this pull request Mar 31, 2026
@mbondyra
Merge commit 'd0e62a657916e84694a93983e513ce9e34e0b635' into manual_c…
c402174 
…hanges

* commit 'd0e62a657916e84694a93983e513ce9e34e0b635': (27 commits)
  [Agent Builder] Agent overview page design updates (elastic#260468)
  [Inference UI] Add model detail flyout with endpoint management (elastic#260307)
  [Fleet] Update doc links in agent policy settings (elastic#260245)
  [Security Solution] show risk score in new flyout header (elastic#260187)
  Replace deprecated EUI icons in files owned by @elastic/kibana-security (elastic#255636)
  [Cases][Templates] Add DATE_PICKER field control type (elastic#260209)
  [SharedUX] Get spaces callout on each solution nav (elastic#259723)
  [SharedUX] Preserve feature visibility on solution change (elastic#259316)
  [CI] Increase investigations cypress disks to 110G (elastic#260423)
  [Agent Builder] Expose read-only conversations on plugin start contract (elastic#260435)
  [dasboards as code] drop panels with server errors (elastic#260073)
  [One Workflow] Add force-delete (hard delete) option for workflows (elastic#260391)
  [Agent Builder] Fix sidebar error handling error (elastic#260446)
  [Agent Builder] Add attachment origin to Converse API (elastic#259043)
  [Alerting v2] Fix rule results preview chart responsiveness (elastic#260444)
  [Streams] Processing error panel UI improvements (elastic#260028)
  fix flaky test: alert details error page timeout (elastic#260302)
  [Agent Builder] Add attachment origin to Converse API (elastic#259043)
  [One Workflow] Add more unit tests to workflows_extensions plugin (elastic#260384)
  [ResponseOps] Split alerting security_and_spaces group8 FTR config to fix CI timeout (elastic#260029)
  ...
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Apr 1, 2026
@damian-polewski @jeramysoucy
[Streams] Processing error panel UI improvements (elastic#260028)
9420252 
Closes elastic/streams-program#679

## Summary

This PR:

- Refactors the enrichment error UI into a single bordered accordion
panel with a danger warning header + total issue count.
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
@damian-polewski @paulinashakirova
[Streams] Processing error panel UI improvements (elastic#260028)
8efb64e 
Closes elastic/streams-program#679

## Summary

This PR:

- Refactors the enrichment error UI into a single bordered accordion
panel with a danger warning header + total issue count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@damian-polewski damian-polewski

Labels

backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damian-polewski @elasticmachine @flash1293 @kibanamachine