Skip to content

[Entity Store] Change hash algo to sha256#259453

Merged
uri-weisman merged 6 commits intoelastic:mainfrom
uri-weisman:change_hash_algo
Mar 26, 2026
Merged

[Entity Store] Change hash algo to sha256#259453
uri-weisman merged 6 commits intoelastic:mainfrom
uri-weisman:change_hash_algo

Conversation

@uri-weisman
Copy link
Copy Markdown
Contributor

@uri-weisman uri-weisman commented Mar 24, 2026

Summary

Related:

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@uri-weisman uri-weisman requested a review from a team as a code owner March 24, 2026 19:12
@uri-weisman uri-weisman added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 24, 2026
@uri-weisman uri-weisman changed the title Change hash algo [Entity Store] Change hash algo to sha256 Mar 25, 2026
@uri-weisman uri-weisman linked an issue Mar 25, 2026 that may be closed by this pull request
[Entity Store] Change hash alg from MD5 to sha256 #256580
Closed
@chennn1990 chennn1990 self-requested a review March 26, 2026 10:25
chennn1990
chennn1990 approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@chennn1990 chennn1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think that snapshot tests should be modified as well:
x-pack/solutions/security/plugins/entity_store/server/domain/logs_extraction/__snapshots__

@uri-weisman uri-weisman enabled auto-merge (squash) March 26, 2026 16:25
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 26, 2026

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Logs Extraction with pagination (max 5 docs per page) - Should extract properly extract host with pagination
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Logs Extraction with pagination (max 5 docs per page) - Should extract properly extract host with pagination
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract generic
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract generic
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract host
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract host
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract service
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract service
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract user
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-serverless-security_complete - Entity Store Main logs extraction - Should extract properly extract user
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Logs Extraction with pagination (max 5 docs per page) - Should extract properly extract host with pagination
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Logs Extraction with pagination (max 5 docs per page) - Should extract properly extract host with pagination
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract generic
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract generic
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract host
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract host
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract service
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract service
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract user
  • [job] [logs] affected Scout: [ security / entity_store ] plugin / local-stateful-classic - Entity Store Main logs extraction - Should extract properly extract user

History

@uri-weisman uri-weisman merged commit ead813e into elastic:main Mar 26, 2026
18 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Mar 26, 2026
@mbondyra
Merge commit '22bf09c82658b9511cbb2ad13f6dd29ad3526472' into manual_c…
aaf7091 
…hanges

* commit '22bf09c82658b9511cbb2ad13f6dd29ad3526472': (21 commits)
  [Overlays System Flyout]: Support Child History (elastic#256339)
  KUA-Update event naming format and examples (elastic#259846)
  Fix pagerduty connector codeownership (elastic#259807)
  [Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests (elastic#258981)
  [Upgrade Assistant] Migrate ES deprecations flaky integration tests to unit tests (elastic#258142)
  [Index Management] Migrate flaky integration tests to unit tests (elastic#258942)
  [Cases] Rename attachment id to saved object id (elastic#259158)
  [Entity Store] Change hash algo to sha256 (elastic#259453)
  [Security Solution] fixed enhanced security profile header showing for non-alert documents (elastic#259801)
  Update LaunchDarkly (main) (elastic#259008)
  [Discover] Add observability default ES|QL query (elastic#257268)
  Update dependency @redocly/cli to v2.21.1 (main) (elastic#259016)
  Gap reason detected (elastic#258231)
  [One Workflow] Historical executionContext and telemetry (elastic#258623)
  coderabbit: drop SigEvents (elastic#259863)
  [ci] Bump cypress disk (elastic#259861)
  Server timings (elastic#258915)
  Replace deprecated EUI icons in files owned by @elastic/kibana-cases (elastic#255633)
  [ci] Bump storybooks disk (elastic#259858)
  [drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger (elastic#259637)
  ...
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Apr 1, 2026
@uri-weisman @jeramysoucy
[Entity Store] Change hash algo to sha256 (elastic#259453)
94f2efa
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
@uri-weisman @paulinashakirova
[Entity Store] Change hash algo to sha256 (elastic#259453)
278a63d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chennn1990 chennn1990 chennn1990 approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Entity Store] Change hash alg from MD5 to sha256

4 participants

@uri-weisman @elasticmachine @chennn1990 @kibanamachine