[Overlays System Flyout]: Support Child History#256339
Merged
tsullivan merged 2 commits intoelastic:mainfrom Mar 26, 2026
Merged
[Overlays System Flyout]: Support Child History#256339tsullivan merged 2 commits intoelastic:mainfrom
tsullivan merged 2 commits intoelastic:mainfrom
Conversation
53cf67c to
09ba02b
Compare
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (6)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
50c06b4 to
f87fc7d
Compare
3 tasks
f87fc7d to
897d290
Compare
103cd35 to
b100ebf
Compare
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Page load bundle
History
|
10 tasks
b100ebf to
c6aab75
Compare
3 tasks
commit 16413df Author: Timothy Sullivan <tsullivan@elastic.co> Date: Fri Mar 20 08:55:19 2026 -0700 Fix Back button bug with openSystemFlyout
c6aab75 to
283d05c
Compare
tsullivan
commented
Mar 25, 2026
|
|
||
| const handleOpenChildFlyoutA = () => { | ||
| setIsChildFlyoutAOpen(true); | ||
| setIsChildFlyoutBOpen(false); |
Member
Author
There was a problem hiding this comment.
This cleans up cascade close logic that is now handled by the EUI Flyout System internally
kowalczyk-krzysztof
approved these changes
Mar 25, 2026
afharo
approved these changes
Mar 26, 2026
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 26, 2026
…hanges * commit '22bf09c82658b9511cbb2ad13f6dd29ad3526472': (21 commits) [Overlays System Flyout]: Support Child History (elastic#256339) KUA-Update event naming format and examples (elastic#259846) Fix pagerduty connector codeownership (elastic#259807) [Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests (elastic#258981) [Upgrade Assistant] Migrate ES deprecations flaky integration tests to unit tests (elastic#258142) [Index Management] Migrate flaky integration tests to unit tests (elastic#258942) [Cases] Rename attachment id to saved object id (elastic#259158) [Entity Store] Change hash algo to sha256 (elastic#259453) [Security Solution] fixed enhanced security profile header showing for non-alert documents (elastic#259801) Update LaunchDarkly (main) (elastic#259008) [Discover] Add observability default ES|QL query (elastic#257268) Update dependency @redocly/cli to v2.21.1 (main) (elastic#259016) Gap reason detected (elastic#258231) [One Workflow] Historical executionContext and telemetry (elastic#258623) coderabbit: drop SigEvents (elastic#259863) [ci] Bump cypress disk (elastic#259861) Server timings (elastic#258915) Replace deprecated EUI icons in files owned by @elastic/kibana-cases (elastic#255633) [ci] Bump storybooks disk (elastic#259858) [drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger (elastic#259637) ...
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
## Summary Closes elastic/kibana-team#2725 **Pertains to the System Flyout Service: `core.overlays.openSystemFlyout`** These changes to the service ensure that when EUI supports child history, that closing a main flyout will cascade-close all correlated child flyouts. Currently, closing a main flyout with one or more children will result in only the most recent child to be closed. **Before** Note: Apply 09ba02b to remove a workaround of the bug: the example app incorrectly had its own handling for cascade-closing multiple flyouts. https://github.com/user-attachments/assets/7d5458b6-e4b2-4abf-b7cf-0a16a6657fc1 **After** https://github.com/user-attachments/assets/f94da089-d755-41f7-a516-f45012b13aaf ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
## Summary Closes elastic/kibana-team#2725 **Pertains to the System Flyout Service: `core.overlays.openSystemFlyout`** These changes to the service ensure that when EUI supports child history, that closing a main flyout will cascade-close all correlated child flyouts. Currently, closing a main flyout with one or more children will result in only the most recent child to be closed. **Before** Note: Apply 09ba02b to remove a workaround of the bug: the example app incorrectly had its own handling for cascade-closing multiple flyouts. https://github.com/user-attachments/assets/7d5458b6-e4b2-4abf-b7cf-0a16a6657fc1 **After** https://github.com/user-attachments/assets/f94da089-d755-41f7-a516-f45012b13aaf ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~ - ~~[ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - ~~[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - ~~[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - ~~[ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed~~ - ~~[ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)~~ - ~~[ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.~~ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/kibana-team/issues/2725
Pertains to the System Flyout Service:
core.overlays.openSystemFlyoutThese changes to the service ensure that when EUI supports child history, that closing a main flyout will cascade-close all correlated child flyouts. Currently, closing a main flyout with one or more children will result in only the most recent child to be closed.
Before
Note: Apply 09ba02b to remove a workaround of the bug: the example app incorrectly had its own handling for cascade-closing multiple flyouts.
multi-child-cascade-close-before.mov
After
multi-child-cascade-close-after.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list[ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.[ ] Flaky Test Runner was used on any tests changed[ ] The PR description includes the appropriate Release Notes section, and the correctrelease_note:*label is applied per the guidelines[ ] Review the backport guidelines and apply applicablebackport:*labels.