[Discover] Add observability default ES|QL query#257268
Merged
cauemarcondes merged 14 commits intoelastic:mainfrom Mar 26, 2026
Merged
[Discover] Add observability default ES|QL query#257268cauemarcondes merged 14 commits intoelastic:mainfrom
cauemarcondes merged 14 commits intoelastic:mainfrom
Conversation
Member
Author
|
/oblt-deploy |
Contributor
|
Pinging @elastic/obs-exploration-team (Team:obs-exploration) |
akowalska622
approved these changes
Mar 16, 2026
Member
Author
|
I'm not convinced these failures are caused by the changes in this PR 🤔 |
…fault ES|QL query change The observability root profile now implements `getDefaultEsqlQuery`, returning `FROM logs-*` as the initial ES|QL query when switching to text-based mode. Before this change, the default resolved to `default-data-source-profile` first (as an intermediate step), then transitioned to `observability-logs-data-source-profile` when submitting a logs-based query. After the change, switching to ES|QL mode already resolves directly to `observability-logs-data-source-profile` (via `FROM logs-*`). When the user then submits `from my-example-logs`, both queries resolve to the same profile, so the EBT deduplication logic in `ScopedDiscoverEBTManager` suppresses the duplicate event. This reduces the expected `discover_profile_resolved` event count in the "different document profile" test from 3 → 2 (before opening the doc viewer) and from 4 → 3 (after opening it). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tenwort/kibana into add-observability-default-esql-query
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
cc @weltenwort |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 26, 2026
…hanges * commit '22bf09c82658b9511cbb2ad13f6dd29ad3526472': (21 commits) [Overlays System Flyout]: Support Child History (elastic#256339) KUA-Update event naming format and examples (elastic#259846) Fix pagerduty connector codeownership (elastic#259807) [Upgrade Assistant] Migrate Kibana deprecations flaky integration tests to unit tests (elastic#258981) [Upgrade Assistant] Migrate ES deprecations flaky integration tests to unit tests (elastic#258142) [Index Management] Migrate flaky integration tests to unit tests (elastic#258942) [Cases] Rename attachment id to saved object id (elastic#259158) [Entity Store] Change hash algo to sha256 (elastic#259453) [Security Solution] fixed enhanced security profile header showing for non-alert documents (elastic#259801) Update LaunchDarkly (main) (elastic#259008) [Discover] Add observability default ES|QL query (elastic#257268) Update dependency @redocly/cli to v2.21.1 (main) (elastic#259016) Gap reason detected (elastic#258231) [One Workflow] Historical executionContext and telemetry (elastic#258623) coderabbit: drop SigEvents (elastic#259863) [ci] Bump cypress disk (elastic#259861) Server timings (elastic#258915) Replace deprecated EUI icons in files owned by @elastic/kibana-cases (elastic#255633) [ci] Bump storybooks disk (elastic#259858) [drilldowns] require embeddables to opt into ON_OPEN_PANEL_MENU trigger (elastic#259637) ...
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Apr 1, 2026
## 📝 Summary This implements the `getDefaultEsqlQuery` accessor for the observability root profile. It also makes the logs locator from `logs_shared` aware of the `discover.isEsqlDefault` feature flag so the observability landing page correctly redirects to an ES|QL Discover session when enabled. closes elastic#254912 ## 🕵️♀️ Review notes * Added `IS_ESQL_DEFAULT_FEATURE_FLAG_KEY` constant to `@kbn/discover-utils` so it can be re-used in the logs locator. * Modified `LogsLocatorDefinition` to delegate to `DISCOVER_APP_LOCATOR` with an ES|QL query when the ES|QL feature flag is enabled and no query is provided; otherwise, it uses the default data view ID. * Added `getDefaultEsqlQuery` accessor to the observability root profile, which generates an ES|QL query based on the resolved logs index pattern, with fallback to previous values. Integrated this accessor into the profile provider. * For testing set `feature_flags.overrides.discover.isEsqlDefault: true` in the kibana config file. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Apr 2, 2026
## 📝 Summary This implements the `getDefaultEsqlQuery` accessor for the observability root profile. It also makes the logs locator from `logs_shared` aware of the `discover.isEsqlDefault` feature flag so the observability landing page correctly redirects to an ES|QL Discover session when enabled. closes elastic#254912 ## 🕵️♀️ Review notes * Added `IS_ESQL_DEFAULT_FEATURE_FLAG_KEY` constant to `@kbn/discover-utils` so it can be re-used in the logs locator. * Modified `LogsLocatorDefinition` to delegate to `DISCOVER_APP_LOCATOR` with an ES|QL query when the ES|QL feature flag is enabled and no query is provided; otherwise, it uses the default data view ID. * Added `getDefaultEsqlQuery` accessor to the observability root profile, which generates an ES|QL query based on the resolved logs index pattern, with fallback to previous values. Integrated this accessor into the profile provider. * For testing set `feature_flags.overrides.discover.isEsqlDefault: true` in the kibana config file. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com> Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This implements the
getDefaultEsqlQueryaccessor for the observability root profile. It also makes the logs locator fromlogs_sharedaware of thediscover.isEsqlDefaultfeature flag so the observability landing page correctly redirects to an ES|QL Discover session when enabled.closes #254912
🕵️♀️ Review notes
IS_ESQL_DEFAULT_FEATURE_FLAG_KEYconstant to@kbn/discover-utilsso it can be re-used in the logs locator.LogsLocatorDefinitionto delegate toDISCOVER_APP_LOCATORwith an ES|QL query when the ES|QL feature flag is enabled and no query is provided; otherwise, it uses the default data view ID.getDefaultEsqlQueryaccessor to the observability root profile, which generates an ES|QL query based on the resolved logs index pattern, with fallback to previous values. Integrated this accessor into the profile provider.feature_flags.overrides.discover.isEsqlDefault: truein the kibana config file.