chore: util to clean cached images by TamerlanG · Pull Request #259335 · elastic/kibana

TamerlanG · 2026-03-24T12:22:36Z

Summary

Our VMs ship with a bunch of cached Docker images that waste disk space on jobs that don't need them. Added clean_cached_images to clear them out before those jobs run.

elasticmachine · 2026-03-24T12:22:40Z

Pinging @elastic/kibana-operations (Team:Operations)

coderabbitai · 2026-03-24T12:28:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 43b55bab-b2a5-448e-9cc8-90b4f336e555

📥 Commits

Reviewing files that changed from the base of the PR and between d4f2e6c and 05db282.

📒 Files selected for processing (1)

.buildkite/scripts/common/util.sh

📝 Walkthrough

Walkthrough

A new clean_cached_images() Bash function was added to .buildkite/scripts/common/util.sh; it collects unique Docker image IDs and performs best-effort removals (docker rmi -f via xargs -r, ignoring failures) and then runs docker image prune -af (also ignoring failures). Inline cached-image cleanup blocks in .buildkite/scripts/steps/artifacts/docker_image.sh and .buildkite/scripts/steps/package_testing/test.sh were replaced with calls to this new function.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation: Commit on current branch
🛠️ Update Documentation: Create PR

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.buildkite/scripts/common/util.sh:
- Around line 216-218: The clean_cached_images function uses an invalid grep
invocation and therefore never removes images; update it to safely pass image
IDs to docker rmi (use command substitution piped to xargs with a no-op-if-empty
flag such as xargs -r or xargs --no-run-if-empty and run docker rmi -f) and
change docker image prune -f to docker image prune -af to include all unused
images; modify the body of clean_cached_images to use the image-ID pipeline with
xargs and the -a prune flag so the function reliably deletes cached images.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: aa418f80-f106-4110-a9f6-e7a98f75e702

📥 Commits

Reviewing files that changed from the base of the PR and between 62a71dc and bf4ca48.

📒 Files selected for processing (3)

.buildkite/scripts/common/util.sh
.buildkite/scripts/steps/artifacts/docker_image.sh
.buildkite/scripts/steps/package_testing/test.sh

.buildkite/scripts/common/util.sh

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

.buildkite/scripts/common/util.sh

coderabbitai

♻️ Duplicate comments (1)

.buildkite/scripts/common/util.sh (1)
220-220: ⚠️ Potential issue | 🔴 Critical

Remove stray closing brace — syntax error.

This unmatched } breaks shell parsing; any script sourcing util.sh will fail to load.

,
Proposed fix
 clean_cached_images() {
   docker images -q | sort -u | xargs -r docker rmi || true
   docker image prune -af || true
 }
-}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.buildkite/scripts/common/util.sh at line 220, There is an unmatched closing
brace ('}') at the end of the script that causes a syntax error; remove this
stray '}' so all function/block braces are balanced (verify functions referenced
in the file are closed correctly), then re-run shellcheck or source the script
to confirm no parsing errors remain.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In @.buildkite/scripts/common/util.sh:
- Line 220: There is an unmatched closing brace ('}') at the end of the script
that causes a syntax error; remove this stray '}' so all function/block braces
are balanced (verify functions referenced in the file are closed correctly),
then re-run shellcheck or source the script to confirm no parsing errors remain.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 96883517-45f2-4173-afc9-58ca83447a9c

📥 Commits

Reviewing files that changed from the base of the PR and between bf4ca48 and d4f2e6c.

📒 Files selected for processing (1)

.buildkite/scripts/common/util.sh

Co-authored-by: Alex Szabo <delanni.alex@gmail.com>

delanni · 2026-03-24T13:27:22Z

/ci

elasticmachine · 2026-03-24T14:36:51Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 05db282
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-259335-05db282afedd

Failed CI Steps

FTR Configs #69

Metrics [docs]

✅ unchanged

History

cc @TamerlanG

kibanamachine · 2026-03-24T14:40:59Z

Starting backport for target branches: 8.19, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/23495342064

kibanamachine · 2026-03-24T14:50:01Z

💔 All backports failed

Status	Branch	Result
❌	8.19	Backport failed because of merge conflicts
❌	9.2	Backport failed because of merge conflicts
❌	9.3	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 259335

Questions ?

Please refer to the Backport tool documentation

(cherry picked from commit 5dac63e) # Conflicts: # .buildkite/scripts/common/util.sh # .buildkite/scripts/steps/artifacts/docker_image.sh

TamerlanG · 2026-03-24T15:47:15Z

💚 All backports created successfully

Status	Branch	Result
✅	9.3
✅	9.2
✅	8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…259423) This reverts commit 56dc7fb. Not needed after #259335

…ra/kibana into dashboard_align_attachment_to_api * 'dashboard_align_attachment_to_api' of github.com:mbondyra/kibana: (45 commits) [OTel Tracing] HTTP instrumentation (elastic#258663) Replace deprecated EUI icons in files owned by @elastic/ml-ui (elastic#255624) [Codeowners] add missing codeowners for security_solution_api_integration tests (elastic#259223) [CI] fix bad imports that came from a merge-race (elastic#259383) Add `.claude/worktrees/` to `.gitignore` (elastic#259192) Improve unknown-key validation error message in @kbn/config-schema (elastic#258633) [ML] Update Security ML jobs to use entity analytics fields for host and user fields (elastic#255339) [Table sweep] Update table columns responsiveness in Index Management and Dashboards (elastic#259340) skip failing test suite (elastic#258790) skip failing test suite (elastic#259261) chore: util to clean cached images (elastic#259335) [Entity Store] Use last_seen for automated resolution watermark (elastic#258574) [One Workflow] Fix flaky alert trigger Scout test by removing order-dependent assertions (elastic#259299) Skip serverless Discover request counts tests for MKI (elastic#259333) [Security Solution] render header title in new document flyout in Security Solution and Discover (elastic#258166) [Agent Builder] register inference endpoint feature (elastic#259259) [Agent Builder] Skills Command Menu - Add descriptions and scope options to agent (elastic#258964) [Streams][Streamlang][API] Fully use meta({id}) to reuse schema partials in OAS output (elastic#259275) fix(files_example): add tableCaption to EuiInMemoryTable for a11y (elastic#258289) [Entity Store] Adding list endpoint with query filter (elastic#258320) ...

# Backport This will backport the following commits from `main` to `8.19`: - [chore: util to clean cached images (#259335)](#259335)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

# Backport This will backport the following commits from `main` to `9.3`: - [chore: util to clean cached images (#259335)](#259335)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

# Backport This will backport the following commits from `main` to `9.2`: - [chore: util to clean cached images (#259335)](#259335)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)

)" (elastic#259423) This reverts commit 56dc7fb. Not needed after elastic#259335

chore: shared function for cleaning cached images

bf4ca48

TamerlanG self-assigned this Mar 24, 2026

TamerlanG requested a review from a team as a code owner March 24, 2026 12:22

TamerlanG added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Mar 24, 2026

coderabbitai bot reviewed Mar 24, 2026

View reviewed changes

.buildkite/scripts/common/util.sh Outdated Show resolved Hide resolved

delanni approved these changes Mar 24, 2026

View reviewed changes

delanni self-requested a review March 24, 2026 12:43

TamerlanG enabled auto-merge (squash) March 24, 2026 12:49

Update .buildkite/scripts/common/util.sh

d4f2e6c

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

delanni reviewed Mar 24, 2026

View reviewed changes

.buildkite/scripts/common/util.sh Show resolved Hide resolved

delanni reviewed Mar 24, 2026

View reviewed changes

.buildkite/scripts/common/util.sh Outdated Show resolved Hide resolved

coderabbitai bot reviewed Mar 24, 2026

View reviewed changes

TamerlanG and others added 2 commits March 24, 2026 14:17

Update .buildkite/scripts/common/util.sh

f1746b5

Co-authored-by: Alex Szabo <delanni.alex@gmail.com>

fix typo

05db282

delanni approved these changes Mar 24, 2026

View reviewed changes

delanni added the ci:build-serverless-image label Mar 24, 2026

TamerlanG merged commit 5dac63e into elastic:main Mar 24, 2026
17 checks passed

kibanamachine added the v9.4.0 label Mar 24, 2026

TamerlanG added a commit to TamerlanG/kibana that referenced this pull request Mar 24, 2026

chore: util to clean cached images (elastic#259335)

a0703e0

(cherry picked from commit 5dac63e) # Conflicts: # .buildkite/scripts/common/util.sh # .buildkite/scripts/steps/artifacts/docker_image.sh

TamerlanG mentioned this pull request Mar 24, 2026

[9.3] chore: util to clean cached images (#259335) #259405

Merged

TamerlanG added a commit to TamerlanG/kibana that referenced this pull request Mar 24, 2026

chore: util to clean cached images (elastic#259335)

7d5ace5

(cherry picked from commit 5dac63e) # Conflicts: # .buildkite/scripts/common/util.sh # .buildkite/scripts/steps/artifacts/docker_image.sh

TamerlanG mentioned this pull request Mar 24, 2026

[9.2] chore: util to clean cached images (#259335) #259406

Merged

TamerlanG added a commit to TamerlanG/kibana that referenced this pull request Mar 24, 2026

chore: util to clean cached images (elastic#259335)

4b42a08

(cherry picked from commit 5dac63e) # Conflicts: # .buildkite/scripts/common/util.sh # .buildkite/scripts/steps/artifacts/docker_image.sh

TamerlanG mentioned this pull request Mar 24, 2026

[8.19] chore: util to clean cached images (#259335) #259408

Merged

jbudz mentioned this pull request Mar 24, 2026

Revert "[build] Increase disk space for serverless build (#259354)" #259423

Merged

jbudz added a commit that referenced this pull request Mar 24, 2026

Revert "[build] Increase disk space for serverless build (#259354)" (#…

d134fa0

…259423) This reverts commit 56dc7fb. Not needed after #259335

kibanamachine added the v8.19.14 label Mar 25, 2026

kibanamachine added the v9.3.3 label Mar 25, 2026

kibanamachine added the v9.2.8 label Mar 25, 2026

jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Mar 26, 2026

chore: util to clean cached images (elastic#259335)

98caac6

jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Mar 26, 2026

Revert "[build] Increase disk space for serverless build (elastic#259354

1e2bd9d

)" (elastic#259423) This reverts commit 56dc7fb. Not needed after elastic#259335

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: util to clean cached images#259335

chore: util to clean cached images#259335
TamerlanG merged 4 commits intoelastic:mainfrom
TamerlanG:fix/clean-cache-docker-images

TamerlanG commented Mar 24, 2026 •

edited by kibanamachine

Loading

Uh oh!

elasticmachine commented Mar 24, 2026

Uh oh!

coderabbitai bot commented Mar 24, 2026 •

edited

Loading

Walkthrough

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

delanni commented Mar 24, 2026

Uh oh!

elasticmachine commented Mar 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

kibanamachine commented Mar 24, 2026

Uh oh!

kibanamachine commented Mar 24, 2026

Uh oh!

TamerlanG commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

TamerlanG commented Mar 24, 2026 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Mar 24, 2026

Uh oh!

coderabbitai bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

delanni commented Mar 24, 2026

Uh oh!

elasticmachine commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

History

Uh oh!

Uh oh!

kibanamachine commented Mar 24, 2026

Uh oh!

kibanamachine commented Mar 24, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

TamerlanG commented Mar 24, 2026

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TamerlanG commented Mar 24, 2026 •

edited by kibanamachine

Loading

coderabbitai bot commented Mar 24, 2026 •

edited

Loading

elasticmachine commented Mar 24, 2026 •

edited

Loading