Skip to content

[One Workflow] Fix flaky alert trigger Scout test by removing order-dependent assertions#259299

Merged
skynetigor merged 4 commits intoelastic:mainfrom
skynetigor:fix_alert_scout_test
Mar 24, 2026
Merged

[One Workflow] Fix flaky alert trigger Scout test by removing order-dependent assertions#259299
skynetigor merged 4 commits intoelastic:mainfrom
skynetigor:fix_alert_scout_test

Conversation

@skynetigor
Copy link
Copy Markdown
Contributor

@skynetigor skynetigor commented Mar 24, 2026

closes: #252959

Summary

Fixes flaky alert trigger Scout test by removing order-dependent assertions on workflow executions.

Workflow executions can start in any order, so the test now collects all outputs first and then asserts that every expected value is present (order-independent), instead of checking each execution by index.

Also re-enables the test (test.describe.skiptest.describe), which was skipped in #252959.

@skynetigor skynetigor added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 24, 2026
@skynetigor skynetigor changed the title make alert test not vulnerable to the order in which workflow executi… [One Workflow] Fix flaky alert trigger Scout test by removing order-dependent assertions Mar 24, 2026
@skynetigor skynetigor marked this pull request as ready for review March 24, 2026 10:38
@skynetigor skynetigor requested a review from a team as a code owner March 24, 2026 10:38
@botelastic botelastic bot added the Team:One Workflow Team label for One Workflow (Workflow automation) label Mar 24, 2026
Copy link
Copy Markdown
Contributor

@rosomri rosomri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skynetigor skynetigor enabled auto-merge (squash) March 24, 2026 13:14
@skynetigor skynetigor merged commit 09d7d64 into elastic:main Mar 24, 2026
18 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / MonitorEditPage shows duplicate error when "nameAlreadyExists" is false

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
workflowsManagement 128 126 -2

Total ESLint disabled count

id before after diff
workflowsManagement 163 161 -2

mbondyra added a commit to mbondyra/kibana that referenced this pull request Mar 24, 2026
…ra/kibana into dashboard_align_attachment_to_api

* 'dashboard_align_attachment_to_api' of github.com:mbondyra/kibana: (45 commits)
  [OTel Tracing] HTTP instrumentation (elastic#258663)
  Replace deprecated EUI icons in files owned by @elastic/ml-ui (elastic#255624)
  [Codeowners] add missing codeowners for security_solution_api_integration tests (elastic#259223)
  [CI] fix bad imports that came from a merge-race (elastic#259383)
  Add `.claude/worktrees/` to `.gitignore` (elastic#259192)
  Improve unknown-key validation error message in @kbn/config-schema (elastic#258633)
  [ML] Update Security ML jobs to use entity analytics fields for host and user fields (elastic#255339)
  [Table sweep] Update table columns responsiveness in Index Management and Dashboards (elastic#259340)
  skip failing test suite (elastic#258790)
  skip failing test suite (elastic#259261)
  chore: util to clean cached images (elastic#259335)
  [Entity Store] Use last_seen for automated resolution watermark (elastic#258574)
  [One Workflow] Fix flaky alert trigger Scout test by removing order-dependent assertions (elastic#259299)
  Skip serverless Discover request counts tests for MKI (elastic#259333)
  [Security Solution] render header title in new document flyout in Security Solution and Discover (elastic#258166)
  [Agent Builder] register inference endpoint feature (elastic#259259)
  [Agent Builder] Skills Command Menu - Add descriptions and scope options to agent (elastic#258964)
  [Streams][Streamlang][API] Fully use meta({id}) to reuse schema partials in OAS output (elastic#259275)
  fix(files_example): add tableCaption to EuiInMemoryTable for a11y (elastic#258289)
  [Entity Store] Adding list endpoint with query filter (elastic#258320)
  ...
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Mar 26, 2026
…ependent assertions (elastic#259299)

closes: elastic#252959

## Summary

Fixes flaky alert trigger Scout test by removing order-dependent
assertions on workflow executions.

Workflow executions can start in any order, so the test now collects all
outputs first and then asserts that every expected value is present
(order-independent), instead of checking each execution by index.

Also re-enables the test (`test.describe.skip` → `test.describe`), which
was skipped in elastic#252959.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:One Workflow Team label for One Workflow (Workflow automation) v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test: Workflow execution - Alert triggers - should trigger workflow from alert

5 participants