Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule#227044
Merged
alexwizp merged 14 commits intoelastic:mainfrom Jul 16, 2025
Merged
Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule#227044alexwizp merged 14 commits intoelastic:mainfrom
alexwizp merged 14 commits intoelastic:mainfrom
Conversation
5a075ef to
8845b21
Compare
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
yngrdyn
approved these changes
Jul 16, 2025
Contributor
yngrdyn
left a comment
There was a problem hiding this comment.
Obs-ux-logs changes LGTM
Contributor
|
Starting backport for target branches: 9.1 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 16, 2025
…Lint rule (elastic#227044) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the codebase. The rule ensures proper accessibility behavior by adding `disableScreenReaderOutput` prop to `EuiToolTip` components when their content duplicates the trigger button's `aria-label`. ## Changes - Auto-fixed instances where `EuiToolTip` components need `disableScreenReaderOutput` prop to prevent redundant screen reader announcements ## Related - elastic/eui#8848 (cherry picked from commit e3e50ea)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 18, 2025
…Lint rule (elastic#227044) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the codebase. The rule ensures proper accessibility behavior by adding `disableScreenReaderOutput` prop to `EuiToolTip` components when their content duplicates the trigger button's `aria-label`. ## Changes - Auto-fixed instances where `EuiToolTip` components need `disableScreenReaderOutput` prop to prevent redundant screen reader announcements ## Related - elastic/eui#8848 (cherry picked from commit e3e50ea) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/summary/index.tsx
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 18, 2025
…Lint rule (elastic#227044) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the codebase. The rule ensures proper accessibility behavior by adding `disableScreenReaderOutput` prop to `EuiToolTip` components when their content duplicates the trigger button's `aria-label`. ## Changes - Auto-fixed instances where `EuiToolTip` components need `disableScreenReaderOutput` prop to prevent redundant screen reader announcements ## Related - elastic/eui#8848 (cherry picked from commit e3e50ea) # Conflicts: # src/platform/packages/private/kbn-esql-editor/src/editor_footer/keyboard_shortcuts.tsx # src/platform/packages/shared/kbn-cell-actions/src/components/extra_actions_button.tsx # src/platform/packages/shared/kbn-unified-tabs/src/components/tabs_bar/tabs_bar.tsx # src/platform/packages/shared/kbn-unified-tabs/src/components/tabs_bar_menu/tabs_bar_menu.tsx # src/platform/plugins/shared/unified_doc_viewer/public/components/observability/traces/components/field_with_actions/field_hover_popover_action.tsx # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/conversations/conversation_selector_settings/index.tsx # x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/header/index.tsx # x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/summary/index.tsx # x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/filter_in.tsx
alexwizp
added a commit
that referenced
this pull request
Jul 21, 2025
…tip ESLint rule (#227044) (#228545) # Backport This will backport the following commits from `main` to `9.1`: - [Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)](#227044) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-07-16T09:56:52Z","message":"Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)\n\n## Summary\n\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the\ncodebase. The rule ensures proper accessibility behavior by adding\n`disableScreenReaderOutput` prop to `EuiToolTip` components when their\ncontent duplicates the trigger button's `aria-label`.\n\n## Changes\n- Auto-fixed instances where `EuiToolTip` components need\n`disableScreenReaderOutput` prop to prevent redundant screen reader\nannouncements\n\n## Related\n- https://github.com/elastic/eui/pull/8848","sha":"e3e50eacef9af7a599af76fbd44bec759c931bd5","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport missing","Team:Fleet","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v9.2.0"],"title":"Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule","number":227044,"url":"https://github.com/elastic/kibana/pull/227044","mergeCommit":{"message":"Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)\n\n## Summary\n\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the\ncodebase. The rule ensures proper accessibility behavior by adding\n`disableScreenReaderOutput` prop to `EuiToolTip` components when their\ncontent duplicates the trigger button's `aria-label`.\n\n## Changes\n- Auto-fixed instances where `EuiToolTip` components need\n`disableScreenReaderOutput` prop to prevent redundant screen reader\nannouncements\n\n## Related\n- https://github.com/elastic/eui/pull/8848","sha":"e3e50eacef9af7a599af76fbd44bec759c931bd5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227044","number":227044,"mergeCommit":{"message":"Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)\n\n## Summary\n\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the\ncodebase. The rule ensures proper accessibility behavior by adding\n`disableScreenReaderOutput` prop to `EuiToolTip` components when their\ncontent duplicates the trigger button's `aria-label`.\n\n## Changes\n- Auto-fixed instances where `EuiToolTip` components need\n`disableScreenReaderOutput` prop to prevent redundant screen reader\nannouncements\n\n## Related\n- https://github.com/elastic/eui/pull/8848","sha":"e3e50eacef9af7a599af76fbd44bec759c931bd5"}}]}] BACKPORT-->
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
…Lint rule (elastic#227044) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the codebase. The rule ensures proper accessibility behavior by adding `disableScreenReaderOutput` prop to `EuiToolTip` components when their content duplicates the trigger button's `aria-label`. ## Changes - Auto-fixed instances where `EuiToolTip` components need `disableScreenReaderOutput` prop to prevent redundant screen reader announcements ## Related - elastic/eui#8848
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
…Lint rule (elastic#227044) ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the codebase. The rule ensures proper accessibility behavior by adding `disableScreenReaderOutput` prop to `EuiToolTip` components when their content duplicates the trigger button's `aria-label`. ## Changes - Auto-fixed instances where `EuiToolTip` components need `disableScreenReaderOutput` prop to prevent redundant screen reader announcements ## Related - elastic/eui#8848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/sr_output_disabled_tooltipESLint rule across the codebase. The rule ensures proper accessibility behavior by addingdisableScreenReaderOutputprop toEuiToolTipcomponents when their content duplicates the trigger button'saria-label.Changes
EuiToolTipcomponents needdisableScreenReaderOutputprop to prevent redundant screen reader announcementsRelated