Skip to content

[9.1] Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)#228545

Merged
alexwizp merged 3 commits intoelastic:9.1from
alexwizp:backport/9.1/pr-227044
Jul 21, 2025
Merged

[9.1] Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)#228545
alexwizp merged 3 commits intoelastic:9.1from
alexwizp:backport/9.1/pr-227044

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Jul 18, 2025

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

@alexwizp
Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ES…
80fc981 
…Lint rule (elastic#227044)

## Summary

This PR applies the auto-fix for the newly introduced
`@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the
codebase. The rule ensures proper accessibility behavior by adding
`disableScreenReaderOutput` prop to `EuiToolTip` components when their
content duplicates the trigger button's `aria-label`.

## Changes
- Auto-fixed instances where `EuiToolTip` components need
`disableScreenReaderOutput` prop to prevent redundant screen reader
announcements

## Related
- elastic/eui#8848

(cherry picked from commit e3e50ea)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/attack_discovery/pages/results/summary/index.tsx
@alexwizp alexwizp requested a review from kibanamachine as a code owner July 18, 2025 08:05
@alexwizp alexwizp added the backport This PR is a backport of another PR label Jul 18, 2025
@alexwizp alexwizp enabled auto-merge (squash) July 18, 2025 08:05
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jul 18, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2025

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@alexwizp alexwizp mentioned this pull request Jul 18, 2025
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 21, 2025 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 508.8KB 508.9KB +145.0B
apm 2.6MB 2.6MB +87.0B
canvas 1.1MB 1.1MB +232.0B
cloudSecurityPosture 555.0KB 555.1KB +58.0B
controls 477.8KB 478.0KB +145.0B
dataVisualizer 681.3KB 681.3KB +29.0B
discover 1.1MB 1.1MB +290.0B
embeddableAlertsTable 914.1KB 914.2KB +29.0B
esql 256.0KB 256.0KB +87.0B
esqlDataGrid 156.9KB 157.0KB +58.0B
exploratoryView 141.3KB 141.3KB +29.0B
fleet 2.1MB 2.1MB +87.0B
graph 370.5KB 370.8KB +348.0B
indexManagement 673.3KB 673.6KB +319.0B
lens 1.5MB 1.5MB +290.0B
logsShared 201.3KB 201.3KB +29.0B
maps 3.1MB 3.1MB +58.0B
ml 5.4MB 5.4MB +116.0B
observability 1.3MB 1.3MB +87.0B
observabilityAIAssistantApp 175.9KB 175.9KB +58.0B
osquery 1.0MB 1.0MB +261.0B
remoteClusters 71.1KB 71.1KB +29.0B
securitySolution 9.8MB 9.8MB +870.0B
serverlessSearch 346.6KB 346.6KB +29.0B
sessionView 356.5KB 356.8KB +232.0B
slo 987.7KB 987.9KB +203.0B
synthetics 1.0MB 1.0MB +29.0B
transform 624.3KB 624.4KB +58.0B
triggersActionsUi 1.5MB 1.5MB +58.0B
unifiedDocViewer 218.8KB 218.9KB +87.0B
visDefaultEditor 92.4KB 92.5KB +58.0B
visTypeTimeseries 439.0KB 439.1KB +116.0B
visTypeXy 41.2KB 41.2KB +58.0B
total +4.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
elasticAssistant 273.0KB 273.2KB +145.0B

History

@bhavyarm bhavyarm self-requested a review July 21, 2025 13:53
bhavyarm
bhavyarm approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp merged commit 7228ec6 into elastic:9.1 Jul 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexwizp @elasticmachine @bhavyarm