Skip to content

[9.1] Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)#228180

Closed
kibanamachine wants to merge 2 commits intoelastic:9.1from
kibanamachine:backport/9.1/pr-227044
Closed

[9.1] Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ESLint rule (#227044)#228180
kibanamachine wants to merge 2 commits intoelastic:9.1from
kibanamachine:backport/9.1/pr-227044

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Jul 16, 2025

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

@alexwizp
Auto-fix violations of the @elastic/eui/sr_output_disabled_tooltip ES…
a80a354 
…Lint rule (elastic#227044)

## Summary

This PR applies the auto-fix for the newly introduced
`@elastic/eui/sr_output_disabled_tooltip` ESLint rule across the
codebase. The rule ensures proper accessibility behavior by adding
`disableScreenReaderOutput` prop to `EuiToolTip` components when their
content duplicates the trigger button's `aria-label`.

## Changes
- Auto-fixed instances where `EuiToolTip` components need
`disableScreenReaderOutput` prop to prevent redundant screen reader
announcements

## Related
- elastic/eui#8848

(cherry picked from commit e3e50ea)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jul 16, 2025
@kibanamachine kibanamachine enabled auto-merge (squash) July 16, 2025 10:03
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jul 16, 2025
@kibanamachine kibanamachine mentioned this pull request Jul 16, 2025
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 16, 2025

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 16, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 16, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@alexwizp alexwizp closed this Jul 18, 2025
auto-merge was automatically disabled July 18, 2025 08:00

Pull request was closed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / Search solution tests Search onboarding API keys Elasticsearch Start [Onboarding Empty State] should show the api key in code view
  • [job] [logs] Jest Tests #18 / UnifiedFieldList FieldItemButton renders properly with an action when deselected
  • [job] [logs] Jest Tests #18 / UnifiedFieldList FieldItemButton renders properly with an action when deselected
  • [job] [logs] Jest Tests #18 / UnifiedFieldList FieldItemButton renders properly with an action when selected
  • [job] [logs] Jest Tests #18 / UnifiedFieldList FieldItemButton renders properly with an action when selected

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 508.8KB 508.9KB +145.0B
apm 2.6MB 2.6MB +87.0B
canvas 1.1MB 1.1MB +232.0B
cloudSecurityPosture 555.0KB 555.1KB +58.0B
controls 477.8KB 478.0KB +145.0B
dataVisualizer 681.3KB 681.3KB +29.0B
discover 1.1MB 1.1MB +290.0B
embeddableAlertsTable 914.1KB 914.2KB +29.0B
esql 256.0KB 256.0KB +87.0B
esqlDataGrid 156.9KB 157.0KB +58.0B
exploratoryView 141.3KB 141.3KB +29.0B
fleet 2.1MB 2.1MB +87.0B
graph 370.5KB 370.8KB +348.0B
indexManagement 673.2KB 673.5KB +319.0B
lens 1.5MB 1.5MB +290.0B
logsShared 201.3KB 201.3KB +29.0B
maps 3.1MB 3.1MB +58.0B
ml 5.4MB 5.4MB +116.0B
observability 1.3MB 1.3MB +87.0B
observabilityAIAssistantApp 175.9KB 175.9KB +58.0B
osquery 1.0MB 1.0MB +261.0B
remoteClusters 71.1KB 71.1KB +29.0B
securitySolution 9.8MB 9.8MB +870.0B
serverlessSearch 346.6KB 346.6KB +29.0B
sessionView 356.5KB 356.8KB +232.0B
slo 987.5KB 987.7KB +203.0B
synthetics 1.0MB 1.0MB +29.0B
transform 624.1KB 624.2KB +58.0B
triggersActionsUi 1.5MB 1.5MB +58.0B
unifiedDocViewer 218.8KB 218.9KB +87.0B
visDefaultEditor 92.4KB 92.5KB +58.0B
visTypeTimeseries 439.0KB 439.1KB +116.0B
visTypeXy 41.2KB 41.2KB +58.0B
total +4.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
elasticAssistant 263.0KB 263.1KB +145.0B

History

cc @alexwizp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@alexwizp alexwizp

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kibanamachine @elasticmachine @alexwizp