[Discover][Field caps] Align with the ES responses for closed indices#199717
Merged
jughosta merged 16 commits intoelastic:mainfrom Nov 19, 2024
Merged
[Discover][Field caps] Align with the ES responses for closed indices#199717jughosta merged 16 commits intoelastic:mainfrom
jughosta merged 16 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
jughosta
commented
Nov 13, 2024
Contributor
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
lukasolson
approved these changes
Nov 14, 2024
Contributor
lukasolson
left a comment
There was a problem hiding this comment.
LGTM, just a couple of minor comments below
| indices: [], | ||
| }); | ||
|
|
||
| await supertest |
Contributor
There was a problem hiding this comment.
Can we make this a new test since the description for the existing one is returns 200 when index is closed?
Contributor
Author
There was a problem hiding this comment.
@lukasolson Sure, I split them in 2 tests ffa49aa, thanks!
Comment on lines
+253
to
+257
| .expect((response) => { | ||
| if (response.statusCode !== 200) { | ||
| log.debug(response.body); | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
Is this intentionally left in the test or was this just for debugging?
Contributor
Author
There was a problem hiding this comment.
I left it so we can see it in logs if it ever fails again in the future.
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💚 Build Succeeded
Metrics [docs]
History
cc @jughosta |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
…elastic#199717) - Closes: elastic#199413 - Related: elastic#199654 - Related ES PR: elastic/elasticsearch#116021 - Related ES PR: elastic/elasticsearch#116656 ## Summary This PR unskips tests and updates the Kibana API to the updated ES responses. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit f61c043)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Nov 20, 2024
…ndices (#199717) (#200697) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover][Field caps] Align with the ES responses for closed indices (#199717)](#199717) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-19T10:42:28Z","message":"[Discover][Field caps] Align with the ES responses for closed indices (#199717)\n\n- Closes: https://github.com/elastic/kibana/issues/199413\r\n- Related: https://github.com/elastic/kibana/pull/199654\r\n- Related ES PR: https://github.com/elastic/elasticsearch/pull/116021\r\n- Related ES PR: https://github.com/elastic/elasticsearch/pull/116656\r\n\r\n## Summary\r\n\r\nThis PR unskips tests and updates the Kibana API to the updated ES\r\nresponses.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"f61c043bf6b00c26a2226537d6d7ad14a1dbc1c9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[Discover][Field caps] Align with the ES responses for closed indices","number":199717,"url":"https://github.com/elastic/kibana/pull/199717","mergeCommit":{"message":"[Discover][Field caps] Align with the ES responses for closed indices (#199717)\n\n- Closes: https://github.com/elastic/kibana/issues/199413\r\n- Related: https://github.com/elastic/kibana/pull/199654\r\n- Related ES PR: https://github.com/elastic/elasticsearch/pull/116021\r\n- Related ES PR: https://github.com/elastic/elasticsearch/pull/116656\r\n\r\n## Summary\r\n\r\nThis PR unskips tests and updates the Kibana API to the updated ES\r\nresponses.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"f61c043bf6b00c26a2226537d6d7ad14a1dbc1c9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199717","number":199717,"mergeCommit":{"message":"[Discover][Field caps] Align with the ES responses for closed indices (#199717)\n\n- Closes: https://github.com/elastic/kibana/issues/199413\r\n- Related: https://github.com/elastic/kibana/pull/199654\r\n- Related ES PR: https://github.com/elastic/elasticsearch/pull/116021\r\n- Related ES PR: https://github.com/elastic/elasticsearch/pull/116656\r\n\r\n## Summary\r\n\r\nThis PR unskips tests and updates the Kibana API to the updated ES\r\nresponses.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"f61c043bf6b00c26a2226537d6d7ad14a1dbc1c9"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…elastic#199717) - Closes: elastic#199413 - Related: elastic#199654 - Related ES PR: elastic/elasticsearch#116021 - Related ES PR: elastic/elasticsearch#116656 ## Summary This PR unskips tests and updates the Kibana API to the updated ES responses. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…elastic#199717) - Closes: elastic#199413 - Related: elastic#199654 - Related ES PR: elastic/elasticsearch#116021 - Related ES PR: elastic/elasticsearch#116656 ## Summary This PR unskips tests and updates the Kibana API to the updated ES responses. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR unskips tests and updates the Kibana API to the updated ES responses.
Checklist