_validate request does not honour ignore_unavailable#116656
Merged
drempapis merged 5 commits intoelastic:mainfrom Nov 13, 2024
Merged
_validate request does not honour ignore_unavailable#116656drempapis merged 5 commits intoelastic:mainfrom
drempapis merged 5 commits intoelastic:mainfrom
Conversation
…dices. Added tests for this new case
Contributor
Author
|
@elasticmachine update branch |
piergm
approved these changes
Nov 12, 2024
Member
piergm
left a comment
There was a problem hiding this comment.
LGTM! 😄 Thanks for working on this @drempapis
Contributor
Author
|
@elasticmachine update branch |
Contributor
|
@drempapis did you mean to backport this to 8.x as well? |
Contributor
Author
Yes, that was my intention. I read the doc that I had to use the auto-backport label instead. I'll do the backport manually! :) |
1 task
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
drempapis
added a commit
to drempapis/elasticsearch
that referenced
this pull request
Nov 13, 2024
The IndicesOption has been updated into the ValidateQueryRequest to encapsulate the following logic. If we target a closed index and ignore_unavailable=false, we get an IndexClosedException, otherwise if the request contains ignore_unavailable=true, we safely skip the closed index. (cherry picked from commit 9584d10)
drempapis
added a commit
that referenced
this pull request
Nov 13, 2024
The IndicesOption has been updated into the ValidateQueryRequest to encapsulate the following logic. If we target a closed index and ignore_unavailable=false, we get an IndexClosedException, otherwise if the request contains ignore_unavailable=true, we safely skip the closed index.
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 13, 2024
The IndicesOption has been updated into the ValidateQueryRequest to encapsulate the following logic. If we target a closed index and ignore_unavailable=false, we get an IndexClosedException, otherwise if the request contains ignore_unavailable=true, we safely skip the closed index.
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 14, 2024
The IndicesOption has been updated into the ValidateQueryRequest to encapsulate the following logic. If we target a closed index and ignore_unavailable=false, we get an IndexClosedException, otherwise if the request contains ignore_unavailable=true, we safely skip the closed index.
jughosta
added a commit
to elastic/kibana
that referenced
this pull request
Nov 19, 2024
…#199717) - Closes: #199413 - Related: #199654 - Related ES PR: elastic/elasticsearch#116021 - Related ES PR: elastic/elasticsearch#116656 ## Summary This PR unskips tests and updates the Kibana API to the updated ES responses. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
…elastic#199717) - Closes: elastic#199413 - Related: elastic#199654 - Related ES PR: elastic/elasticsearch#116021 - Related ES PR: elastic/elasticsearch#116656 ## Summary This PR unskips tests and updates the Kibana API to the updated ES responses. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit f61c043)
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…elastic#199717) - Closes: elastic#199413 - Related: elastic#199654 - Related ES PR: elastic/elasticsearch#116021 - Related ES PR: elastic/elasticsearch#116656 ## Summary This PR unskips tests and updates the Kibana API to the updated ES responses. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
The IndicesOption has been updated into the ValidateQueryRequest to encapsulate the following logic. If we target a closed index and ignore_unavailable=false, we get an IndexClosedException, otherwise if the request contains ignore_unavailable=true, we safely skip the closed index.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…elastic#199717) - Closes: elastic#199413 - Related: elastic#199654 - Related ES PR: elastic/elasticsearch#116021 - Related ES PR: elastic/elasticsearch#116656 ## Summary This PR unskips tests and updates the Kibana API to the updated ES responses. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Querying an existing and
closedindex fails withcluster_block_exceptionwhen the _validate with ignore_unavailable=true is called.Similar case to #116021
Closes #116594