Skip to content

[Discover] Add logging and retry to the closed index test#199654

Closed
jughosta wants to merge 2 commits intoelastic:mainfrom
jughosta:199413-closed-index
Closed

[Discover] Add logging and retry to the closed index test#199654
jughosta wants to merge 2 commits intoelastic:mainfrom
jughosta:199413-closed-index

Conversation

@jughosta
Copy link
Copy Markdown
Contributor

@jughosta jughosta commented Nov 11, 2024

Summary

This PR adds logging which should help with debugging. Also interesting to see if the retry is now necessary.

Checklist

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:prev-minor labels Nov 11, 2024
@jughosta jughosta self-assigned this Nov 11, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7374

[✅] test/api_integration/config.js: 25/25 tests passed.

see run history

@jughosta jughosta marked this pull request as ready for review November 11, 2024 16:32
@jughosta jughosta requested a review from a team as a code owner November 11, 2024 16:32
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta requested a review from a team as a code owner November 11, 2024 16:48

export CACHE_DIR="$HOME/.kibana"
export ES_CACHE_DIR="$HOME/.es-snapshot-cache"
export ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.0.0/archives/20241111-031745_fae80f85/manifest.json"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary change. Waiting for the CI as suggested by @jbudz.

Copy link
Copy Markdown
Contributor Author

@jughosta jughosta Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ran it locally and could already see the logs from Kibana API response:

{
           │        statusCode: 404,
           │        error: 'Not Found',
           │        message: 'No indices match "basic_index"',
           │        attributes: {
           │          statusCode: 404,
           │          error: 'Not Found',
           │          message: 'No indices match "basic_index"',
           │          code: 'no_matching_indices'
           │        }
           │      }

Then I executed the following in DevTools:

PUT test
PUT test/_mapping
{
  "properties": {
    "actual": {
      "type": "keyword"
    }
  }
}
POST test/_field_caps?fields=*
POST test/_close
POST test/_field_caps?fields=*

And got the following response from ES:
Screenshot 2024-11-11 at 18 14 32

It used to be cluster_block_exception before:
Screenshot 2024-11-11 at 18 14 12

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 11, 2024

💔 Build Failed

Failed CI Steps

History

cc @jughosta

@jughosta
Copy link
Copy Markdown
Contributor Author

Kibana API needs to be updated to support new ES response elastic/elasticsearch#116021

@jughosta jughosta closed this Nov 11, 2024
@jughosta jughosta deleted the 199413-closed-index branch November 11, 2024 20:18
jughosta added a commit that referenced this pull request Nov 19, 2024
…#199717)

- Closes: #199413
- Related: #199654
- Related ES PR: elastic/elasticsearch#116021
- Related ES PR: elastic/elasticsearch#116656

## Summary

This PR unskips tests and updates the Kibana API to the updated ES
responses.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2024
…elastic#199717)

- Closes: elastic#199413
- Related: elastic#199654
- Related ES PR: elastic/elasticsearch#116021
- Related ES PR: elastic/elasticsearch#116656

## Summary

This PR unskips tests and updates the Kibana API to the updated ES
responses.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit f61c043)
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…elastic#199717)

- Closes: elastic#199413
- Related: elastic#199654
- Related ES PR: elastic/elasticsearch#116021
- Related ES PR: elastic/elasticsearch#116656

## Summary

This PR unskips tests and updates the Kibana API to the updated ES
responses.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…elastic#199717)

- Closes: elastic#199413
- Related: elastic#199654
- Related ES PR: elastic/elasticsearch#116021
- Related ES PR: elastic/elasticsearch#116656

## Summary

This PR unskips tests and updates the Kibana API to the updated ES
responses.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t//

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants