Skip to content

[ES|QL] Renames the textbased editor to esql editor#193521

Merged
stratoula merged 9 commits intoelastic:mainfrom
stratoula:textbased-to-esql-editor
Sep 23, 2024
Merged

[ES|QL] Renames the textbased editor to esql editor#193521
stratoula merged 9 commits intoelastic:mainfrom
stratoula:textbased-to-esql-editor

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Sep 20, 2024

Summary

Renames the text-based-editor to esql-editor

I tried to also rename components, data-test-subj, classNames and files. My focus is mostly on the plugin and package of the esql editor

@stratoula stratoula changed the title Renames the textbased editor to esql editor [ES|QL] Renames the textbased editor to esql editor Sep 20, 2024
@stratoula stratoula added backport:prev-minor Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.16.0 labels Sep 20, 2024
@stratoula stratoula marked this pull request as ready for review September 20, 2024 13:09
@stratoula stratoula requested review from a team as code owners September 20, 2024 13:09
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula requested a review from a team as a code owner September 20, 2024 13:09
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML related changes LGTM.

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 20, 2024
Copy link
Copy Markdown
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍

Copy link
Copy Markdown
Contributor

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.buildkite/scripts/steps/storybooks/build_and_upload.ts, src/dev/storybook/aliases.ts

Copy link
Copy Markdown
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-presentation changes LGTM
code review only


await monacoEditor.setCodeEditorValue('from logstash-* | stats maxB = max(bytes)');
await testSubjects.click('TextBasedLangEditor-run-query-button');
await testSubjects.click('ESQLEditor-run-query-button');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move this to a page object or service?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would but not on this PR.

Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs ux management changes LGTM

@stratoula
Copy link
Copy Markdown
Contributor Author

/ci

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 23, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-editor - 12 +12
@kbn/text-based-editor 12 - -12
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 726.5KB 726.5KB -10.0B
esql 172.9KB 171.4KB -1.5KB
investigateApp 465.1KB 465.0KB -5.0B
lens 1.5MB 1.5MB -14.0B
maps 3.0MB 3.0MB -5.0B
stackAlerts 75.7KB 75.7KB -5.0B
unifiedSearch 341.6KB 341.6KB -5.0B
total -1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esql 6.5KB 6.5KB -5.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-editor - 29 +29
@kbn/text-based-editor 29 - -29
total -0

ESLint disabled line counts

id before after diff
@kbn/esql-editor - 5 +5
@kbn/text-based-editor 5 - -5
total -0

Total ESLint disabled count

id before after diff
@kbn/esql-editor - 5 +5
@kbn/text-based-editor 5 - -5
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit d56a1bb into elastic:main Sep 23, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [[ES

Manual backport

To create the backport manually run:

node scripts/backport --pr 193521

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit to stratoula/kibana that referenced this pull request Sep 23, 2024
## Summary

Renames the text-based-editor to esql-editor

I tried to also rename components, data-test-subj, classNames and files.
My focus is mostly on the plugin and package of the esql editor

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d56a1bb)

# Conflicts:
#	.github/CODEOWNERS
@stratoula
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula added a commit that referenced this pull request Sep 23, 2024
…193706)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Renames the textbased editor to esql editor
(#193521)](#193521)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-09-23T10:06:53Z","message":"[ES|QL]
Renames the textbased editor to esql editor (#193521)\n\n##
Summary\r\n\r\nRenames the text-based-editor to esql-editor\r\n\r\nI
tried to also rename components, data-test-subj, classNames and
files.\r\nMy focus is mostly on the plugin and package of the esql
editor\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d56a1bbbbafee958abf7583e7a867bd1ac8187a6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","ci:project-deploy-observability","Team:ESQL","v8.16.0"],"number":193521,"url":"https://github.com/elastic/kibana/pull/193521","mergeCommit":{"message":"[ES|QL]
Renames the textbased editor to esql editor (#193521)\n\n##
Summary\r\n\r\nRenames the text-based-editor to esql-editor\r\n\r\nI
tried to also rename components, data-test-subj, classNames and
files.\r\nMy focus is mostly on the plugin and package of the esql
editor\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d56a1bbbbafee958abf7583e7a867bd1ac8187a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193521","number":193521,"mergeCommit":{"message":"[ES|QL]
Renames the textbased editor to esql editor (#193521)\n\n##
Summary\r\n\r\nRenames the text-based-editor to esql-editor\r\n\r\nI
tried to also rename components, data-test-subj, classNames and
files.\r\nMy focus is mostly on the plugin and package of the esql
editor\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"d56a1bbbbafee958abf7583e7a867bd1ac8187a6"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
weizijun added a commit to weizijun/kibana that referenced this pull request Sep 23, 2024
* main: (176 commits)
  [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420)
  Bump maximum supported package spec version to 3.2 (elastic#193574)
  [ES|QL] new pattern for `SORT` autocomplete (elastic#193595)
  [Inventory][ECO] Entities page search bar (elastic#193546)
  [Synthetics] Remove extra overview route (elastic#192449)
  [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693)
  [Migrations] Remove tests that are not applicable in 9.x (elastic#193699)
  [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017)
  [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557)
  [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562)
  [Entity Analytics] Ensuring definition transforms are managed (elastic#193408)
  [Automatic Import] Do not remove message field for unstructured logs (elastic#193678)
  [Fleet] Add missing permissions for connector package (elastic#193573)
  [Fleet] using @kbn/config-schema part 2 (outputs and other apis)  (elastic#193326)
  [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328)
  [ES|QL] Renames the textbased editor to esql editor (elastic#193521)
  [ES|QL] Update function metadata (elastic#193662)
  [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303)
  [Docs] Update Sharing docs (elastic#190318)
  [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243)
  ...

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-observability Create an Observability project Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.