[ES|QL] Renames the textbased editor to esql editor#193521
[ES|QL] Renames the textbased editor to esql editor#193521stratoula merged 9 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/kibana-esql (Team:ESQL) |
walterra
left a comment
There was a problem hiding this comment.
ML related changes LGTM.
jughosta
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM 👍
jbudz
left a comment
There was a problem hiding this comment.
.buildkite/scripts/steps/storybooks/build_and_upload.ts, src/dev/storybook/aliases.ts
nreese
left a comment
There was a problem hiding this comment.
kibana-presentation changes LGTM
code review only
|
|
||
| await monacoEditor.setCodeEditorValue('from logstash-* | stats maxB = max(bytes)'); | ||
| await testSubjects.click('TextBasedLangEditor-run-query-button'); | ||
| await testSubjects.click('ESQLEditor-run-query-button'); |
There was a problem hiding this comment.
Would it make sense to move this to a page object or service?
There was a problem hiding this comment.
It would but not on this PR.
dominiqueclarke
left a comment
There was a problem hiding this comment.
Obs ux management changes LGTM
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
## Summary Renames the text-based-editor to esql-editor I tried to also rename components, data-test-subj, classNames and files. My focus is mostly on the plugin and package of the esql editor --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d56a1bb) # Conflicts: # .github/CODEOWNERS
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…193706) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Renames the textbased editor to esql editor (#193521)](#193521) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"efstratia.kalafateli@elastic.co"},"sourceCommit":{"committedDate":"2024-09-23T10:06:53Z","message":"[ES|QL] Renames the textbased editor to esql editor (#193521)\n\n## Summary\r\n\r\nRenames the text-based-editor to esql-editor\r\n\r\nI tried to also rename components, data-test-subj, classNames and files.\r\nMy focus is mostly on the plugin and package of the esql editor\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d56a1bbbbafee958abf7583e7a867bd1ac8187a6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","ci:project-deploy-observability","Team:ESQL","v8.16.0"],"number":193521,"url":"https://github.com/elastic/kibana/pull/193521","mergeCommit":{"message":"[ES|QL] Renames the textbased editor to esql editor (#193521)\n\n## Summary\r\n\r\nRenames the text-based-editor to esql-editor\r\n\r\nI tried to also rename components, data-test-subj, classNames and files.\r\nMy focus is mostly on the plugin and package of the esql editor\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d56a1bbbbafee958abf7583e7a867bd1ac8187a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193521","number":193521,"mergeCommit":{"message":"[ES|QL] Renames the textbased editor to esql editor (#193521)\n\n## Summary\r\n\r\nRenames the text-based-editor to esql-editor\r\n\r\nI tried to also rename components, data-test-subj, classNames and files.\r\nMy focus is mostly on the plugin and package of the esql editor\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"d56a1bbbbafee958abf7583e7a867bd1ac8187a6"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
* main: (176 commits) [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420) Bump maximum supported package spec version to 3.2 (elastic#193574) [ES|QL] new pattern for `SORT` autocomplete (elastic#193595) [Inventory][ECO] Entities page search bar (elastic#193546) [Synthetics] Remove extra overview route (elastic#192449) [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693) [Migrations] Remove tests that are not applicable in 9.x (elastic#193699) [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017) [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557) [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562) [Entity Analytics] Ensuring definition transforms are managed (elastic#193408) [Automatic Import] Do not remove message field for unstructured logs (elastic#193678) [Fleet] Add missing permissions for connector package (elastic#193573) [Fleet] using @kbn/config-schema part 2 (outputs and other apis) (elastic#193326) [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328) [ES|QL] Renames the textbased editor to esql editor (elastic#193521) [ES|QL] Update function metadata (elastic#193662) [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303) [Docs] Update Sharing docs (elastic#190318) [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243) ... # Conflicts: # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
Summary
Renames the text-based-editor to esql-editor
I tried to also rename components, data-test-subj, classNames and files. My focus is mostly on the plugin and package of the esql editor