Skip to content

[Fleet] Add missing permissions for connector package#193573

Merged
jedrazb merged 3 commits intoelastic:mainfrom
jedrazb:connector-permission-allow-logs-collection
Sep 23, 2024
Merged

[Fleet] Add missing permissions for connector package#193573
jedrazb merged 3 commits intoelastic:mainfrom
jedrazb:connector-permission-allow-logs-collection

Conversation

@jedrazb
Copy link
Copy Markdown
Contributor

@jedrazb jedrazb commented Sep 20, 2024

Summary

Defines custom permissions for connector package.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
tested e2e with local ES, fleet server and connectors package

@jedrazb jedrazb added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0 Team:Search labels Sep 20, 2024
@jedrazb jedrazb marked this pull request as ready for review September 20, 2024 13:14
@jedrazb jedrazb requested a review from a team as a code owner September 20, 2024 13:14
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

privileges: ELASTIC_CONNECTORS_INDEX_PERMISSIONS,
},
{
names: ['logs-elastic_agent*'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original PR had also had metrics-* and traces-*. Do we need those in order to power other fleet/agent features? b5c1ce1

Copy link
Copy Markdown
Contributor Author

@jedrazb jedrazb Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so, the system component (added by default in agent unless you opt out) is able to send system metrics, the only bit we were missing were component logs. I was able to see agent metrics (mem,cpu, etc) without other privileges

@jedrazb
Copy link
Copy Markdown
Contributor Author

jedrazb commented Sep 23, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jedrazb jedrazb merged commit c179451 into elastic:main Sep 23, 2024
weizijun added a commit to weizijun/kibana that referenced this pull request Sep 23, 2024
* main: (176 commits)
  [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420)
  Bump maximum supported package spec version to 3.2 (elastic#193574)
  [ES|QL] new pattern for `SORT` autocomplete (elastic#193595)
  [Inventory][ECO] Entities page search bar (elastic#193546)
  [Synthetics] Remove extra overview route (elastic#192449)
  [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693)
  [Migrations] Remove tests that are not applicable in 9.x (elastic#193699)
  [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017)
  [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557)
  [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562)
  [Entity Analytics] Ensuring definition transforms are managed (elastic#193408)
  [Automatic Import] Do not remove message field for unstructured logs (elastic#193678)
  [Fleet] Add missing permissions for connector package (elastic#193573)
  [Fleet] using @kbn/config-schema part 2 (outputs and other apis)  (elastic#193326)
  [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328)
  [ES|QL] Renames the textbased editor to esql editor (elastic#193521)
  [ES|QL] Update function metadata (elastic#193662)
  [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303)
  [Docs] Update Sharing docs (elastic#190318)
  [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243)
  ...

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Search v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants