Skip to content

[8.x] [ES|QL] Renames the textbased editor to esql editor (#193521)#193706

Merged
stratoula merged 1 commit intoelastic:8.xfrom
stratoula:backport/8.x/pr-193521
Sep 23, 2024
Merged

[8.x] [ES|QL] Renames the textbased editor to esql editor (#193521)#193706
stratoula merged 1 commit intoelastic:8.xfrom
stratoula:backport/8.x/pr-193521

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Sep 23, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@stratoula
[ES|QL] Renames the textbased editor to esql editor (elastic#193521)
ddb16bc 
## Summary

Renames the text-based-editor to esql-editor

I tried to also rename components, data-test-subj, classNames and files.
My focus is mostly on the plugin and package of the esql editor

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d56a1bb)

# Conflicts:
#	.github/CODEOWNERS
@stratoula stratoula added the backport This PR is a backport of another PR label Sep 23, 2024
@stratoula stratoula enabled auto-merge (squash) September 23, 2024 11:50
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 23, 2024
@stratoula stratoula mentioned this pull request Sep 23, 2024
Merged
@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented Sep 23, 2024

/ci

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/esql-editor - 12 +12
@kbn/text-based-editor 12 - -12
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 726.5KB 726.5KB -10.0B
esql 172.9KB 171.4KB -1.5KB
investigateApp 465.1KB 465.0KB -5.0B
lens 1.5MB 1.5MB -14.0B
maps 3.0MB 3.0MB -5.0B
stackAlerts 75.7KB 75.7KB -5.0B
unifiedSearch 341.6KB 341.6KB -5.0B
total -1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esql 6.5KB 6.5KB -5.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-editor - 29 +29
@kbn/text-based-editor 29 - -29
total -0

ESLint disabled line counts

id before after diff
@kbn/esql-editor - 5 +5
@kbn/text-based-editor 5 - -5
total -0

Total ESLint disabled count

id before after diff
@kbn/esql-editor - 5 +5
@kbn/text-based-editor 5 - -5
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula disabled auto-merge September 23, 2024 13:22
@stratoula stratoula merged commit 0895634 into elastic:8.x Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stratoula @kibana-ci