Skip to content

remove @kbn/presentation-containers from synthetics page load bundle#189533

Merged
nreese merged 4 commits intoelastic:mainfrom
nreese:synthetics_bundle
Jul 30, 2024
Merged

remove @kbn/presentation-containers from synthetics page load bundle#189533
nreese merged 4 commits intoelastic:mainfrom
nreese:synthetics_bundle

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Jul 30, 2024 •
edited
Loading

#189128 increases @kbn/presentation-containers size. This causes synthetics page load bundle to exceed the bundle size limit. Synthetics page load should not include @kbn/presentation-containers. This PR resolves the problem by putting @kbn/presentation-containers load behind an async import

Note for reviewers, put compatibility check into its own file to avoid importing entire @kbn/presentation-containers
into async bundle. Tree shaking is enable by putting the import in a seperate file - see #189206 (comment) for more details

@nreese nreese requested a review from a team as a code owner July 30, 2024 15:27
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jul 30, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 30, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Jul 30, 2024
dominiqueclarke
dominiqueclarke approved these changes Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jul 30, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 975 976 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 847.9KB 853.1KB +5.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 40.0KB 35.7KB -4.2KB
Unknown metric groups

async chunk count

id before after diff
synthetics 8 10 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 6e622e9 into elastic:main Jul 30, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 30, 2024
@nreese nreese mentioned this pull request Jul 31, 2024
Merged
nreese added a commit that referenced this pull request Jul 31, 2024
@nreese
remove @kbn/presentation-containers from links page load bundle (#189595
817b320 
)

Same as #189533 but for links
plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nreese @elasticmachine @kibana-ci @dominiqueclarke @kibanamachine