Skip to content

remove @kbn/presentation-containers from links page load bundle#189595

Merged
nreese merged 1 commit intoelastic:mainfrom
nreese:links_bundl
Jul 31, 2024
Merged

remove @kbn/presentation-containers from links page load bundle#189595
nreese merged 1 commit intoelastic:mainfrom
nreese:links_bundl

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Jul 31, 2024

Same as #189533 but for links plugin

@nreese nreese requested a review from a team as a code owner July 31, 2024 03:34
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Jul 31, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / createRegisteredAttachmentUserActionBuilder renders the children correctly
  • [job] [logs] FTR Configs #4 / Journey[tags_listing_page] Delete the first 20 tags

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
links 126 127 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
links 48.1KB 51.6KB +3.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
links 19.8KB 16.8KB -3.0KB
Unknown metric groups

async chunk count

id before after diff
links 4 6 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 817b320 into elastic:main Jul 31, 2024
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants