Remove 'Create Rule' button from Rule Group page#164167
Merged
machadoum merged 11 commits intoelastic:mainfrom Aug 23, 2023
Merged
Remove 'Create Rule' button from Rule Group page#164167machadoum merged 11 commits intoelastic:mainfrom
machadoum merged 11 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @machadoum |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2023
issue: elastic#163462 ## Summary Change of plan. We are going to delete the button. ~Disable the 'Create Rule' button on the Rule Group page and add the read icon to the topbar when the user is on read mode.~ Delete 'Create Rule' button on the Rule Group page ### How to reproduce it * ~Create a role with read access to the security solution feature~ * ~Login with a user that has the created role~ * Open the rule group page ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 9aafd1f)
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2023
…64535) # Backport This will backport the following commits from `main` to `8.10`: - [Remove 'Create Rule' button from Rule Group page (#164167)](#164167) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"machadoum@gmail.com"},"sourceCommit":{"committedDate":"2023-08-23T08:20:32Z","message":"Remove 'Create Rule' button from Rule Group page (#164167)\n\nissue: https://github.com/elastic/kibana/issues/163462\r\n\r\n## Summary\r\n\r\nChange of plan. We are going to delete the button.\r\n\r\n~Disable the 'Create Rule' button on the Rule Group page and add the\r\nread icon to the topbar when the user is on read mode.~\r\nDelete 'Create Rule' button on the Rule Group page\r\n\r\n### How to reproduce it\r\n* ~Create a role with read access to the security solution feature~\r\n* ~Login with a user that has the created role~\r\n* Open the rule group page\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"9aafd1ff834c4609317846ed8643faf47a6fb6de","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team: SecuritySolution","Team:Threat Hunting:Explore","v8.10.0","v8.11.0"],"number":164167,"url":"https://github.com/elastic/kibana/pull/164167","mergeCommit":{"message":"Remove 'Create Rule' button from Rule Group page (#164167)\n\nissue: https://github.com/elastic/kibana/issues/163462\r\n\r\n## Summary\r\n\r\nChange of plan. We are going to delete the button.\r\n\r\n~Disable the 'Create Rule' button on the Rule Group page and add the\r\nread icon to the topbar when the user is on read mode.~\r\nDelete 'Create Rule' button on the Rule Group page\r\n\r\n### How to reproduce it\r\n* ~Create a role with read access to the security solution feature~\r\n* ~Login with a user that has the created role~\r\n* Open the rule group page\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"9aafd1ff834c4609317846ed8643faf47a6fb6de"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164167","number":164167,"mergeCommit":{"message":"Remove 'Create Rule' button from Rule Group page (#164167)\n\nissue: https://github.com/elastic/kibana/issues/163462\r\n\r\n## Summary\r\n\r\nChange of plan. We are going to delete the button.\r\n\r\n~Disable the 'Create Rule' button on the Rule Group page and add the\r\nread icon to the topbar when the user is on read mode.~\r\nDelete 'Create Rule' button on the Rule Group page\r\n\r\n### How to reproduce it\r\n* ~Create a role with read access to the security solution feature~\r\n* ~Login with a user that has the created role~\r\n* Open the rule group page\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"9aafd1ff834c4609317846ed8643faf47a6fb6de"}}]}] BACKPORT--> Co-authored-by: Pablo Machado <machadoum@gmail.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 23, 2023
* main: (150 commits) Fixes unnecessary autocompletes on HTTP methods (elastic#163233) [Defend Workflows] Convert filterQuery to kql (elastic#161806) [Fleet] copy `inactivity_timeout` when duplicating agent policy (elastic#164544) Fix 7.17 forward compatibility with 8.2+ (elastic#164274) [ML] Fixes dark mode in flyouts and modals (elastic#164399) [Defend Workflows]Changes to policy settings are not persistent until a refresh (elastic#164403) [Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (elastic#164329) Prepare the Security domain HTTP APIs for Serverless (elastic#162087) skip failing test suite (elastic#160986) [Security Solution] Fix flaky Event Filters test (elastic#164473) [EDR workflows] Osquery serverless tests (elastic#163795) [Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (elastic#164469) [Chrome UI] Fix background color in serverless (elastic#164419) [DOCS] Saved objects - resolve import errors API (elastic#162825) Remove 'Create Rule' button from Rule Group page (elastic#164167) [Security Solution] expandable flyout - fix infinite loop in correlations (elastic#163450) [Remote Clusters] Update copy about port help text (elastic#164442) [api-docs] 2023-08-23 Daily api_docs build (elastic#164524) [data views] Disable scripted fields in serverless environment (elastic#163228) [Reporting] Fix - show diagnostic only when image reporting is enabled (elastic#164336) ...
This was referenced Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #163462
Summary
Change of plan. We are going to delete the button.
Disable the 'Create Rule' button on the Rule Group page and add the read icon to the topbar when the user is on read mode.Delete 'Create Rule' button on the Rule Group page
How to reproduce it
Create a role with read access to the security solution featureLogin with a user that has the created roleChecklist
Delete any items that are not applicable to this PR.