Skip to content

[Security Solution] Fix flaky Event Filters test#164473

Merged
dasansol92 merged 3 commits intoelastic:mainfrom
kevinlog:task/fix-flaky-event-filter-test
Aug 23, 2023
Merged

[Security Solution] Fix flaky Event Filters test#164473
dasansol92 merged 3 commits intoelastic:mainfrom
kevinlog:task/fix-flaky-event-filter-test

Conversation

@kevinlog
Copy link
Copy Markdown
Contributor

@kevinlog kevinlog commented Aug 22, 2023

Summary

Fix flaky test for Event Filters and re-enable. Also, needed to adjust a Blocklist test for a previous bugfix that was missed because the suite was skipped.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2952

Closes: #163140

Checklist

@kevinlog kevinlog added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.10.0 v8.11.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 22, 2023
@kevinlog kevinlog marked this pull request as ready for review August 22, 2023 18:16
@kevinlog kevinlog requested a review from a team as a code owner August 22, 2023 18:16
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2023
## Summary

Fix flaky test for Event Filters and re-enable. Also, needed to adjust a
Blocklist test for a previous bugfix that was missed because the suite
was skipped.

Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2952

Closes: elastic#163140

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 2dc4e43)
kibanamachine added a commit that referenced this pull request Aug 23, 2023
…64550)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] Fix flaky Event Filters test
(#164473)](#164473)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Logan","email":"56395104+kevinlog@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-23T10:18:14Z","message":"[Security
Solution] Fix flaky Event Filters test (#164473)\n\n##
Summary\r\n\r\nFix flaky test for Event Filters and re-enable. Also,
needed to adjust a\r\nBlocklist test for a previous bugfix that was
missed because the suite\r\nwas skipped.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2952\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/163140\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2dc4e4301426fbf03f10ed98b1541e3d1a1839bc","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.10.0","v8.11.0"],"number":164473,"url":"https://github.com/elastic/kibana/pull/164473","mergeCommit":{"message":"[Security
Solution] Fix flaky Event Filters test (#164473)\n\n##
Summary\r\n\r\nFix flaky test for Event Filters and re-enable. Also,
needed to adjust a\r\nBlocklist test for a previous bugfix that was
missed because the suite\r\nwas skipped.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2952\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/163140\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2dc4e4301426fbf03f10ed98b1541e3d1a1839bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164473","number":164473,"mergeCommit":{"message":"[Security
Solution] Fix flaky Event Filters test (#164473)\n\n##
Summary\r\n\r\nFix flaky test for Event Filters and re-enable. Also,
needed to adjust a\r\nBlocklist test for a previous bugfix that was
missed because the suite\r\nwas skipped.\r\n\r\nFlaky test
runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2952\r\n\r\nCloses:
https://github.com/elastic/kibana/issues/163140\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"2dc4e4301426fbf03f10ed98b1541e3d1a1839bc"}}]}]
BACKPORT-->

Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
@kevinlog kevinlog deleted the task/fix-flaky-event-filter-test branch August 23, 2023 13:00
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 23, 2023
* main: (150 commits)
  Fixes unnecessary autocompletes on HTTP methods (elastic#163233)
  [Defend Workflows] Convert filterQuery to kql  (elastic#161806)
  [Fleet] copy `inactivity_timeout` when duplicating agent policy (elastic#164544)
  Fix 7.17 forward compatibility with 8.2+ (elastic#164274)
  [ML] Fixes dark mode in flyouts and modals (elastic#164399)
  [Defend Workflows]Changes to policy settings are not persistent until a refresh (elastic#164403)
  [Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (elastic#164329)
  Prepare the Security domain HTTP APIs for Serverless (elastic#162087)
  skip failing test suite (elastic#160986)
  [Security Solution] Fix flaky Event Filters test (elastic#164473)
  [EDR workflows] Osquery serverless tests (elastic#163795)
  [Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (elastic#164469)
  [Chrome UI] Fix background color in serverless (elastic#164419)
  [DOCS] Saved objects - resolve import errors API (elastic#162825)
  Remove 'Create Rule' button from Rule Group page (elastic#164167)
  [Security Solution] expandable flyout - fix infinite loop in correlations (elastic#163450)
  [Remote Clusters] Update copy about port help text (elastic#164442)
  [api-docs] 2023-08-23 Daily api_docs build (elastic#164524)
  [data views] Disable scripted fields in serverless environment (elastic#163228)
  [Reporting] Fix - show diagnostic only when image reporting is enabled (elastic#164336)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.10.0 v8.11.0

Projects

None yet

6 participants