dashboard Reset button disable by AbrarAlHasan · Pull Request #159430 · elastic/kibana

AbrarAlHasan · 2023-06-10T06:17:31Z

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.
Added Reset Disable for Title and Description.

Cases

If the title or Description is same and not changed Reset button is diabled.
If the Reset is clicked then the title or description resets to the Previous value before Saved
[

Screen.Recording.2023-06-10.at.11.21.35.AM.1.mp4

](url)

For maintainers

This was checked for breaking API changes and was labeled appropriately

kibanamachine · 2023-06-10T06:17:34Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

cla-checker-service · 2023-06-10T06:17:36Z

💚 CLA has been signed

ThomThomson · 2023-06-12T15:04:11Z

@AbrarAlHasan would you mind signing the CLA? If you do, I can kick off a build.

AbrarAlHasan · 2023-06-12T15:26:29Z

@AbrarAlHasan would you mind signing the CLA? If you do, I can kick off a build.

Sure. I have Signed it

elasticmachine · 2023-06-12T15:27:57Z

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson · 2023-06-12T15:28:06Z

@buildkite test this

ThomThomson

Thank you for your contribution @AbrarAlHasan!

The reset button is actually meant to only reset to the default title. This allows the dashboard author to remove the custom title and fall back directly to the saved object title. To see this behaviour you'll need to use a panel linked to a library item (use the add from Library button on the Dashboard).

The way you've written this is equivalent to resetting to the last saved custom title, which can be done just by clicking cancel instead of save in the bottom of the flyout. I've made some suggested changes which make the buttons disabled when the current title / description is equal to the default title / description.

ThomThomson · 2023-06-12T16:02:01Z

...dable/public/lib/panel/panel_header/panel_actions/customize_panel/customize_panel_editor.tsx

+              onClick={() => {
+                setPanelTitle(embeddable.getInput().title ?? embeddable.getOutput().defaultTitle);
+              }}


This change should be undone: the reset button should always set it back to the default title.

Suggested change

onClick={() => {

setPanelTitle(embeddable.getInput().title ?? embeddable.getOutput().defaultTitle);

}}

onClick={() => setPanelTitle(embeddable.getOutput().defaultTitle)}

ThomThomson · 2023-06-12T16:02:47Z

...dable/public/lib/panel/panel_header/panel_actions/customize_panel/customize_panel_editor.tsx

+              disabled={
+                hideTitle || !editMode || embeddable.getInput().title != undefined
+                  ? embeddable.getInput().title === panelTitle
+                  : embeddable.getOutput().defaultTitle === panelTitle || panelTitle === ''
+              }


This should only be disabled if the panel title is equal to the default title:

Suggested change

disabled={

hideTitle || !editMode || embeddable.getInput().title != undefined

? embeddable.getInput().title === panelTitle

: embeddable.getOutput().defaultTitle === panelTitle || panelTitle === ''

}

disabled={

hideTitle || !editMode || embeddable.getOutput().defaultTitle === panelTitle

}

ThomThomson · 2023-06-12T16:04:41Z

...dable/public/lib/panel/panel_header/panel_actions/customize_panel/customize_panel_editor.tsx

+                setPanelDescription(
+                  embeddable.getInput().description ?? embeddable.getOutput().defaultDescription
+                );


This change should be undone: the reset button should always set it back to the default description.

Suggested change

setPanelDescription(

embeddable.getInput().description ?? embeddable.getOutput().defaultDescription

);

setPanelDescription(embeddable.getOutput().defaultDescription);

ThomThomson · 2023-06-12T16:05:15Z

...dable/public/lib/panel/panel_header/panel_actions/customize_panel/customize_panel_editor.tsx

+              disabled={
+                hideTitle || !editMode || embeddable.getInput().description != undefined
+                  ? embeddable.getInput().description === panelDescription
+                  : embeddable.getOutput().defaultDescription === panelDescription ||
+                    panelDescription === ''
+              }


This should only be disabled if the panel description is equal to the default description:

Suggested change

disabled={

hideTitle || !editMode || embeddable.getInput().description != undefined

? embeddable.getInput().description === panelDescription

: embeddable.getOutput().defaultDescription === panelDescription ||

panelDescription === ''

}

disabled={

hideTitle ||

!editMode ||

embeddable.getOutput().defaultDescription === panelDescription

}

AbrarAlHasan · 2023-06-12T16:23:22Z

I apologize for the misunderstanding. Thank you for clarifying the intended behavior of the reset button. I will make the necessary changes to ensure that it only resets to the default title and functions as intended with panels linked to library items.I will incorporate these changes into the code to align with the intended behavior.

ThomThomson · 2023-06-12T16:40:12Z

buildkite test this

ThomThomson · 2023-06-12T18:53:47Z

buildkite test this

kibana-ci · 2023-06-12T19:59:55Z

💚 Build Succeeded

Buildkite Build
Commit: e09f8f7

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`embeddable`	75.9KB	75.9KB	+70.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	491	495	+4
total			+6

History

💚 Build #134479 succeeded 3eb79f3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson · 2023-06-12T20:01:39Z

@elasticmachine run elasticsearch-ci/docs

* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...

dashboard Reset button disable

dacdb44

AbrarAlHasan requested a review from a team as a code owner June 10, 2023 06:17

kibanamachine added the 💝community label Jun 10, 2023

botelastic bot added the Feature:Embedding Embedding content via iFrame label Jun 10, 2023

Merge branch 'main' into issue_159422

18cffa9

ThomThomson requested changes Jun 12, 2023

View reviewed changes

Fix reset button behavior based on feedback

3eb79f3

ThomThomson approved these changes Jun 12, 2023

View reviewed changes

Merge branch 'main' into issue_159422

e09f8f7

ThomThomson merged commit 1349d0a into elastic:main Jun 12, 2023

kibanamachine added v8.9.0 backport:skip This PR does not require backporting labels Jun 12, 2023

Conversation

AbrarAlHasan commented Jun 10, 2023 • edited by ThomThomson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

For maintainers

Uh oh!

kibanamachine commented Jun 10, 2023

Uh oh!

cla-checker-service bot commented Jun 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThomThomson commented Jun 12, 2023

Uh oh!

AbrarAlHasan commented Jun 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 12, 2023

Uh oh!

ThomThomson commented Jun 12, 2023

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

ThomThomson Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

ThomThomson Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

ThomThomson Jun 12, 2023

Choose a reason for hiding this comment

Uh oh!

AbrarAlHasan commented Jun 12, 2023

Uh oh!

ThomThomson commented Jun 12, 2023

Uh oh!

ThomThomson commented Jun 12, 2023

Uh oh!

kibana-ci commented Jun 12, 2023

💚 Build Succeeded

Metrics [docs]

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

ThomThomson commented Jun 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AbrarAlHasan commented Jun 10, 2023 •

edited by ThomThomson

Loading

cla-checker-service bot commented Jun 10, 2023 •

edited

Loading

AbrarAlHasan commented Jun 12, 2023 •

edited

Loading