[Uptime] Hide app if no data is available by shahzad31 · Pull Request #159118 · elastic/kibana

shahzad31 · 2023-06-06T12:56:00Z

Summary

Hide app if no data is available !!

Uptime app will be hidden if no data is found within last week !!

This behaviour can be disabled from advanced settings

Release note

The Uptime app now gets hidden from the interface when it doesn't have any data for more than a week. If you have a standalone Heartbeat pushing data to Elasticsearch, the Uptime app will be considered active. You can disable this automatic behavior from the advanced settings in Kibana using the Always show legacy Uptime app option.
For synthetic monitoring, we now recommend to use the new Synthetics app.

ghost · 2023-06-06T12:56:16Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-06-08T08:47:00Z

Pinging @elastic/uptime (Team:uptime)

x-pack/plugins/observability/server/ui_settings.ts

afharo

Core changes LGTM

florent-leborgne

Suggested some tweaks to the copy. Let me know if you need me to revisit.

x-pack/plugins/observability/server/ui_settings.ts

Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

x-pack/plugins/observability/server/ui_settings.ts

awahab07

Tested and the feature flag works as expected.
If heartbeat-*/synthetics-* exists, Uptime app will be enabled.
👉 The current implementation will enable the Uptime app regardless of the availability of legacy monitors, as it just checks the presence of the index.
👉 On a new cluster, by default, Uptime has synthetics-* as index in settings, whereas heartbeat pushes to heartbeat-*. If a mismatch happens, the only way to enabled Uptime app would be via feature flag first and then a change of index in Uptime -> settings would be required.

x-pack/plugins/synthetics/server/legacy_uptime/lib/requests/get_index_status.ts

x-pack/plugins/observability/server/ui_settings.ts

…time

…o hide-uptime

x-pack/plugins/observability_shared/public/plugin.ts

fkanout

AO changes LGTM

…o hide-uptime

kibana-ci · 2023-06-12T16:15:21Z

💚 Build Succeeded

Buildkite Build
Commit: dc023fb

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`synthetics`	1249	1252	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`observability`	507	515	+8

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`observability`	43	45	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	1.2MB	1.2MB	-20.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observability`	97.3KB	97.5KB	+130.0B
`observabilityShared`	41.5KB	41.6KB	+58.0B
`synthetics`	28.4KB	29.1KB	+790.0B
total			+978.0B

Unknown metric groups

API count

id	before	after	diff
`observability`	515	523	+8

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	491	495	+4
total			+6

History

💔 Build #134293 failed bf4ba5b
💔 Build #134272 failed 1a5b56f
💔 Build #134230 failed 1b00e72
💚 Build #133749 succeeded 23f38b3
💔 Build #133706 failed f9d50b1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

awahab07

There's still an issue that, by default Uptime uses synthetics-* index, same as with Synthetics. So on a new cluster, if there are synthetics monitors with results indexed, Uptime would be enabled as in the query config_id is not being considered, as suggested in the AC.

awahab07

Tested the flow and it LGTM!

* main: [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334)

* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...

paulb-elastic · 2023-06-27T15:23:15Z

@florent-leborgne are you happy with the Release Note section in the main description

florent-leborgne · 2023-06-27T15:37:31Z

@paulb-elastic here's a slightly updated version with a more conversational tone.

The Uptime app now gets hidden from the interface when it doesn't have any data for more than a week. If you have a standalone heartbeat pushing data to Elasticsearch, the Uptime app will be considered active. You can disable this automatic behavior from the advanced settings in Kibana using the Always show legacy Uptime app option.
For synthetic monitoring, we now recommend to use the new Synthetics app.

How does this sound to you? Feel free to make any adjustment. I've also fixed the option name that was changed in this PR.

paulb-elastic · 2023-06-28T13:58:36Z

Thanks @florent-leborgne I've updated the copy in the description to your suggestion.

Looks like the release note for 8.9 hasn't been cut yet, so this update should be automatic, but I'll keep an eye on it in case I need to update the CHANGELOG manually.

paulb-elastic · 2023-07-20T19:09:57Z

Confirmed the updated copy will be used https://github.com/elastic/kibana/pull/161909/files#diff-6eabb97e98640429cb68b61823f99438d287d604d72ecf0e93ed2e9ecbec7479R70-R71

shahzad31 marked this pull request as ready for review June 8, 2023 08:42

shahzad31 requested review from a team as code owners June 8, 2023 08:42

shahzad31 requested a review from a team June 8, 2023 08:42

shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 release_note:deprecation release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes release_note:deprecation labels Jun 8, 2023

hide uptime if no data available

56b06e6

shahzad31 force-pushed the hide-uptime branch from 7a98d2e to 56b06e6 Compare June 8, 2023 08:46

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 8, 2023

shahzad31 commented Jun 8, 2023

View reviewed changes

x-pack/plugins/observability/server/ui_settings.ts Outdated Show resolved Hide resolved

Update x-pack/plugins/observability/server/ui_settings.ts

bc194e6

shahzad31 requested a review from florent-leborgne June 8, 2023 08:48

afharo approved these changes Jun 8, 2023

View reviewed changes

florent-leborgne reviewed Jun 8, 2023

View reviewed changes

x-pack/plugins/observability/server/ui_settings.ts Outdated Show resolved Hide resolved

x-pack/plugins/observability/server/ui_settings.ts Outdated Show resolved Hide resolved

shahzad31 and others added 4 commits June 8, 2023 12:05

Merge branch 'main' into hide-uptime

b145dbc

Merge branch 'main' into hide-uptime

05dce87

Update x-pack/plugins/observability/server/ui_settings.ts

8e91e3e

Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

Update x-pack/plugins/observability/server/ui_settings.ts

4aac78f

Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

shahzad31 commented Jun 8, 2023

View reviewed changes

x-pack/plugins/observability/server/ui_settings.ts Outdated Show resolved Hide resolved

shahzad31 added 2 commits June 8, 2023 15:48

Update x-pack/plugins/observability/server/ui_settings.ts

f9d50b1

Merge branch 'main' into hide-uptime

23f38b3

awahab07 reviewed Jun 8, 2023

View reviewed changes

x-pack/plugins/synthetics/server/legacy_uptime/lib/requests/get_index_status.ts Show resolved Hide resolved

x-pack/plugins/observability/server/ui_settings.ts Show resolved Hide resolved

shahzad31 added 4 commits June 11, 2023 16:57

Merge branch 'main' of https://github.com/elastic/kibana into hide-up…

84f707b

…time

PR feedback

d1565a8

Merge branch 'main' of https://github.com/elastic/kibana into hide-up…

8045494

…time

Merge branch 'hide-uptime' of https://github.com/shahzad31/kibana int…

1b00e72

…o hide-uptime

shahzad31 requested a review from awahab07 June 12, 2023 08:23

update test

1a5b56f

fkanout reviewed Jun 12, 2023

View reviewed changes

x-pack/plugins/observability_shared/public/plugin.ts Show resolved Hide resolved

shahzad31 added 2 commits June 12, 2023 13:03

Merge branch 'main' into hide-uptime

bf4ba5b

update test

5be92c1

fkanout approved these changes Jun 12, 2023

View reviewed changes

shahzad31 added 2 commits June 12, 2023 17:07

Merge branch 'main' into hide-uptime

0f4fca0

Merge branch 'hide-uptime' of https://github.com/shahzad31/kibana int…

dc023fb

…o hide-uptime

awahab07 reviewed Jun 12, 2023

View reviewed changes

awahab07 approved these changes Jun 13, 2023

View reviewed changes

shahzad31 merged commit ea77b0d into elastic:main Jun 13, 2023

shahzad31 deleted the hide-uptime branch June 13, 2023 10:14

kibanamachine added the backport:skip This PR does not require backporting label Jun 13, 2023

Conversation

shahzad31 commented Jun 6, 2023 • edited by paulb-elastic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release note

Uh oh!

ghost commented Jun 6, 2023

🤖 GitHub comments

Uh oh!

elasticmachine commented Jun 8, 2023

Uh oh!

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

florent-leborgne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

awahab07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fkanout left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jun 12, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

awahab07 left a comment

Choose a reason for hiding this comment

Uh oh!

awahab07 left a comment

Choose a reason for hiding this comment

Uh oh!

paulb-elastic commented Jun 27, 2023

Uh oh!

florent-leborgne commented Jun 27, 2023

Uh oh!

paulb-elastic commented Jun 28, 2023

Uh oh!

paulb-elastic commented Jul 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

shahzad31 commented Jun 6, 2023 •

edited by paulb-elastic

Loading