[APM] Add feature flag for not available apm schema#158911
[APM] Add feature flag for not available apm schema#158911MiriamAparicio merged 6 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
| function throwNotFoundIfApmSchemaNotAvailable( | ||
| featureFlags: ApmFeatureFlags | ||
| ): void { | ||
| if (!featureFlags.schemaAvailable) { |
There was a problem hiding this comment.
I was never fond of the name "schemaAvailable". It seems so vague.
@ogupte Isn't this about fleet migration? Could we call this featureFlags.isFleetMigrationAvailable?
There was a problem hiding this comment.
If so, should we also block the other request in x-pack/plugins/apm/server/routes/fleet/route.ts?
@sqren @ogupte
There was a problem hiding this comment.
I think we also want to restrict access to POST /internal/apm/fleet/cloud_apm_package_policy if that's the one you mean?
There was a problem hiding this comment.
The MigrationToFleetAvailable already exist, should I use this one in this case? I will use the schema for the UI tab then, what do you think?
There was a problem hiding this comment.
The feature in question is the fleet migration page in settings, which has the title APM Schema (not sure why exactly). i agree that it should use one feature flag like showFleetMigration or something. There's already already a config that exists to enable it but it doesn't hide it from the UI.
There was a problem hiding this comment.
My mistake I just saw that this already exist
I'll revert the commit
efb1bed to
974f05e
Compare
…ration" This reverts commit 87d15bf.
974f05e to
15e2984
Compare
9da0033 to
0f4d872
Compare
There was a problem hiding this comment.
should we give the same check (throwNotFoundIfApmSchemaNotAvailable) in GET /internal/apm/fleet/migration_check? It's an API that's call from 2 places:
- the settings page which is hidden in this PR
- also the tutorial (https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/public/tutorial/tutorial_fleet_instructions/index.tsx#L52) where it switches an href link between the above settings page (now hidden) or the APM integration page (not available in serverless)
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
* main: (199 commits) [Lens] Add custom formatter within the Lens editor (elastic#158468) [Uptime] Hide app if no data is available (elastic#159118) [CodeEditor] Add grok highlighting (elastic#159334) Expose decoded cloudId components from the cloud plugin's contract (elastic#159442) [Profiling] Use collector and symbolizer integrations in the add data page (elastic#159481) [Infrastructure UI] Hosts View: Unified Search bar with auto-refresh enabled (elastic#157011) [APM] Add feature flag for not available apm schema (elastic#158911) [Lens] Remove deprecated componentWillReceiveProps usage (elastic#159502) [api-docs] 2023-06-13 Daily api_docs build (elastic#159536) [data views] Use versioned router for REST routes (elastic#158608) [maps] fix geo line source not loaded unless maps application is opened (elastic#159432) [Enterprise Search][Search application]Fix Create Api key url (elastic#159519) [Security Solution] Increase timeout for indexing hosts (elastic#159518) dashboard Reset button disable (elastic#159430) [Security Solution] Unskip Endpoint API tests after package fix (elastic#159484) [Synthetics] adjust alert timing (elastic#159511) [ResponseOps][rule registry] Remove usages of `refresh: true` (elastic#159252) Revert "Remove unused package (elastic#158597)" [Serverless] Adding config to disable authentication on task manager background worker utilization API (elastic#159505) Remove unused package (elastic#158597) ...
Part of #153776
How to test: