Conversation
Contributor
Author
|
Two questions for reviewers: 1. Should we backport this farther back than 7.17 (maybe as far back as 7.13?) EDIT: it looks like the Buildkite PR pipeline was first introduced in 7.14 (#112029), so I think we can backport this PR that far back. kibana/.buildkite/pull_requests.json Lines 34 to 37 in afb1889 2. Should I change this to always require CI on |
.dev_docs or .mdx files are changeddev_docs or .mdx files are changed
Contributor
|
Changes to this file are effectively applied to all branches, so it doesn't need to be backported at all. |
mistic
approved these changes
May 30, 2022
Contributor
|
@jportner regarding your question 2, |
jbudz
added a commit
that referenced
this pull request
Oct 17, 2024
Currently CI is not run on pull requests with `dev_docs` only changes. This was implemented in #133087, where at the time we were not running any validation. Validation was later added in #149991, but the skip criteria was not updated. This removes the skip criteria, allowing our validation checks to run on all `dev_docs` changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that CI appears to be broken on the 8.0 branch which is preventing #132944 from merging.
However, that PR contains only docs changes and it shouldn't be triggering the
kibana-ciactions anyway.I updated the Buildkite config to skip CI when dev docs and/or MDX files are changed.
Note that this config was changed recently (in #132461), so backports for this PR will run into merge conflicts and will need to be manually fixed.