[Buildkite] Pull Request pipeline#112029
Merged
brianseeders merged 5 commits intoelastic:masterfrom Oct 1, 2021
Merged
Conversation
fd6704c to
9c8d289
Compare
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
reviewed
Oct 1, 2021
tylersmalley
reviewed
Oct 1, 2021
tylersmalley
reviewed
Oct 1, 2021
tylersmalley
approved these changes
Oct 1, 2021
Member
tylersmalley
left a comment
There was a problem hiding this comment.
LGTM - the uptime Playwright changes were just merged, but that could come as a follow-up since we're not fully switching over with this PR.
https://github.com/elastic/kibana/blob/master/vars/tasks.groovy#L158-L164
jbudz
reviewed
Oct 1, 2021
|
|
||
| cd "$XPACK_DIR" | ||
|
|
||
| checks-reporter-with-killswitch "APM Cypress Tests" \ |
Contributor
There was a problem hiding this comment.
Maybe depends on #113664?
edit: nevermind, found the thread above. Leaving the note here in case there's a timing issue when this gets merged
Contributor
💚 Build Succeeded
History
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2021
Contributor
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2021
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2021
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip-ci]
Implement the remaining items to enable pull request pipelines in Buildkite. A lot of work was done elsewhere, e.g. in https://github.com/elastic/kibana-buildkite-build-bot for PR comments.
This PR does not enable PR comments for all PRs or disable PRs in Jenkins. However, it does allow PRs to opt-in to Buildkite PRs (like this one!) by:
[skip-ci]to the description, to make Jenkins not run CIbuildkite-cilabelAt that point, the PR will function as normal, except that it will run in Buildkite.
See here for an example of a build with failures: https://buildkite.com/elastic/kibana-pull-request/builds/58