[APM] fixing e2e tests and re-enabling it#113664
Closed
cauemarcondes wants to merge 3 commits intoelastic:masterfrom
Closed
[APM] fixing e2e tests and re-enabling it#113664cauemarcondes wants to merge 3 commits intoelastic:masterfrom
cauemarcondes wants to merge 3 commits intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.src/plugins/telemetry/public/services.TelemetryService setOptIn calls reportOptInStatus if reportOptInStatusChange is trueStandard OutStack TraceKibana Pipeline / general / X-Pack Example plugin functional tests.x-pack/test/examples/embedded_lens/embedded_example·ts.embedded Lens examples show and save "before each" hook for "should show chart"Standard OutStack TraceMetrics [docs]
To update your PR or re-run it, just comment with: |
spalger
approved these changes
Oct 4, 2021
Contributor
spalger
left a comment
There was a problem hiding this comment.
Operations related changes LGTM
smith
approved these changes
Oct 4, 2021
pgayvallet
reviewed
Oct 5, 2021
Comment on lines
+75
to
+77
| if (this.isAlreadyAborted()) { | ||
| return this.responseToolkit.close; | ||
| } |
Contributor
There was a problem hiding this comment.
@mshustov If I understand correctly, this is fixing a significant bug, isn't it? Should we also add an integration test to cover the fix?
Contributor
There was a problem hiding this comment.
This change doesn't fix the problem, unfortunately. A fix should be done on the Hapi level. See hapijs/hapi#4294 for a detailed description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.