[CI] Move PR skippable changes to pr-bot config#132461
Merged
brianseeders merged 1 commit intoelastic:mainfrom May 18, 2022
Merged
[CI] Move PR skippable changes to pr-bot config#132461brianseeders merged 1 commit intoelastic:mainfrom
brianseeders merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
May 18, 2022
spalger
approved these changes
May 18, 2022
Contributor
spalger
left a comment
There was a problem hiding this comment.
I really with that JSON files could have comments, or that there was built in support for a better syntax... but either way these specific changes LGTM
Contributor
Author
Yeah... I think I'm going to move it to json5 soon so we can have comments |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for skippable changes was just added to the PR bot, so I'm moving these regexes to the PR config.
The main benefit is that for skippable PRs, buildkite won't be triggered at all, and the bot will set the
kibana-cicommit check tosuccess, which fixes issues we've had with docs changes for old branches.