[Uptime] Remove latency warnings on monitor management UI#129597
Merged
lucasfcosta merged 1 commit intoelastic:mainfrom Apr 13, 2022
Merged
[Uptime] Remove latency warnings on monitor management UI#129597lucasfcosta merged 1 commit intoelastic:mainfrom
lucasfcosta merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
9 tasks
de85161 to
d22e81a
Compare
d22e81a to
179997e
Compare
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
shahzad31
approved these changes
Apr 12, 2022
Contributor
shahzad31
left a comment
There was a problem hiding this comment.
LGTM, Works as expcted !!
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 13, 2022
…disable-server-side * 'main' of github.com:elastic/kibana: (35 commits) [Uptime] remove latency limit warnings when using monitor management (elastic#129597) [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992) Paramaterized Discover tests (elastic#129684) [Security Solution][Investigations] - Minor bug fixes (elastic#130054) [DOCS} Adds technical preview to Lens annotations (elastic#130058) [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773) [Security Solutions] Adds API docs for value lists (elastic#129962) [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051) [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042) Upgrade RxJS to 7 (elastic#129087) [SecuritySolution] Clean up CaseContext (elastic#130036) Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)" Use RuleDataReader to query for threshold signal history (elastic#129763) Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769) Upgrade EUI to v54.0.0 (elastic#129653) [Security Solution] More Ransomware exceptionable fields (elastic#130039) Add e2e for the apm integration policy form (elastic#129860) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021) [ML] Fix Single Metric Viewer chart failing to load if no points during calendar event (elastic#130000) ... # Conflicts: # x-pack/plugins/screenshotting/server/screenshots/index.test.ts
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 13, 2022
…rint-media-attempt-2 * 'main' of github.com:elastic/kibana: (75 commits) [Lens] Hide disabled toolbar entries (elastic#129994) Fix explore tables don't display data when a global filter is applied (elastic#130024) [Console] Add option to disable keyboard shortcuts (elastic#128887) [Discover] Update refreshOnClick flaky test (elastic#130001) [Uptime] remove latency limit warnings when using monitor management (elastic#129597) [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992) Paramaterized Discover tests (elastic#129684) [Security Solution][Investigations] - Minor bug fixes (elastic#130054) [DOCS} Adds technical preview to Lens annotations (elastic#130058) [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773) [Security Solutions] Adds API docs for value lists (elastic#129962) [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051) [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042) Upgrade RxJS to 7 (elastic#129087) [SecuritySolution] Clean up CaseContext (elastic#130036) Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)" Use RuleDataReader to query for threshold signal history (elastic#129763) Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769) Upgrade EUI to v54.0.0 (elastic#129653) ... # Conflicts: # x-pack/plugins/screenshotting/server/formats/pdf/index.ts
kibanamachine
added a commit
that referenced
this pull request
Apr 13, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR removes the latency warnings one would get when exceeding the minimum latency in the monitor management UI.
It complements the work we had previously done for https://github.com/elastic/synthetics-service/issues/324. It also adds work on top of #127961.
In the previous cloud/synthetics meeting we have decided we would scrape these warnings because latency doesn't actually impact the platform's usage so we don't need to apply a minimum.
PS: I've added this PR to the board so that we can be sure we have done Post-FF testing on it, not only on the first one. I've also updated the previous PR with a link to this one to be sure people will be testing the right thing.
Given we're removing functionality that shouldn't be there, I've also added the
buglabel to this.How to test this PR Locally
manifest.jsonwith the following content and place it under a folder named, for example,manifest_folder.{ "throttling": { "downloadBandwidthLimit": 20, "uploadBandwidthLimit": 10 }, "locations": { "Local Synth Node [MANIFEST]": { "url": "https://localhost:10001", "geo": { "name": "Example - Local", "location": {"lat": 41.25, "lon": -95.86} }, "status": "beta" } } }manifest_foldermanifest.jsonfile.You should be able to set latency values to any value and shouldn't see a warning.
Checklist
Delete any items that are not applicable to this PR.
For maintainers