[Synthetics Service] Add warnings for when service nodes bandwidth is exceeded#127961
Conversation
|
Pinging @elastic/uptime (Team:uptime) |
|
Added @liciavale / @drewpost as specific reviewers |
|
I understand the max values are the limit, so the copy should probably read something like When exceeded, maybe the copy should include something about Also, I think we’re letting users continue to save the configuration anyway, I assume we have no distinction in the UI, and this shows as a validation failure? |
16dd7e9 to
dc76a75
Compare
|
Hey Paul, thanks for jumping in on this. Wrt to your comments:
That's an excellent point, will update.
I really like your suggestion of:
That is correct. We have no distinction in the UI. I could only use the validation error message or a callout or another element. There isn't a specific warning prop on the form elements for this. We do still allow users to save when they see these warning messages. |
5f20a56 to
7a751a5
Compare
|
@elasticmachine merge upstream |
ddfe0f1 to
d5ba2e7
Compare
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
i wonder if this can be set to a constant, seems like these three lines are repeated in many places
something like DEFAULT_THROTTLING
There was a problem hiding this comment.
basically reuse this in bunch of places...
There was a problem hiding this comment.
basically reuse this in bunch of places...
dominiqueclarke
left a comment
There was a problem hiding this comment.
Looks great! Just one comment.
There was a problem hiding this comment.
It may make sense to determine whether or not this is the service flow in some other way. With this logic, the warnings will only appear if location has already been set. While it is likely that the user will choose a location first, I think these warnings should still appear even when they do not.
We could add a runsOnService boolean directly to the PolicyConfigContext that is only defined within the UIMonitorManagement workflow.
|
This looks good for beta. We can wordsmith it and tweak it a bit if needed in synthetics app but I'd say this is good to go for now! |
9cb9b0d to
b8edcc5
Compare
|
@elasticmachine merge upstream |
43041b1 to
5d29c42
Compare
5d29c42 to
9c1eecb
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |

Summary
This PR addresses the Synthetics Service issue about network bandwidth limits. I can't link it here as it's on a non-public repo.
It does so by adding warnings for when the user exceeds throttling limits, or does not enable throttling when assigning monitors to a location.
How to test this PR Locally
manifest.jsonwith the following content and place it under a folder named, for example,manifest_folder.{ "throttling": { "downloadBandwidthLimit": 20, "uploadBandwidthLimit": 10, "latencyLimit": 5000 }, "locations": { "Local Synth Node [MANIFEST]": { "url": "https://localhost:10001", "geo": { "name": "Example - Local", "location": {"lat": 41.25, "lon": -95.86} }, "status": "beta" } } }manifest_foldermanifest.jsonfile.Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release note
Show warning when users exceed a Synthetics Node throttling limits.