[Security solution] [Endpoint] Revisit blocklist wrong labels by dasansol92 · Pull Request #128773 · elastic/kibana

dasansol92 · 2022-03-29T15:20:14Z

Summary

Downgrade experience banner:
Empty page:
It also fixes i18n keys for blocklist

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2022-03-29T15:20:16Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

joepeeples

I gave this a quick review on behalf of @elastic/kibana-docs, since it involved Elastic Security. I added a couple of suggested edits, thanks!

joepeeples · 2022-04-06T14:03:32Z

x-pack/plugins/security_solution/public/management/pages/blocklist/view/blocklist.tsx

+  }),
+  emptyStateInfo: i18n.translate('xpack.securitySolution.blocklist.emptyStateInfo', {
+    defaultMessage:
+      'The blocklist prevents selected applications from running on your hosts by extending the list of processes the Endpoint considers malicious.',


Possible tweaks for flow and consistency, from feature sync discussion with @kevinlog, @caitlinbetz, @jmikell821:

Suggested change

'The blocklist prevents selected applications from running on your hosts by extending the list of processes the Endpoint considers malicious.',

'The blocklist prevents specified applications from running on your hosts, extending the list of processes that Endpoint Security considers malicious.',

joepeeples · 2022-04-06T14:08:50Z

x-pack/plugins/security_solution/public/management/pages/blocklist/view/blocklist.tsx

+        <FormattedMessage
+          id="xpack.securitySolution.blocklist.flyoutDowngradedLicenseDocsInfo"
+          defaultMessage="For more information, see our "
+        />
+        <EuiLink target="_blank" href={`${securitySolutionDocsLinks.blocklist}`}>
+          <FormattedMessage
+            id="xpack.securitySolution.blocklist.flyoutDowngradedLicenseDocsLink"
+            defaultMessage="Blocklist documentation"
+          />


In the screenshot above, there's a period missing at the end of this sentence, and "blocklist documentation" should probably be lowercase since the feature isn't a proper name.

"For more information, see our blocklist documentation."

gchaps

doclink LGTM

…-revisit_blocklist_list_labels-3237

kibana-ci · 2022-04-12T13:37:13Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #9 / maps app auto fit map to bounds initial location should automatically fit to bounds on initial map load

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.8MB	4.8MB	+703.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	319.1KB	319.1KB	+54.0B

History

💛 Build #35798 was flaky 00984d4
💛 Build #35121 was flaky 581bcd7
💛 Build #34794 was flaky 35b0b81
💚 Build #34540 succeeded 17d07ec

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kevinlog

kevinlog · 2022-04-12T21:43:35Z

@elasticmachine run elasticsearch-ci/docs

* Fixes wrong text for downgrade license docs link on blocklist. * Fixes license downgraded banner for blocklist including the docs link * Updates i18n keys for blocklist to be singular * Removes unused param name Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com> Co-authored-by: kevinlog <kevin.logan@elastic.co> (cherry picked from commit 935bac7)

kibanamachine · 2022-04-12T22:08:37Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

… (#130063) * Fixes wrong text for downgrade license docs link on blocklist. * Fixes license downgraded banner for blocklist including the docs link * Updates i18n keys for blocklist to be singular * Removes unused param name Co-authored-by: Ashokaditya <1849116+ashokaditya@users.noreply.github.com> Co-authored-by: kevinlog <kevin.logan@elastic.co> (cherry picked from commit 935bac7) Co-authored-by: David Sánchez <david.sanchezsoler@elastic.co>

…disable-server-side * 'main' of github.com:elastic/kibana: (35 commits) [Uptime] remove latency limit warnings when using monitor management (elastic#129597) [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992) Paramaterized Discover tests (elastic#129684) [Security Solution][Investigations] - Minor bug fixes (elastic#130054) [DOCS} Adds technical preview to Lens annotations (elastic#130058) [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773) [Security Solutions] Adds API docs for value lists (elastic#129962) [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051) [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042) Upgrade RxJS to 7 (elastic#129087) [SecuritySolution] Clean up CaseContext (elastic#130036) Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)" Use RuleDataReader to query for threshold signal history (elastic#129763) Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769) Upgrade EUI to v54.0.0 (elastic#129653) [Security Solution] More Ransomware exceptionable fields (elastic#130039) Add e2e for the apm integration policy form (elastic#129860) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021) [ML] Fix Single Metric Viewer chart failing to load if no points during calendar event (elastic#130000) ... # Conflicts: # x-pack/plugins/screenshotting/server/screenshots/index.test.ts

…rint-media-attempt-2 * 'main' of github.com:elastic/kibana: (75 commits) [Lens] Hide disabled toolbar entries (elastic#129994) Fix explore tables don't display data when a global filter is applied (elastic#130024) [Console] Add option to disable keyboard shortcuts (elastic#128887) [Discover] Update refreshOnClick flaky test (elastic#130001) [Uptime] remove latency limit warnings when using monitor management (elastic#129597) [Security Solution] [ReponseOps] Executes Cases Cypress test when there is a change on cases plugin (elastic#129992) Paramaterized Discover tests (elastic#129684) [Security Solution][Investigations] - Minor bug fixes (elastic#130054) [DOCS} Adds technical preview to Lens annotations (elastic#130058) [Security solution] [Endpoint] Revisit blocklist wrong labels (elastic#128773) [Security Solutions] Adds API docs for value lists (elastic#129962) [CI] Move jest tests to spot instances, and fix spot retries in PRs (elastic#130045) chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130051) [SecuritySolution] Remove the cell hovers actions for agent status (elastic#130042) Upgrade RxJS to 7 (elastic#129087) [SecuritySolution] Clean up CaseContext (elastic#130036) Revert "chore(NA): upgrades rules_node_js to v5.4.0 (elastic#130021)" Use RuleDataReader to query for threshold signal history (elastic#129763) Remove securityRulesCancelEnabled setting and set shorter default timeouts (elastic#129769) Upgrade EUI to v54.0.0 (elastic#129653) ... # Conflicts: # x-pack/plugins/screenshotting/server/formats/pdf/index.ts

dasansol92 added 2 commits March 29, 2022 12:22

Fixes wrong text for downgrade license docs link on blocklist.

590b6fe

Fixes license downgraded banner for blocklist including the docs link

26230cb

dasansol92 added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Mar 29, 2022

dasansol92 requested review from a team as code owners March 29, 2022 15:20

dasansol92 requested review from parkiino and pzl March 29, 2022 15:20

dasansol92 marked this pull request as draft March 29, 2022 15:24

dasansol92 added 3 commits March 29, 2022 17:30

Updates i18n keys for blocklist to be singular

035df8f

Removes unused param name

17d07ec

Merge branch 'main' into fix/olm-revisit_blocklist_list_labels-3237

35b0b81

dasansol92 marked this pull request as ready for review March 30, 2022 13:12

dasansol92 mentioned this pull request Mar 30, 2022

[Security Solution] The warning message for Blocklist on Basic license needs to be updated. #128717

Closed

Merge branch 'main' into fix/olm-revisit_blocklist_list_labels-3237

581bcd7

joepeeples self-requested a review March 31, 2022 21:20

dasansol92 mentioned this pull request Apr 1, 2022

[Security Solution] The description for Blocklist is different on different pages #129174

Closed

kevinlog self-assigned this Apr 1, 2022

Merge branch 'main' into fix/olm-revisit_blocklist_list_labels-3237

00984d4

ashokaditya approved these changes Apr 4, 2022

View reviewed changes

parkiino approved these changes Apr 4, 2022

View reviewed changes

joepeeples reviewed Apr 6, 2022

View reviewed changes

pzl approved these changes Apr 6, 2022

View reviewed changes

This was referenced Apr 6, 2022

[DOCS] Blocklist follow-up elastic/security-docs#1818

Closed

[DOCS] Blocklist elastic/security-docs#1811

Merged

gchaps approved these changes Apr 7, 2022

View reviewed changes

Merge branch 'main' of https://github.com/elastic/kibana into fix/olm…

7f6fab5

…-revisit_blocklist_list_labels-3237

kevinlog added the v8.3.0 label Apr 12, 2022

kevinlog merged commit 935bac7 into elastic:main Apr 12, 2022

kibanamachine mentioned this pull request Apr 12, 2022

[8.2] [Security solution] [Endpoint] Revisit blocklist wrong labels (#128773) #130063

Merged

dasansol92 mentioned this pull request Apr 19, 2022

[Security Solution] [Endpoint] Update blocklist flyout license banner copy #130561

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security solution] [Endpoint] Revisit blocklist wrong labels#128773

[Security solution] [Endpoint] Revisit blocklist wrong labels#128773
kevinlog merged 8 commits intoelastic:mainfrom
dasansol92:fix/olm-revisit_blocklist_list_labels-3237

dasansol92 commented Mar 29, 2022 •

edited

Loading

Uh oh!

elasticmachine commented Mar 29, 2022

Uh oh!

joepeeples left a comment

Uh oh!

joepeeples Apr 6, 2022 •

edited

Loading

Uh oh!

joepeeples Apr 6, 2022

Uh oh!

gchaps left a comment

Uh oh!

kibana-ci commented Apr 12, 2022

Uh oh!

kevinlog commented Apr 12, 2022

Uh oh!

kibanamachine commented Apr 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

	'The blocklist prevents selected applications from running on your hosts by extending the list of processes the Endpoint considers malicious.',
	'The blocklist prevents specified applications from running on your hosts, extending the list of processes that Endpoint Security considers malicious.',

Conversation

dasansol92 commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

For maintainers

Uh oh!

elasticmachine commented Mar 29, 2022

Uh oh!

joepeeples left a comment

Choose a reason for hiding this comment

Uh oh!

joepeeples Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joepeeples Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Apr 12, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

kevinlog commented Apr 12, 2022

Uh oh!

kibanamachine commented Apr 12, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

dasansol92 commented Mar 29, 2022 •

edited

Loading

joepeeples Apr 6, 2022 •

edited

Loading