Bumping EUI to 38.0.1 by 1Copenut · Pull Request #112462 · elastic/kibana

1Copenut · 2021-09-16T18:36:01Z

Summary

eui@37.6.0 ⏩ eui@38.0.1

`38.0.1`

Reverts

Reverted EuiScreenReaderOnly left positioning change due to Selenium issues (#5215)

`38.0.0`

Added optional line numbers to EuiCodeBlock (#4993)
Removed emoticon support and removed rendered <div> from EuiMarkdownFormat (#5176)
Moved EuiCheckbox and EuiRadio inputs to always float inline on top of the faux inputs (#5152)

Bug fixes

Fixed EuiDataGrid stripes not alternating as expected on sort/pagination (#5070)

Breaking changes

Upgraded TypeScript version to ~4.1.3 (#5182)
Added clip property to EuiScreenReaderOnly, to fix positioning issues within scrolling containers (#5152)

`37.7.0`

Added placeholder prop to EuiMarkdownEditor (#5151)
Added .eui-textNumber utility class to apply tnum font-feature setting (#5078)
Changed EuiPageHeader's tab implementation to use size xl when only content (#5135)
Added pageTitleProps prop to EuiPageHeader to pass through props to the EuiTitle (#5135)
Added screen-reader only <h1> to EuiPageHeader when tabs exist without a pageTitle (#5135)
Added bottomBorder prop and xl size to EuiTabs (#5135)
Added prepend and append props to EuiTab (#5135)
Refactored styles of EuiTabs (#5135)
Removed Sass variables for EuiTabs font size ($euiTabFontSize, $euiTabFontSizeS, $euiTabFontSizeL) (#5135)
Extended all EuiTabProps for each EuiTabbedContentTab (#5135)
Changed EuiPopover's repositionOnScroll function to prevent popover and input elements from separating on scroll when nested in EuiFlyout (#5155)
Added the repositionOnScroll prop to EuiSuperSelect (#5155)
Added useGeneratedHtmlId utility, which memoizes the randomly generated ID on mount and prevents regenerated IDs on component rerender (#5133)
Fixed z-index styles that were causing parts of EuiResizableContainer to overlap EuiHeader (#5164)

Bug fixes

Fixed [de]optimization bug in EuiDataGrid when cells are removed from the DOM via virtualization (#5163)

Theme: Amsterdam

Deprecated display prop of EuiTabs in favor of unified styles and bottomBorder (#5135)

`37.6.2`

Reverts

Reverted EuiScreenReaderOnly clip property (#5150)

`37.6.1`

Bug fixes

[REVERTED in 37.6.2] Fixed EuiScreenReaderOnly positioning issues within scrolling containers (#5130)
Fixed EuiDataGrid cell actions not unmounting from the DOM after mouse interaction (#5120)
Optimized EuiDataGrid cell interactions' performance (#5136)

…tests.

1Copenut · 2021-09-23T22:36:33Z

test/functional/apps/dashboard/dashboard_clone.ts

      await retry.try(async () => {
        const panelTitles = await PageObjects.dashboard.getPanelTitles();
-        expect(panelTitles).to.eql(PageObjects.dashboard.getTestVisualizationNames());
+        const visiblePanelTitles = panelTitles.map((title) => title.split('\n')[1]);


@constancecchen I wrote a helper method called getVisiblePanelTitles() after I wrote this string split a second or third time. I think we can clean these up to use that method (assuming tests still pass) but I wanted to get to green before refactoring.

Just a hunch, but I think many these issues/functional failures will go away if we backport a fix to our EuiScreenReaderOnly change: elastic/eui#5215

* Reverted the SR-only class behavior to use `left: -10000px;` * Reverting tests to previous assertions

* package.json * package-lock.json * license-checker

elasticmachine · 2021-09-27T22:33:19Z

Pinging @elastic/eui-design (EUI)

spalger · 2021-09-27T22:45:38Z

@elasticmachine merge upstream

kibanamachine · 2021-09-28T00:52:59Z

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	593.1KB	596.7KB	+3.6KB
`kbnUiSharedDeps-npmDll`	5.1MB	5.1MB	+2.5KB
total			+6.1KB

History

💚 Build #155910 succeeded de71d55
💔 Build #155492 failed 789167a
💔 Build #155395 failed 344c697
💔 Build #155359 failed 8e96f81
💔 Build #155102 failed f8fd6ce

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

crob611

Presentation changes LGTM

* Bumping EUI to 38.0.0 * Updating storyshots.test.tsx snapshot * Removing unneeded ID mock and updating snapshot. * Fixing panel titles by splitting visible labels. * Updating one functional test for Discover > Data Grid * Fixing one test on a Lens > Smokescreen accessible label * Updating four tests to use visible labels only. * Adding helper function to retrieve visual text only and fixing three tests. * Dashboard > Panel Cloning all tests pass. * Fixing accessible label test * Fixing data_shared_attributes, two tests * Updating tests for Discover > Data Grid * Reverting tests ahead of EUI 38.0.1 backport * Reverted the SR-only class behavior to use `left: -10000px;` * Reverting tests to previous assertions * Bumping configuration files to EUI 38.0.1 * package.json * package-lock.json * license-checker Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-09-29T15:29:15Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Bumping EUI to 38.0.0 * Updating storyshots.test.tsx snapshot * Removing unneeded ID mock and updating snapshot. * Fixing panel titles by splitting visible labels. * Updating one functional test for Discover > Data Grid * Fixing one test on a Lens > Smokescreen accessible label * Updating four tests to use visible labels only. * Adding helper function to retrieve visual text only and fixing three tests. * Dashboard > Panel Cloning all tests pass. * Fixing accessible label test * Fixing data_shared_attributes, two tests * Updating tests for Discover > Data Grid * Reverting tests ahead of EUI 38.0.1 backport * Reverted the SR-only class behavior to use `left: -10000px;` * Reverting tests to previous assertions * Bumping configuration files to EUI 38.0.1 * package.json * package-lock.json * license-checker Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Trevor Pierce <1Copenut@users.noreply.github.com>

Bumping EUI to 38.0.0

9c33e96

1Copenut added auto-backport Deprecated - use backport:version if exact versions are needed EUI release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Sep 16, 2021

1Copenut added 4 commits September 16, 2021 16:09

Updating storyshots.test.tsx snapshot

1d2d476

Removing unneeded ID mock and updating snapshot.

fe3334a

Fixing panel titles by splitting visible labels.

8b8a9e1

Updating one functional test for Discover > Data Grid

b7d622a

qn895 mentioned this pull request Sep 21, 2021

[ML] Add Index data visualizer grid embeddable as extra view within Discover #107184

Merged

8 tasks

1Copenut added 8 commits September 21, 2021 12:26

Fixing one test on a Lens > Smokescreen accessible label

763502e

Updating four tests to use visible labels only.

3eaaefb

Adding helper function to retrieve visual text only and fixing three …

f8fd6ce

…tests.

Dashboard > Panel Cloning all tests pass.

79aa777

Fixing accessible label test

8e96f81

Merge branch 'master' into eui_38_0_0

344c697

Fixing data_shared_attributes, two tests

ecbda78

Updating tests for Discover > Data Grid

789167a

1Copenut commented Sep 23, 2021

View reviewed changes

This was referenced Sep 24, 2021

[EuiScreenReaderOnly] Revert left positioning change elastic/eui#5215

Merged

EUI 38.0.1 backport/patch release elastic/eui#5216

Closed

1Copenut added 2 commits September 27, 2021 14:37

Reverting tests ahead of EUI 38.0.1 backport

928b5f3

* Reverted the SR-only class behavior to use `left: -10000px;` * Reverting tests to previous assertions

Bumping configuration files to EUI 38.0.1

de71d55

* package.json * package-lock.json * license-checker

chandlerprall changed the title ~~Bumping EUI to 38.0.0~~ Bumping EUI to 38.0.1 Sep 27, 2021

1Copenut self-assigned this Sep 27, 2021

1Copenut marked this pull request as ready for review September 27, 2021 22:33

1Copenut requested review from a team as code owners September 27, 2021 22:33

Merge branch 'master' into eui_38_0_0

d97e003

spalger approved these changes Sep 27, 2021

View reviewed changes

pgayvallet approved these changes Sep 28, 2021

View reviewed changes

crob611 approved these changes Sep 29, 2021

View reviewed changes

1Copenut merged commit 7e0e8a4 into master Sep 29, 2021

kibanamachine mentioned this pull request Sep 29, 2021

[7.x] Bumping EUI to 38.0.1 (#112462) #113435

Merged

mshustov deleted the eui_38_0_0 branch September 29, 2021 19:40

stratoula mentioned this pull request Oct 5, 2021

[TSVB] Removes unused css #113751

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumping EUI to 38.0.1#112462

Bumping EUI to 38.0.1#112462
1Copenut merged 16 commits intomasterfrom
eui_38_0_0

1Copenut commented Sep 16, 2021 •

edited

Loading

Uh oh!

1Copenut Sep 23, 2021

Uh oh!

cee-chen Sep 27, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Sep 27, 2021

Uh oh!

spalger commented Sep 27, 2021

Uh oh!

kibanamachine commented Sep 28, 2021

Uh oh!

crob611 left a comment

Uh oh!

kibanamachine commented Sep 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

1Copenut commented Sep 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

38.0.1

38.0.0

37.7.0

37.6.2

37.6.1

Uh oh!

1Copenut Sep 23, 2021

Choose a reason for hiding this comment

Uh oh!

cee-chen Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 27, 2021

Uh oh!

spalger commented Sep 27, 2021

Uh oh!

kibanamachine commented Sep 28, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

History

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 29, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

1Copenut commented Sep 16, 2021 •

edited

Loading

`38.0.1`

`38.0.0`

`37.7.0`

`37.6.2`

`37.6.1`

cee-chen Sep 27, 2021 •

edited

Loading