[euiScreenReaderOnly] Revert #5130 - clip property addition#5150
Merged
cee-chen merged 2 commits intoelastic:masterfrom Sep 7, 2021
Merged
[euiScreenReaderOnly] Revert #5130 - clip property addition#5150cee-chen merged 2 commits intoelastic:masterfrom
cee-chen merged 2 commits intoelastic:masterfrom
Conversation
…ed by absolute positioning (elastic#5130)" This reverts commit bca85fb.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5150/ |
cchaos
approved these changes
Sep 7, 2021
Contributor
cchaos
left a comment
There was a problem hiding this comment.
👍 Thanks for the quick revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #5145
Per @cchaos, we should consider the addition of the
clipproperty to be a breaking change since it may impact other devs who were targeting or overriding.euiScreenReaderOnly(which is what we were doing in #5149).This PR thus reverts #5130, and after it lands, I'll open a new PR that includes both #5130 and #5149 that will be labeled as a breaking change and target
38.0.Checklist
Mostly skipped as this is a straightforward git revert