[EuiResizableContainer] Fix z-index ui bugs#5164
Merged
elizabetdev merged 2 commits intoelastic:masterfrom Sep 10, 2021
Merged
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
Thanks @babs20 for opening this PR! 🎉 Let me get our CI running our tests, build a preview, and then I can start a review: jenkins test this. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5164/ |
elizabetdev
approved these changes
Sep 10, 2021
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
Thanks @babs20! LGTM! 🎉
Tested in Chrome, Safari, Edge, and Firefox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5003
This PR changes:
.euiResizableButtonto usez-index: 1instead ofz-index: $euiZLevel1.euiResizableToggleButtontoz-index: 2instead ofz-index: $euiZLevel1 + 1Both of these changes fix the UI bug which caused the button's separating line and the button itself to overlap the header when the page is scrolled.
Here is a before and after:
Before:
After:
Checklist
- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Added or updated jest tests