React version of angular license view by matschaffer · Pull Request #111317 · elastic/kibana

matschaffer · 2021-09-07T07:22:03Z

Summary

Reactified version of the angular license view

Note that the time selection bar is a bit different.

The angular version has two oddities:

Shows "10s", even though the XHR call is for a 15 minute range
Includes a refresh button and allows refresh interval changes, but neither cause any requests to fire or data to update

I've opted not replicate those since they seem like bugs and it's simpler to just disable the time bar.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

matschaffer · 2021-09-07T13:36:41Z

@elasticmachine update master

matschaffer · 2021-09-07T13:37:51Z

@elasticmachine merge upstream

elasticmachine · 2021-09-07T15:07:21Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

estermv

LGTM 🚀

kibanamachine · 2021-09-07T17:41:26Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 41177c2
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup10

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`monitoring`	583	584	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`monitoring`	778.3KB	781.5KB	+3.2KB

History

💚 Build #151493 succeeded 3e330e5
💔 Build #151539 failed 89c3f0d
💔 Build #151515 failed 68dcdac
💚 Build #151399 succeeded f4c61b2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

* React version of angular license view * Fix time handling and linking to license upload * Use getPageData pattern instead of useClusters * Add note about locked time picker * Add disable support to monitoring toolbar * Disable toolbar on license page only * Remove old todo * Clean up render setup method ordering * Fix CI checks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-09-08T00:21:32Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* React version of angular license view * Fix time handling and linking to license upload * Use getPageData pattern instead of useClusters * Add note about locked time picker * Add disable support to monitoring toolbar * Disable toolbar on license page only * Remove old todo * Clean up render setup method ordering * Fix CI checks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mat Schaffer <mat@elastic.co>

…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (61 commits) [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150) [Archive Migration][Partial] discover apps-discover (elastic#110437) [APM] Set start date of APM ML job to -4 weeks (elastic#111375) [ML] APM Latency Correlations: Code consolidation. (elastic#110790) [Discover] Fix indices permission for multiline test (elastic#111284) [Detection Rules] Add 7.15 rules (elastic#111464) [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064) React version of angular license view (elastic#111317) [APM] Fix link in readme (elastic#111362) [Security Solution] add agent field to generator (elastic#111428) [Dashboard] Retain Tags on Quicksave (elastic#111015) Reorder App Search ingestion methods (elastic#111361) Port performance docs to new docs system. (elastic#111063) [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010) [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885) [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294) Fix copy typo. (elastic#111203) [build] Remove empty optimize directory (elastic#111393) [Maps] fix term join not updating when editing right field (elastic#111030) [Fleet] Set default settings in component template instead of the index template (elastic#111197) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/management/report_listing.test.tsx

* React version of angular license view * Fix time handling and linking to license upload * Use getPageData pattern instead of useClusters * Add note about locked time picker * Add disable support to monitoring toolbar * Disable toolbar on license page only * Remove old todo * Clean up render setup method ordering * Fix CI checks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

React version of angular license view

f4c61b2

matschaffer self-assigned this Sep 7, 2021

matschaffer mentioned this pull request Sep 7, 2021

[Stack monitoring] Convert Angular views to React #111309

Closed

19 tasks

kibanamachine and others added 6 commits September 7, 2021 09:37

Merge branch 'master' into sm-react-license-page

3e330e5

Fix time handling and linking to license upload

68dcdac

Use getPageData pattern instead of useClusters

68b0e3c

Add note about locked time picker

5f7193d

Add disable support to monitoring toolbar

256e01c

Disable toolbar on license page only

2b5068a

matschaffer marked this pull request as ready for review September 7, 2021 15:07

matschaffer requested a review from a team as a code owner September 7, 2021 15:07

matschaffer requested review from a team September 7, 2021 15:07

Remove old todo

89c3f0d

matschaffer added the release_note:skip Skip the PR/issue when compiling release notes label Sep 7, 2021

matschaffer added 2 commits September 8, 2021 00:18

Clean up render setup method ordering

4dcf75b

Fix CI checks

41177c2

estermv approved these changes Sep 7, 2021

View reviewed changes

matschaffer merged commit 7fc4c29 into elastic:master Sep 8, 2021

matschaffer deleted the sm-react-license-page branch September 8, 2021 00:19

kibanamachine mentioned this pull request Sep 8, 2021

[7.x] React version of angular license view (#111317) #111474

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React version of angular license view#111317

React version of angular license view#111317
matschaffer merged 10 commits intoelastic:masterfrom
matschaffer:sm-react-license-page

matschaffer commented Sep 7, 2021 •

edited

Loading

Uh oh!

matschaffer commented Sep 7, 2021

Uh oh!

matschaffer commented Sep 7, 2021

Uh oh!

elasticmachine commented Sep 7, 2021

Uh oh!

estermv left a comment

Uh oh!

kibanamachine commented Sep 7, 2021

Uh oh!

kibanamachine commented Sep 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

matschaffer commented Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

matschaffer commented Sep 7, 2021

Uh oh!

matschaffer commented Sep 7, 2021

Uh oh!

elasticmachine commented Sep 7, 2021

Uh oh!

estermv left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 7, 2021

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

kibanamachine commented Sep 8, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

matschaffer commented Sep 7, 2021 •

edited

Loading