[Logs UI] Fix alert previews for thresholds of 0#111150
Merged
afgomez merged 4 commits intoelastic:masterfrom Sep 8, 2021
Merged
[Logs UI] Fix alert previews for thresholds of 0#111150afgomez merged 4 commits intoelastic:masterfrom
0#111150afgomez merged 4 commits intoelastic:masterfrom
Conversation
added 2 commits
September 3, 2021 16:00
According to the types, if a threshold is present it always has a `threshold.value` so there's no need to check. This also prevents treating a value of `0` as `false`.
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
Author
|
@elasticmachine merge upstream |
weltenwort
requested changes
Sep 6, 2021
Member
weltenwort
left a comment
There was a problem hiding this comment.
The "IS more than 0" is rendered correctly now. 👍
I'm still seeing some surprising behavior in the preview chart, though:
The y axis is still not scaled to include the threshold and only takes the value range of the bars into account. Do we want to make sure that it also includes the threshold if it is below the lowest or above the highest actual value?
Contributor
Author
|
@weltenwort thanks for the review <3! I've pushed a tweak for the change you asked for. |
weltenwort
approved these changes
Sep 7, 2021
Member
weltenwort
left a comment
There was a problem hiding this comment.
Thanks for fixing the y axis range 👍 LGTM, hope jenkins agrees
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 8, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 8, 2021
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (61 commits) [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150) [Archive Migration][Partial] discover apps-discover (elastic#110437) [APM] Set start date of APM ML job to -4 weeks (elastic#111375) [ML] APM Latency Correlations: Code consolidation. (elastic#110790) [Discover] Fix indices permission for multiline test (elastic#111284) [Detection Rules] Add 7.15 rules (elastic#111464) [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064) React version of angular license view (elastic#111317) [APM] Fix link in readme (elastic#111362) [Security Solution] add agent field to generator (elastic#111428) [Dashboard] Retain Tags on Quicksave (elastic#111015) Reorder App Search ingestion methods (elastic#111361) Port performance docs to new docs system. (elastic#111063) [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010) [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885) [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294) Fix copy typo. (elastic#111203) [build] Remove empty optimize directory (elastic#111393) [Maps] fix term join not updating when editing right field (elastic#111030) [Fleet] Set default settings in component template instead of the index template (elastic#111197) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/management/report_listing.test.tsx
kibanamachine
added a commit
that referenced
this pull request
Sep 8, 2021
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Sep 8, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #108496
Ensures the alert previews render correctly when the user introduces a threshold of
0.