Skip to content

[Uptime] Fix copy typo#111203

Merged
justinkambic merged 2 commits intoelastic:masterfrom
justinkambic:110475/fix-typo-in-monitor-drawer-copy
Sep 7, 2021
Merged

[Uptime] Fix copy typo#111203
justinkambic merged 2 commits intoelastic:masterfrom
justinkambic:110475/fix-typo-in-monitor-drawer-copy

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic commented Sep 3, 2021

Summary

Resolves #110475.

Fixes a typo in some of the Uptime app's copy.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 labels Sep 3, 2021
@justinkambic justinkambic self-assigned this Sep 3, 2021
@justinkambic justinkambic requested a review from a team as a code owner September 3, 2021 19:07
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 3, 2021

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic added release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed labels Sep 3, 2021
shahzad31
shahzad31 approved these changes Sep 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@justinkambic
Copy link
Copy Markdown
Contributor Author

justinkambic commented Sep 7, 2021

@elasticmachine merge upstream

@justinkambic justinkambic enabled auto-merge (squash) September 7, 2021 14:11
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 7, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.0MB 1.0MB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit 973645f into elastic:master Sep 7, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 7, 2021
@justinkambic @kibanamachine
Fix copy typo. (elastic#111203)
2d982f9 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 7, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 7, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 7, 2021
@kibanamachine @justinkambic
Fix copy typo. (#111203) (#111427)
d39c8f5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
47aa554 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (61 commits)
  [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150)
  [Archive Migration][Partial] discover apps-discover (elastic#110437)
  [APM] Set start date of APM ML job to -4 weeks (elastic#111375)
  [ML] APM Latency Correlations: Code consolidation. (elastic#110790)
  [Discover] Fix indices permission for multiline test (elastic#111284)
  [Detection Rules] Add 7.15 rules (elastic#111464)
  [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064)
  React version of angular license view (elastic#111317)
  [APM] Fix link in readme (elastic#111362)
  [Security Solution] add agent field to generator (elastic#111428)
  [Dashboard] Retain Tags on Quicksave (elastic#111015)
  Reorder App Search ingestion methods (elastic#111361)
  Port performance docs to new docs system. (elastic#111063)
  [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010)
  [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885)
  [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294)
  Fix copy typo. (elastic#111203)
  [build] Remove empty optimize directory (elastic#111393)
  [Maps] fix term join not updating when editing right field (elastic#111030)
  [Fleet] Set default settings in component template instead of the index template (elastic#111197)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
@justinkambic @kibanamachine @chrisronline
Fix copy typo. (elastic#111203)
129c418 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@justinkambic justinkambic

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] [Monitors] Typo in Enabled Rules section

4 participants

@justinkambic @elasticmachine @kibanamachine @shahzad31