[Security Solution][Endpoint] Fix activity log load empty state flicker#110233
Merged
ashokaditya merged 8 commits intoelastic:masterfrom Aug 30, 2021
ashokaditya:fix/olm-fix_activity_log_load_flicker-107129
Merged
[Security Solution][Endpoint] Fix activity log load empty state flicker#110233ashokaditya merged 8 commits intoelastic:masterfrom ashokaditya:fix/olm-fix_activity_log_load_flicker-107129
ashokaditya merged 8 commits intoelastic:masterfrom
ashokaditya:fix/olm-fix_activity_log_load_flicker-107129
Conversation
Contributor
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
Member
Author
|
@elasticmachine merge upstream |
academo
reviewed
Aug 30, 2021
...ck/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.test.ts
Show resolved
Hide resolved
academo
reviewed
Aug 30, 2021
| it('should not call API again if it fails', async () => { | ||
| dispatchUserChangedUrl(); | ||
|
|
||
| const apiError = new Error('oh oh'); |
academo
reviewed
Aug 30, 2021
...ck/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.test.ts
Outdated
Show resolved
Hide resolved
academo
reviewed
Aug 30, 2021
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts
Show resolved
Hide resolved
Contributor
|
The code looks correct but seems to be hard to follow the way you put it. If you could make it more readable would be optimal. |
review changes
academo
approved these changes
Aug 30, 2021
Contributor
|
Checked it out and tried it. It looks good! The timeline loads nicely with the animation and it doesn't blink like it did before.
LGTM! |
kevinlog
approved these changes
Aug 30, 2021
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 30, 2021
…er (elastic#110233) * account for API errors and uninitialized state before fetching data fixes elastic/issues/107129 * better name refs elastic/pull/102261 * don't show date picker when loading data initially fixes elastic/issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs elastic/pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 30, 2021
…er (elastic#110233) * account for API errors and uninitialized state before fetching data fixes elastic/issues/107129 * better name refs elastic/pull/102261 * don't show date picker when loading data initially fixes elastic/issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs elastic/pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
kibanamachine
added a commit
that referenced
this pull request
Aug 30, 2021
…er (#110233) (#110526) * account for API errors and uninitialized state before fetching data fixes /issues/107129 * better name refs /pull/102261 * don't show date picker when loading data initially fixes /issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs /pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <am.struktr@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Sep 1, 2021
…er (#110233) (#110525) * account for API errors and uninitialized state before fetching data fixes /issues/107129 * better name refs /pull/102261 * don't show date picker when loading data initially fixes /issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs /pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <am.struktr@gmail.com>
Bug Conversion
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes /issues/107129
Summary
This PR adds additional constraints before fetching activity log data so that it's not fetched more than once.
Fixes a bug where parts of the UI are loaded twice because fetching occurs twice, like when API fails.
loaded
on initial load
Checklist
Delete any items that are not applicable to this PR.