[Security Solution][Endpoint] Paginate actions log with infinite scroll by ashokaditya · Pull Request #102261 · elastic/kibana

ashokaditya · 2021-06-15T18:27:43Z

Summary

This PR builds on top of /pull/101032 and /pull/99795 and enables users to paginate data by scrolling to the end of the list instead of clicking on a button.

screenshots

empty state

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

fixes elastic/security-team/issues/1245

refs 4f7d18b

ashokaditya · 2021-06-17T08:51:14Z

@elasticmachine merge upstream

…scroll-1245

fixes elastic/security-team/issues/1245

refs 85e5add

ashokaditya · 2021-06-17T17:56:12Z

@elasticmachine merge upstream

…scroll-1245

ashokaditya · 2021-06-18T06:34:21Z

@elasticmachine merge upstream

kibanamachine · 2021-06-18T06:34:23Z

merge conflict between base and head

…scroll-1245

fixes elastic/security-team/issues/1312

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/reducer.ts

...ion/public/management/pages/endpoint_hosts/view/details/components/endpoint_details_tabs.tsx

...urity_solution/public/management/pages/endpoint_hosts/view/details/endpoint_activity_log.tsx

refs /pull/101032/commits/c4e933a9c5954ce249942ca66bab380c1dfa79e2#diff-41a74ad41665921620230a0729728f3bf6e27a6f9dc302fb37b0d2061637c212R81

refs 697a3c3

...urity_solution/public/management/pages/endpoint_hosts/view/details/endpoint_activity_log.tsx

dasansol92

Just added a question but it LGTM 🔥 . Do you have some check or issue somewhere as a reminder for the infinite scroll component?

ashokaditya · 2021-06-22T08:44:15Z

Just added a question but it LGTM 🔥 . Do you have some check or issue somewhere as a reminder for the infinite scroll component?

I'll create a ticket for refactoring the scroll thingy into a component 😊

ashokaditya · 2021-06-22T08:56:55Z

@elasticmachine merge upstream

…scroll-1245

…et is well hidden below the footer refs 48e3291

paul-tavares

I did not check it out locally and will try to do that a little later. Left some comments and suggestions. let me know if you have any question.

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/action.ts

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/reducer.ts

...ion/public/management/pages/endpoint_hosts/view/details/components/endpoint_details_tabs.tsx

...urity_solution/public/management/pages/endpoint_hosts/view/details/endpoint_activity_log.tsx

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx

…int_hosts/store/reducer.ts Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

…int_hosts/view/index.test.tsx Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

paul-tavares

Looks good. Thanks for the changes. We can refactor later to drive selected tab using the show= param

👍

ashokaditya · 2021-06-22T15:45:15Z

@elasticmachine merge upstream

…scroll-1245

ashokaditya · 2021-06-23T04:56:45Z

@elasticmachine merge upstream

…scroll-1245

…ll (elastic#102261) * Show loading below the list when loading fixes elastic/security-team/issues/1245 * use intersection observer to load data when callout is visible fixes elastic/security-team/issues/1245 * remove unused `total` from API response refs 4f7d18b * toggle ability to paging based on API response and target intersection fixes elastic/security-team/issues/1245 * use a invisible target * display a message when end of log fixes elastic/security-team/issues/1245 * remove search bar fixes elastic/security-team/issues/1245 * refresh data fixes elastic/security-team/issues/1245 * rename refs 85e5add * add refresh button to empty state * add translations for copy * remove refresh button * load activity log for endpoint on activity log tab selection fixes elastic/security-team/issues/1312 * reset paging correctly on activity log tab selection * fix variable mixup refs elastic/pull/101032/commits/c4e933a9c5954ce249942ca66bab380c1dfa79e2#diff-41a74ad41665921620230a0729728f3bf6e27a6f9dc302fb37b0d2061637c212R81 * fix react warning refs 697a3c3 * clean up review changes * use the complicated flyout version instead of styled version refs https://elastic.github.io/eui/#/layout/flyout#more-complicated-flyout refs https://github.com/elastic/kibana/pull/99795/files#r635810660 refs c26a7d4 * Page only when scrolled (so that info message is shown after paging once) fixes elastic/security-team#1245 (comment) * add tests fixes elastic/security-team/issues/1312 fixes elastic/security-team/issues/1245 * increase the parent container's height to ensure that the scroll target is well hidden below the footer refs 48e3291 * Update x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/reducer.ts Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> * Update x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> * address review changes * cleanup callback and effect Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

kibanamachine · 2021-06-23T07:22:00Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…ll (#102261) (#103047) * Show loading below the list when loading fixes elastic/security-team/issues/1245 * use intersection observer to load data when callout is visible fixes elastic/security-team/issues/1245 * remove unused `total` from API response refs 4f7d18b * toggle ability to paging based on API response and target intersection fixes elastic/security-team/issues/1245 * use a invisible target * display a message when end of log fixes elastic/security-team/issues/1245 * remove search bar fixes elastic/security-team/issues/1245 * refresh data fixes elastic/security-team/issues/1245 * rename refs 85e5add * add refresh button to empty state * add translations for copy * remove refresh button * load activity log for endpoint on activity log tab selection fixes elastic/security-team/issues/1312 * reset paging correctly on activity log tab selection * fix variable mixup refs /pull/101032/commits/c4e933a9c5954ce249942ca66bab380c1dfa79e2#diff-41a74ad41665921620230a0729728f3bf6e27a6f9dc302fb37b0d2061637c212R81 * fix react warning refs 697a3c3 * clean up review changes * use the complicated flyout version instead of styled version refs https://elastic.github.io/eui/#/layout/flyout#more-complicated-flyout refs https://github.com/elastic/kibana/pull/99795/files#r635810660 refs c26a7d4 * Page only when scrolled (so that info message is shown after paging once) fixes elastic/security-team#1245 (comment) * add tests fixes elastic/security-team/issues/1312 fixes elastic/security-team/issues/1245 * increase the parent container's height to ensure that the scroll target is well hidden below the footer refs 48e3291 * Update x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/reducer.ts Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> * Update x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> * address review changes * cleanup callback and effect Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Co-authored-by: Ashokaditya <am.struktr@gmail.com> Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

kibanamachine · 2021-06-30T11:32:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: cbd28dd
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/index_lifecycle_management/policies·js.apis management index lifecycle management policies list should have a default policy to manage the Watcher history indices

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/41237

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook in "apis"
[00:05:46]           └-: management
[00:05:46]             └-> "before all" hook in "management"
[00:06:08]             └-: index lifecycle management
[00:06:08]               └-> "before all" hook in "index lifecycle management"
[00:06:08]               └-: policies
[00:06:08]                 └-> "before all" hook in "policies"
[00:06:08]                 └-: list
[00:06:08]                   └-> "before all" hook for "should have a default policy to manage the Watcher history indices"
[00:06:08]                   └-> should have a default policy to manage the Watcher history indices
[00:06:08]                     └-> "before each" hook: global before each for "should have a default policy to manage the Watcher history indices"
[00:06:08]                     └- ✖ fail: apis management index lifecycle management policies list should have a default policy to manage the Watcher history indices
[00:06:08]                     │       Error: expected { version: 1,
[00:06:08]                     │   modified_date: '2019-04-30T14:30:00.000Z',
[00:06:08]                     │   policy: { phases: { delete: [Object] } },
[00:06:08]                     │   in_use_by: 
[00:06:08]                     │    { indices: [],
[00:06:08]                     │      data_streams: [],
[00:06:08]                     │      composable_templates: [ '.watch-history-14' ] },
[00:06:08]                     │   name: 'watch-history-ilm-policy' } to sort of equal { version: 1,
[00:06:08]                     │   modified_date: '2019-04-30T14:30:00.000Z',
[00:06:08]                     │   policy: { phases: { delete: [Object] } },
[00:06:08]                     │   name: 'watch-history-ilm-policy' }
[00:06:08]                     │       + expected - actual
[00:06:08]                     │ 
[00:06:08]                     │        {
[00:06:08]                     │       -  "in_use_by": {
[00:06:08]                     │       -    "composable_templates": [
[00:06:08]                     │       -      ".watch-history-14"
[00:06:08]                     │       -    ]
[00:06:08]                     │       -    "data_streams": []
[00:06:08]                     │       -    "indices": []
[00:06:08]                     │       -  }
[00:06:08]                     │          "modified_date": "2019-04-30T14:30:00.000Z"
[00:06:08]                     │          "name": "watch-history-ilm-policy"
[00:06:08]                     │          "policy": {
[00:06:08]                     │            "phases": {
[00:06:08]                     │       
[00:06:08]                     │       at Assertion.assert (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:06:08]                     │       at Assertion.eql (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:06:08]                     │       at Context.<anonymous> (test/api_integration/apis/management/index_lifecycle_management/policies.js:50:27)
[00:06:08]                     │       at Object.apply (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:06:08]                     │ 
[00:06:08]                     │

Stack Trace

Error: expected { version: 1,
  modified_date: '2019-04-30T14:30:00.000Z',
  policy: { phases: { delete: [Object] } },
  in_use_by: 
   { indices: [],
     data_streams: [],
     composable_templates: [ '.watch-history-14' ] },
  name: 'watch-history-ilm-policy' } to sort of equal { version: 1,
  modified_date: '2019-04-30T14:30:00.000Z',
  policy: { phases: { delete: [Object] } },
  name: 'watch-history-ilm-policy' }
    at Assertion.assert (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/management/index_lifecycle_management/policies.js:50:27)
    at Object.apply (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16) {
  actual: '{\n' +
    '  "in_use_by": {\n' +
    '    "composable_templates": [\n' +
    '      ".watch-history-14"\n' +
    '    ]\n' +
    '    "data_streams": []\n' +
    '    "indices": []\n' +
    '  }\n' +
    '  "modified_date": "2019-04-30T14:30:00.000Z"\n' +
    '  "name": "watch-history-ilm-policy"\n' +
    '  "policy": {\n' +
    '    "phases": {\n' +
    '      "delete": {\n' +
    '        "actions": {\n' +
    '          "delete": {\n' +
    '            "delete_searchable_snapshot": true\n' +
    '          }\n' +
    '        }\n' +
    '        "min_age": "7d"\n' +
    '      }\n' +
    '    }\n' +
    '  }\n' +
    '  "version": 1\n' +
    '}',
  expected: '{\n' +
    '  "modified_date": "2019-04-30T14:30:00.000Z"\n' +
    '  "name": "watch-history-ilm-policy"\n' +
    '  "policy": {\n' +
    '    "phases": {\n' +
    '      "delete": {\n' +
    '        "actions": {\n' +
    '          "delete": {\n' +
    '            "delete_searchable_snapshot": true\n' +
    '          }\n' +
    '        }\n' +
    '        "min_age": "7d"\n' +
    '      }\n' +
    '    }\n' +
    '  }\n' +
    '  "version": 1\n' +
    '}',
  showDiff: true
}

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/index_lifecycle_management/policies·js.apis management index lifecycle management policies list should have a default policy to manage the Watcher history indices

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/41237

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook in "apis"
[00:05:43]           └-: management
[00:05:43]             └-> "before all" hook in "management"
[00:06:07]             └-: index lifecycle management
[00:06:07]               └-> "before all" hook in "index lifecycle management"
[00:06:07]               └-: policies
[00:06:07]                 └-> "before all" hook in "policies"
[00:06:07]                 └-: list
[00:06:07]                   └-> "before all" hook for "should have a default policy to manage the Watcher history indices"
[00:06:07]                   └-> should have a default policy to manage the Watcher history indices
[00:06:07]                     └-> "before each" hook: global before each for "should have a default policy to manage the Watcher history indices"
[00:06:07]                     └- ✖ fail: apis management index lifecycle management policies list should have a default policy to manage the Watcher history indices
[00:06:07]                     │       Error: expected { version: 1,
[00:06:07]                     │   modified_date: '2019-04-30T14:30:00.000Z',
[00:06:07]                     │   policy: { phases: { delete: [Object] } },
[00:06:07]                     │   in_use_by: 
[00:06:07]                     │    { indices: [],
[00:06:07]                     │      data_streams: [],
[00:06:07]                     │      composable_templates: [ '.watch-history-14' ] },
[00:06:07]                     │   name: 'watch-history-ilm-policy' } to sort of equal { version: 1,
[00:06:07]                     │   modified_date: '2019-04-30T14:30:00.000Z',
[00:06:07]                     │   policy: { phases: { delete: [Object] } },
[00:06:07]                     │   name: 'watch-history-ilm-policy' }
[00:06:07]                     │       + expected - actual
[00:06:07]                     │ 
[00:06:07]                     │        {
[00:06:07]                     │       -  "in_use_by": {
[00:06:07]                     │       -    "composable_templates": [
[00:06:07]                     │       -      ".watch-history-14"
[00:06:07]                     │       -    ]
[00:06:07]                     │       -    "data_streams": []
[00:06:07]                     │       -    "indices": []
[00:06:07]                     │       -  }
[00:06:07]                     │          "modified_date": "2019-04-30T14:30:00.000Z"
[00:06:07]                     │          "name": "watch-history-ilm-policy"
[00:06:07]                     │          "policy": {
[00:06:07]                     │            "phases": {
[00:06:07]                     │       
[00:06:07]                     │       at Assertion.assert (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:06:07]                     │       at Assertion.eql (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:06:07]                     │       at Context.<anonymous> (test/api_integration/apis/management/index_lifecycle_management/policies.js:50:27)
[00:06:07]                     │       at Object.apply (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:06:07]                     │ 
[00:06:07]                     │

Stack Trace

Error: expected { version: 1,
  modified_date: '2019-04-30T14:30:00.000Z',
  policy: { phases: { delete: [Object] } },
  in_use_by: 
   { indices: [],
     data_streams: [],
     composable_templates: [ '.watch-history-14' ] },
  name: 'watch-history-ilm-policy' } to sort of equal { version: 1,
  modified_date: '2019-04-30T14:30:00.000Z',
  policy: { phases: { delete: [Object] } },
  name: 'watch-history-ilm-policy' }
    at Assertion.assert (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at Context.<anonymous> (test/api_integration/apis/management/index_lifecycle_management/policies.js:50:27)
    at Object.apply (/dev/shm/workspace/parallel/6/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16) {
  actual: '{\n' +
    '  "in_use_by": {\n' +
    '    "composable_templates": [\n' +
    '      ".watch-history-14"\n' +
    '    ]\n' +
    '    "data_streams": []\n' +
    '    "indices": []\n' +
    '  }\n' +
    '  "modified_date": "2019-04-30T14:30:00.000Z"\n' +
    '  "name": "watch-history-ilm-policy"\n' +
    '  "policy": {\n' +
    '    "phases": {\n' +
    '      "delete": {\n' +
    '        "actions": {\n' +
    '          "delete": {\n' +
    '            "delete_searchable_snapshot": true\n' +
    '          }\n' +
    '        }\n' +
    '        "min_age": "7d"\n' +
    '      }\n' +
    '    }\n' +
    '  }\n' +
    '  "version": 1\n' +
    '}',
  expected: '{\n' +
    '  "modified_date": "2019-04-30T14:30:00.000Z"\n' +
    '  "name": "watch-history-ilm-policy"\n' +
    '  "policy": {\n' +
    '    "phases": {\n' +
    '      "delete": {\n' +
    '        "actions": {\n' +
    '          "delete": {\n' +
    '            "delete_searchable_snapshot": true\n' +
    '          }\n' +
    '        }\n' +
    '        "min_age": "7d"\n' +
    '      }\n' +
    '    }\n' +
    '  }\n' +
    '  "version": 1\n' +
    '}',
  showDiff: true
}

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2188	2189	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.5MB	6.5MB	+5.9KB

History

💛 Build #133419 was flaky cbd28dd
💚 Build #133210 succeeded 24625d9
💚 Build #133188 succeeded c4845a8
💔 Build #133152 failed 6f34ef606c94b565e2a1bf8ef7a6077cb645744d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…er (#110233) * account for API errors and uninitialized state before fetching data fixes /issues/107129 * better name refs /pull/102261 * don't show date picker when loading data initially fixes /issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs /pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…er (elastic#110233) * account for API errors and uninitialized state before fetching data fixes elastic/issues/107129 * better name refs elastic/pull/102261 * don't show date picker when loading data initially fixes elastic/issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs elastic/pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…er (#110233) (#110526) * account for API errors and uninitialized state before fetching data fixes /issues/107129 * better name refs /pull/102261 * don't show date picker when loading data initially fixes /issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs /pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <am.struktr@gmail.com>

…er (#110233) (#110525) * account for API errors and uninitialized state before fetching data fixes /issues/107129 * better name refs /pull/102261 * don't show date picker when loading data initially fixes /issues/107129 * use a readable selector instead review changes * remove redundant data fetch using paging action on tab switch. refs /pull/102261 * remove redundant validation review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <am.struktr@gmail.com>

Show loading below the list when loading

f8857a2

fixes elastic/security-team/issues/1245

ashokaditya added v8.0.0 Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 release_note:feature Makes this part of the condensed release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 15, 2021

ashokaditya changed the title ~~Paginate actions log with infinite scroll~~ [Security Solution][Endpoint] Paginate actions log with infinite scroll Jun 15, 2021

ashokaditya added 2 commits June 16, 2021 16:52

use intersection observer to load data when callout is visible

108381c

fixes elastic/security-team/issues/1245

remove unused total from API response

2d16e93

refs 4f7d18b

kibanamachine and others added 8 commits June 17, 2021 04:51

Merge branch 'master' into feature/olm-paginate_actions_log_infinite_…

117b724

…scroll-1245

toggle ability to paging based on API response and target intersection

af7a376

fixes elastic/security-team/issues/1245

use a invisible target

85e5add

display a message when end of log

697a3c3

fixes elastic/security-team/issues/1245

remove search bar

4483a02

fixes elastic/security-team/issues/1245

refresh data

2343fda

fixes elastic/security-team/issues/1245

rename

78f90b6

refs 85e5add

add refresh button to empty state

948dc19

kibanamachine and others added 2 commits June 17, 2021 13:56

Merge branch 'master' into feature/olm-paginate_actions_log_infinite_…

fd4ef20

…scroll-1245

add translations for copy

5ca6591

ashokaditya added 4 commits June 18, 2021 08:35

Merge branch 'master' into feature/olm-paginate_actions_log_infinite_…

c351cd0

…scroll-1245

remove refresh button

85b3c62

load activity log for endpoint on activity log tab selection

12d56e6

fixes elastic/security-team/issues/1312

reset paging correctly on activity log tab selection

b29f62a

dasansol92 reviewed Jun 18, 2021

View reviewed changes

ashokaditya added 2 commits June 18, 2021 21:14

fix variable mixup

a6f5d7a

refs /pull/101032/commits/c4e933a9c5954ce249942ca66bab380c1dfa79e2#diff-41a74ad41665921620230a0729728f3bf6e27a6f9dc302fb37b0d2061637c212R81

fix react warning

24d4fe2

refs 697a3c3

dasansol92 reviewed Jun 22, 2021

View reviewed changes

...urity_solution/public/management/pages/endpoint_hosts/view/details/endpoint_activity_log.tsx Show resolved Hide resolved

dasansol92 approved these changes Jun 22, 2021

View reviewed changes

kibanamachine and others added 2 commits June 22, 2021 04:56

Merge branch 'master' into feature/olm-paginate_actions_log_infinite_…

62cb8d0

…scroll-1245

increase the parent container's height to ensure that the scroll targ…

dbee6e4

…et is well hidden below the footer refs 48e3291

paul-tavares reviewed Jun 22, 2021

View reviewed changes

ashokaditya and others added 4 commits June 22, 2021 15:30

Update x-pack/plugins/security_solution/public/management/pages/endpo…

f9a5d12

…int_hosts/store/reducer.ts Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

Update x-pack/plugins/security_solution/public/management/pages/endpo…

9f5ba87

…int_hosts/view/index.test.tsx Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

address review changes

7e962e4

cleanup callback and effect

c4845a8

paul-tavares approved these changes Jun 22, 2021

View reviewed changes

Merge branch 'master' into feature/olm-paginate_actions_log_infinite_…

24625d9

…scroll-1245

Merge branch 'master' into feature/olm-paginate_actions_log_infinite_…

cbd28dd

…scroll-1245

ashokaditya merged commit b12ddfa into elastic:master Jun 23, 2021

ashokaditya deleted the feature/olm-paginate_actions_log_infinite_scroll-1245 branch June 23, 2021 07:19

kibanamachine mentioned this pull request Jun 23, 2021

[7.x] [Security Solution][Endpoint] Paginate actions log with infinite scroll (#102261) #103047

Merged

kevinlog mentioned this pull request Jun 23, 2021

[Security Solution] Show more button is displayed even when there is no log activity #103070

Closed

ashokaditya mentioned this pull request Jun 30, 2021

[Security Solution][Endpoint] Allow activity log scrolling on small screens #103852

Merged

Conversation

ashokaditya commented Jun 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

ashokaditya commented Jun 17, 2021

Uh oh!

ashokaditya commented Jun 17, 2021

Uh oh!

ashokaditya commented Jun 18, 2021

Uh oh!

kibanamachine commented Jun 18, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

ashokaditya commented Jun 22, 2021

Uh oh!

ashokaditya commented Jun 22, 2021

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

ashokaditya commented Jun 22, 2021

Uh oh!

ashokaditya commented Jun 23, 2021

Uh oh!

kibanamachine commented Jun 23, 2021

💚 Backport successful

Uh oh!

kibanamachine commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ashokaditya commented Jun 15, 2021 •

edited

Loading

kibanamachine commented Jun 30, 2021 •

edited

Loading